Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17686,
    "url": "https://patches.dpdk.org/api/patches/17686/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1480960243-29173-1-git-send-email-thomas.monjalon@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1480960243-29173-1-git-send-email-thomas.monjalon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1480960243-29173-1-git-send-email-thomas.monjalon@6wind.com",
    "date": "2016-12-05T17:50:43",
    "name": "[dpdk-dev] use config flags for target OS checks",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "a3d475a9c020a3147bdf8c654c7c3bc6bbc3c0ed",
    "submitter": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/people/1/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas.monjalon@6wind.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1480960243-29173-1-git-send-email-thomas.monjalon@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/17686/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/17686/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7C2CC2C4F;\n\tMon,  5 Dec 2016 18:50:51 +0100 (CET)",
            "from mail-wm0-f42.google.com (mail-wm0-f42.google.com\n\t[74.125.82.42]) by dpdk.org (Postfix) with ESMTP id E95092C4B\n\tfor <dev@dpdk.org>; Mon,  5 Dec 2016 18:50:49 +0100 (CET)",
            "by mail-wm0-f42.google.com with SMTP id g23so105331760wme.1\n\tfor <dev@dpdk.org>; Mon, 05 Dec 2016 09:50:49 -0800 (PST)",
            "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\tvr9sm21490529wjc.35.2016.12.05.09.50.48 for <dev@dpdk.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 05 Dec 2016 09:50:48 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id;\n\tbh=XveUya9qnqii1xRBCumyCPIM0RWR9PKD57Y632jtiZ4=;\n\tb=OmfRPvhNpz1luWeRVcvJgPkne7Ft8kFqkgPFCVbf/NxKaYm6LJChhY4xrrVJAh03A7\n\tAhz1BQ2CtD0WR2Kd+Y6d2Ypl1om4cg6Gd3ZaqtdqjAUtkLnM48xEn6raKjO/khGBKvU/\n\tneJXqw5G4z/xwwCBBAfFeFTK782RDyKOdu2lA5Xvl6yOz3HcBHzd/KNyXXCcfuart04p\n\tXwutJPC4rxm11elMMOIqlB4rPkk/uNAZF3ze2oHUGvZTIPrRegUFdoXN9JMByXZqsInd\n\trfxYVM1koLMX8NBCz8vtw/oLfnTgWeHLcBHS+OQTEeweir681CbDUAMuWyjH4ubifLJh\n\t6+3Q==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=XveUya9qnqii1xRBCumyCPIM0RWR9PKD57Y632jtiZ4=;\n\tb=JC6cgLS1OTNwyem5IzxuTK1mWKO8SxZgkjv96JgwhKceqmTFftu+LZDEfhIHn5wHx0\n\tw+bPrID41A1bFL5fdagOXy4Cno3C0jZnp8gBnS3F6XHg1v4J2Ag444iurHz1jWt2bH61\n\tseQ3OT66Cbss6wmFf02eJcXbsfanKmfgDbz29V3RcMZFuKVXpmJkUGc07ydIA5BUD3zw\n\tFzw0vD66N8jEv7Sj031y8nVtawD9tqaz3yill0lIV4td0UMzVtnq9xPx8AdvQrF21XOZ\n\trz8fCkqs8X/yVNvn+bI+g/5PFLiTiGR5ogNiap0WrYSkYCtIfnO8CHymQAUIEp9rMsqq\n\t7oAA==",
        "X-Gm-Message-State": "AKaTC01BId6Cwscm5db+rMQwc5VZ3Rp3/ZANhGmyppKJd8zy+LEahndAVPf47yf0Nt9IXwzJ",
        "X-Received": "by 10.28.135.3 with SMTP id j3mr10035667wmd.96.1480960249375;\n\tMon, 05 Dec 2016 09:50:49 -0800 (PST)",
        "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon,  5 Dec 2016 18:50:43 +0100",
        "Message-Id": "<1480960243-29173-1-git-send-email-thomas.monjalon@6wind.com>",
        "X-Mailer": "git-send-email 2.7.0",
        "Subject": "[dpdk-dev] [PATCH] use config flags for target OS checks",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Clean up the code to always use the flags RTE_EXEC_ENV_*APP\nset up in the DPDK configuration instead of the native ones.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n app/test-pmd/cmdline.c                       | 4 ++--\n app/test/commands.c                          | 4 ++--\n app/test/test_cmdline_ipaddr.c               | 4 ++--\n drivers/net/bnx2x/bnx2x.c                    | 4 ++--\n drivers/net/bnx2x/bnx2x.h                    | 4 ++--\n examples/cmdline/commands.c                  | 4 ++--\n lib/librte_cmdline/cmdline_parse_etheraddr.c | 2 +-\n lib/librte_cmdline/cmdline_parse_ipaddr.c    | 4 ++--\n lib/librte_eal/common/include/rte_lcore.h    | 4 ++--\n 9 files changed, 17 insertions(+), 17 deletions(-)",
    "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 63b55dc..7f3667d 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -41,8 +41,8 @@\n #include <termios.h>\n #include <unistd.h>\n #include <inttypes.h>\n-#ifndef __linux__\n-#ifndef __FreeBSD__\n+#ifndef RTE_EXEC_ENV_LINUXAPP\n+#ifndef RTE_EXEC_ENV_BSDAPP\n #include <net/socket.h>\n #else\n #include <sys/socket.h>\ndiff --git a/app/test/commands.c b/app/test/commands.c\nindex 2df46b0..da0c035 100644\n--- a/app/test/commands.c\n+++ b/app/test/commands.c\n@@ -39,8 +39,8 @@\n #include <stdlib.h>\n #include <netinet/in.h>\n #include <termios.h>\n-#ifndef __linux__\n-#ifndef __FreeBSD__\n+#ifndef RTE_EXEC_ENV_LINUXAPP\n+#ifndef RTE_EXEC_ENV_BSDAPP\n #include <net/socket.h>\n #endif\n #endif\ndiff --git a/app/test/test_cmdline_ipaddr.c b/app/test/test_cmdline_ipaddr.c\nindex 471d2ff..16570fb 100644\n--- a/app/test/test_cmdline_ipaddr.c\n+++ b/app/test/test_cmdline_ipaddr.c\n@@ -36,8 +36,8 @@\n #include <inttypes.h>\n #include <netinet/in.h>\n \n-#ifndef __linux__\n-#ifndef __FreeBSD__\n+#ifndef RTE_EXEC_ENV_LINUXAPP\n+#ifndef RTE_EXEC_ENV_BSDAPP\n #include <net/socket.h>\n #else\n #include <sys/socket.h>\ndiff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c\nindex 2856630..47cf5d3 100644\n--- a/drivers/net/bnx2x/bnx2x.c\n+++ b/drivers/net/bnx2x/bnx2x.c\n@@ -9484,7 +9484,7 @@ static int bnx2x_pci_get_caps(struct bnx2x_softc *sc)\n \t\treturn -ENOMEM;\n \t}\n \n-#ifndef __FreeBSD__\n+#ifndef RTE_EXEC_ENV_BSDAPP\n \tpci_read(sc, PCI_STATUS, &status, 2);\n \tif (!(status & PCI_STATUS_CAP_LIST)) {\n #else\n@@ -9495,7 +9495,7 @@ static int bnx2x_pci_get_caps(struct bnx2x_softc *sc)\n \t\treturn -1;\n \t}\n \n-#ifndef __FreeBSD__\n+#ifndef RTE_EXEC_ENV_BSDAPP\n \tpci_read(sc, PCI_CAPABILITY_LIST, &pci_cap.next, 1);\n #else\n \tpci_read(sc, PCIR_CAP_PTR, &pci_cap.next, 1);\ndiff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h\nindex 5cefea4..006ad28 100644\n--- a/drivers/net/bnx2x/bnx2x.h\n+++ b/drivers/net/bnx2x/bnx2x.h\n@@ -41,7 +41,7 @@\n \n #include \"elink.h\"\n \n-#ifndef __FreeBSD__\n+#ifndef RTE_EXEC_ENV_BSDAPP\n #include <linux/pci_regs.h>\n \n #define PCIY_PMG                       PCI_CAP_ID_PM\n@@ -71,7 +71,7 @@\n #define IFM_10G_TWINAX                 22 /* 10GBase Twinax copper */\n #define IFM_10G_T                      26 /* 10GBase-T - RJ45 */\n \n-#ifndef __FreeBSD__\n+#ifndef RTE_EXEC_ENV_BSDAPP\n #define PCIR_EXPRESS_DEVICE_STA        PCI_EXP_TYPE_RC_EC\n #define PCIM_EXP_STA_TRANSACTION_PND   PCI_EXP_DEVSTA_TRPND\n #define PCIR_EXPRESS_LINK_STA          PCI_EXP_LNKSTA\ndiff --git a/examples/cmdline/commands.c b/examples/cmdline/commands.c\nindex f3ba247..205a205 100644\n--- a/examples/cmdline/commands.c\n+++ b/examples/cmdline/commands.c\n@@ -66,8 +66,8 @@\n #include <errno.h>\n #include <netinet/in.h>\n #include <termios.h>\n-#ifndef __linux__\n-\t#ifdef __FreeBSD__\n+#ifndef RTE_EXEC_ENV_LINUXAPP\n+\t#ifdef RTE_EXEC_ENV_BSDAPP\n \t\t#include <sys/socket.h>\n \t#else\n \t\t#include <net/socket.h>\ndiff --git a/lib/librte_cmdline/cmdline_parse_etheraddr.c b/lib/librte_cmdline/cmdline_parse_etheraddr.c\nindex dbfe4a6..1f26426 100644\n--- a/lib/librte_cmdline/cmdline_parse_etheraddr.c\n+++ b/lib/librte_cmdline/cmdline_parse_etheraddr.c\n@@ -85,7 +85,7 @@ struct cmdline_token_ops cmdline_token_etheraddr_ops = {\n #define ETHER_ADDRSTRLENLONG 18\n #define ETHER_ADDRSTRLENSHORT 15\n \n-#ifdef __linux__\n+#ifdef RTE_EXEC_ENV_LINUXAPP\n #define ea_oct ether_addr_octet\n #else\n #define ea_oct octet\ndiff --git a/lib/librte_cmdline/cmdline_parse_ipaddr.c b/lib/librte_cmdline/cmdline_parse_ipaddr.c\nindex d3d3e04..4ef1c57 100644\n--- a/lib/librte_cmdline/cmdline_parse_ipaddr.c\n+++ b/lib/librte_cmdline/cmdline_parse_ipaddr.c\n@@ -86,8 +86,8 @@\n #include <string.h>\n #include <errno.h>\n #include <netinet/in.h>\n-#ifndef __linux__\n-#ifndef __FreeBSD__\n+#ifndef RTE_EXEC_ENV_LINUXAPP\n+#ifndef RTE_EXEC_ENV_BSDAPP\n #include <net/socket.h>\n #else\n #include <sys/socket.h>\ndiff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h\nindex fe7b586..f74bc0c 100644\n--- a/lib/librte_eal/common/include/rte_lcore.h\n+++ b/lib/librte_eal/common/include/rte_lcore.h\n@@ -50,9 +50,9 @@ extern \"C\" {\n \n #define LCORE_ID_ANY     UINT32_MAX       /**< Any lcore. */\n \n-#if defined(__linux__)\n+#if defined(RTE_EXEC_ENV_LINUXAPP)\n \ttypedef\tcpu_set_t rte_cpuset_t;\n-#elif defined(__FreeBSD__)\n+#elif defined(RTE_EXEC_ENV_BSDAPP)\n #include <pthread_np.h>\n \ttypedef cpuset_t rte_cpuset_t;\n #endif\n",
    "prefixes": [
        "dpdk-dev"
    ]
}