Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17667/?format=api
{ "id": 17667, "url": "https://patches.dpdk.org/api/patches/17667/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1480889826-3891-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1480889826-3891-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1480889826-3891-1-git-send-email-thomas.monjalon@6wind.com", "date": "2016-12-04T22:17:06", "name": "[dpdk-dev] config: remove insecure warnings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b939ef521c4bd64b73f26c8941117f92ac4c85ba", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1480889826-3891-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/17667/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/17667/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6AFCB5678;\n\tSun, 4 Dec 2016 23:17:48 +0100 (CET)", "from mail-wj0-f176.google.com (mail-wj0-f176.google.com\n\t[209.85.210.176]) by dpdk.org (Postfix) with ESMTP id 8C4354A59\n\tfor <dev@dpdk.org>; Sun, 4 Dec 2016 23:17:45 +0100 (CET)", "by mail-wj0-f176.google.com with SMTP id xy5so275408482wjc.0\n\tfor <dev@dpdk.org>; Sun, 04 Dec 2016 14:17:45 -0800 (PST)", "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\ti132sm14864305wmf.14.2016.12.04.14.17.43 for <dev@dpdk.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 04 Dec 2016 14:17:43 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id;\n\tbh=HEVFlsBTKQJsYNeZj9Q0MoitWGSpQM8GKseZpCeW2PU=;\n\tb=BmO7TEdVTAfdidOkRSa2P2uJYGA1pt4SdUNkUdTB5ruKTpzVO8xFHTOcu1jOe35gbd\n\tLN9mcGjoT4uNw6lyNVSDgU7g6Yg+XUmN6eKkoDfmJXJ8d3DNa9OPPbFt3ze0MrWeld5y\n\tAANL7ROs8F4CnMx/nB1zT4W+qKoVH5C4eHKXypfoTvLYDp/hEGJwRMfzxkQcVmyDw6cZ\n\tMjUB4joDV2GsbXKarwn6aH8dVgDmfSoxqhZZW9CF/d9BY95gXjzEQsFTRG6rWU4hPmYB\n\tR4qdKl0bolt2PQCjkQlrDkAbbnZ0xvPWsprHm+YzLZnWaGfg7xtD7LIUJlQU1TRTpMx0\n\t5yOA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=HEVFlsBTKQJsYNeZj9Q0MoitWGSpQM8GKseZpCeW2PU=;\n\tb=DYdcdrIt0gGfPOFI5eDGuFVScBSLET3EszpNbRlC65JZcYuiDf0qXzlda/tSLOv5Hl\n\tCF4Ah+tTpJqZqofCD93dMRyKTuyJ2zuJjIKlFuzNL8BpsDJjwOYCx+qjFepKY9i3QO8E\n\tlZNEsl/giJ5r3ok4ewn9RAmo/z3vGX4pipPi+sb9lX9ZSgGdln8LVgupLQpAwV/4yBaj\n\tWOcYNkld6ZeqLXZoZBpCiowgjMdbN9vRh891MQgh+0FpRay+5hnKSDIFIhlxPdIp7GED\n\tnhrMwJvF3qb41s08gBD1WGtpX8nAz/caJwfESDZbpJsVYRFR63Obk8J9cDY8IG0IFszA\n\tx4sQ==", "X-Gm-Message-State": "AKaTC002/imr/3ZYaq4aXqHeIEMEgtXKzGvxrmpFFSbz5tZaX3J2/av17LstC1E7l/RbCI6X", "X-Received": "by 10.194.235.98 with SMTP id ul2mr46335206wjc.229.1480889864916;\n\tSun, 04 Dec 2016 14:17:44 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Sun, 4 Dec 2016 23:17:06 +0100", "Message-Id": "<1480889826-3891-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "Subject": "[dpdk-dev] [PATCH] config: remove insecure warnings", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There was an option CONFIG_RTE_INSECURE_FUNCTION_WARNING (disabled by\ndefault), which prevents from using some libc functions:\nsprintf, snprintf, vsnprintf, strcpy, strncpy, strcat, strncat, sscanf,\nstrtok, strsep and strlen.\n\nIt's all about using them at the right place with the right precautions.\nHowever, it is neither really possible nor a good advice to disable them.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n config/common_base | 5 --\n doc/api/doxy-api-index.md | 1 -\n lib/librte_eal/common/Makefile | 4 --\n lib/librte_eal/common/include/rte_warnings.h | 84 ----------------------------\n mk/target/generic/rte.vars.mk | 6 --\n 5 files changed, 100 deletions(-)\n delete mode 100644 lib/librte_eal/common/include/rte_warnings.h", "diff": "diff --git a/config/common_base b/config/common_base\nindex 652a839..edb6a54 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -574,11 +574,6 @@ CONFIG_RTE_LIBRTE_PMD_VHOST=n\n CONFIG_RTE_LIBRTE_XEN_DOM0=n\n \n #\n-# Enable warning directives\n-#\n-CONFIG_RTE_INSECURE_FUNCTION_WARNING=n\n-\n-#\n # Compile the test application\n #\n CONFIG_RTE_APP_TEST=y\ndiff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md\nindex 6675f96..f3b3727 100644\n--- a/doc/api/doxy-api-index.md\n+++ b/doc/api/doxy-api-index.md\n@@ -139,7 +139,6 @@ There are many libraries, so their headers may be grouped by topics:\n [hexdump] (@ref rte_hexdump.h),\n [debug] (@ref rte_debug.h),\n [log] (@ref rte_log.h),\n- [warnings] (@ref rte_warnings.h),\n [errno] (@ref rte_errno.h)\n \n - **misc**:\ndiff --git a/lib/librte_eal/common/Makefile b/lib/librte_eal/common/Makefile\nindex dfd64aa..a92c984 100644\n--- a/lib/librte_eal/common/Makefile\n+++ b/lib/librte_eal/common/Makefile\n@@ -42,10 +42,6 @@ INC += rte_hexdump.h rte_devargs.h rte_dev.h rte_vdev.h\n INC += rte_pci_dev_feature_defs.h rte_pci_dev_features.h\n INC += rte_malloc.h rte_keepalive.h rte_time.h\n \n-ifeq ($(CONFIG_RTE_INSECURE_FUNCTION_WARNING),y)\n-INC += rte_warnings.h\n-endif\n-\n GENERIC_INC := rte_atomic.h rte_byteorder.h rte_cycles.h rte_prefetch.h\n GENERIC_INC += rte_spinlock.h rte_memcpy.h rte_cpuflags.h rte_rwlock.h\n # defined in mk/arch/$(RTE_ARCH)/rte.vars.mk\ndiff --git a/lib/librte_eal/common/include/rte_warnings.h b/lib/librte_eal/common/include/rte_warnings.h\ndeleted file mode 100644\nindex 54b545c..0000000\n--- a/lib/librte_eal/common/include/rte_warnings.h\n+++ /dev/null\n@@ -1,84 +0,0 @@\n-/*-\n- * BSD LICENSE\n- *\n- * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.\n- * All rights reserved.\n- *\n- * Redistribution and use in source and binary forms, with or without\n- * modification, are permitted provided that the following conditions\n- * are met:\n- *\n- * * Redistributions of source code must retain the above copyright\n- * notice, this list of conditions and the following disclaimer.\n- * * Redistributions in binary form must reproduce the above copyright\n- * notice, this list of conditions and the following disclaimer in\n- * the documentation and/or other materials provided with the\n- * distribution.\n- * * Neither the name of Intel Corporation nor the names of its\n- * contributors may be used to endorse or promote products derived\n- * from this software without specific prior written permission.\n- *\n- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n- * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n- */\n-\n-/**\n- * @file\n- * Definitions of warnings for use of various insecure functions\n- */\n-\n-#ifndef _RTE_WARNINGS_H_\n-#define _RTE_WARNINGS_H_\n-\n-#ifdef RTE_INSECURE_FUNCTION_WARNING\n-\n-/* we need to include all used standard header files so that they appear\n- * _before_ we poison the function names.\n- */\n-\n-#include <stdio.h>\n-#include <stdlib.h>\n-#include <string.h>\n-#include <stdarg.h>\n-#include <errno.h>\n-#ifdef RTE_EXEC_ENV_LINUXAPP\n-#include <dirent.h>\n-#endif\n-\n-/* the following function are deemed not fully secure for use e.g. they\n- * do not always null-terminate arguments */\n-#pragma GCC poison sprintf strtok snprintf vsnprintf\n-#pragma GCC poison strlen strcpy strcat\n-#pragma GCC poison sscanf\n-\n-/* other unsafe functions may be implemented as macros so just undef them */\n-#ifdef strsep\n-#undef strsep\n-#else\n-#pragma GCC poison strsep\n-#endif\n-\n-#ifdef strncpy\n-#undef strncpy\n-#else\n-#pragma GCC poison strncpy\n-#endif\n-\n-#ifdef strncat\n-#undef strncat\n-#else\n-#pragma GCC poison strncat\n-#endif\n-\n-#endif\n-\n-#endif /* RTE_WARNINGS_H */\ndiff --git a/mk/target/generic/rte.vars.mk b/mk/target/generic/rte.vars.mk\nindex b31e426..5d22a6a 100644\n--- a/mk/target/generic/rte.vars.mk\n+++ b/mk/target/generic/rte.vars.mk\n@@ -125,9 +125,6 @@ LDFLAGS += -L$(RTE_OUTPUT)/lib\n ifeq ($(BUILDING_RTE_SDK),1)\n # building sdk\n CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h\n-ifeq ($(CONFIG_RTE_INSECURE_FUNCTION_WARNING),y)\n-CFLAGS += -include rte_warnings.h\n-endif\n else\n # if we are building an external application, include SDK's lib and\n # includes too\n@@ -136,9 +133,6 @@ ifneq ($(wildcard $(RTE_OUTPUT)/include/rte_config.h),)\n CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h\n endif\n CFLAGS += -include $(RTE_SDK_BIN)/include/rte_config.h\n-ifeq ($(CONFIG_RTE_INSECURE_FUNCTION_WARNING),y)\n-CFLAGS += -include rte_warnings.h\n-endif\n LDFLAGS += -L$(RTE_SDK_BIN)/lib\n endif\n \n", "prefixes": [ "dpdk-dev" ] }