Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1747,
    "url": "https://patches.dpdk.org/api/patches/1747/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1417639668-23500-3-git-send-email-thomas.monjalon@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1417639668-23500-3-git-send-email-thomas.monjalon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1417639668-23500-3-git-send-email-thomas.monjalon@6wind.com",
    "date": "2014-12-03T20:47:48",
    "name": "[dpdk-dev,2/2] app/testpmd: fix endianness detection",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "58f8b6560a38bf421af54b520d6e9858e0386b0e",
    "submitter": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/people/1/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas.monjalon@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1417639668-23500-3-git-send-email-thomas.monjalon@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/1747/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/1747/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 350D07F58;\n\tWed,  3 Dec 2014 21:49:13 +0100 (CET)",
            "from mail-wi0-f180.google.com (mail-wi0-f180.google.com\n\t[209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 1CA59559C\n\tfor <dev@dpdk.org>; Wed,  3 Dec 2014 21:49:12 +0100 (CET)",
            "by mail-wi0-f180.google.com with SMTP id n3so25759042wiv.7\n\tfor <dev@dpdk.org>; Wed, 03 Dec 2014 12:49:12 -0800 (PST)",
            "from XPS13.localdomain (188.20.90.92.rev.sfr.net. [92.90.20.188])\n\tby mx.google.com with ESMTPSA id\n\thz9sm37761878wjb.17.2014.12.03.12.49.02 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 03 Dec 2014 12:49:11 -0800 (PST)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=66Cf55NcqyRzle9c1rdBgopf3y5JYR+elY0NwoI9rAY=;\n\tb=Oj4+9XgYe2XQZM6VLcDrxA6u4zuguUYb6dGr2oAXt+RnvFu1ARrLXhcxtxaF1vyXJE\n\tvL0UQhuOi8pO5yoqshjMFQsscDkKW8e77EkkeQwvnjM3BfgOyxvlfcQR5WB7zkJxEhjo\n\tCSvbsH9Hai41Ri0p8J8d2KuGci4ocpvCXXnMhD/GFr+d45nqv4HJfpNNQrzUEJt3FjFv\n\tPMgOyIWFoRc9Sv14sW4WUPX2qhmTpUin6tcz155+Etx5BrSuqs6xaKtksiNkkY4nJKGn\n\tMFcGITylhOr8gpIMffB42SONuzMkPCXEwAWIIoBwBycGYArNXKogy5iCi9ynE1Wc81bD\n\tvGXw==",
        "X-Gm-Message-State": "ALoCoQl92MAH6a71XFbEZJ/2nNKLDmFziayBB0ZOLYZP3/vnczIU42VqEAwi5RKRQN2LsnmEcOQL",
        "X-Received": "by 10.180.75.199 with SMTP id e7mr105255625wiw.21.1417639752021; \n\tWed, 03 Dec 2014 12:49:12 -0800 (PST)",
        "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Wed,  3 Dec 2014 21:47:48 +0100",
        "Message-Id": "<1417639668-23500-3-git-send-email-thomas.monjalon@6wind.com>",
        "X-Mailer": "git-send-email 2.1.3",
        "In-Reply-To": "<1417639668-23500-1-git-send-email-thomas.monjalon@6wind.com>",
        "References": "<283531301.lWbIahXLyM@xps13>\n\t<1417639668-23500-1-git-send-email-thomas.monjalon@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 2/2] app/testpmd: fix endianness detection",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Use endianness detection factorized in EAL.\n\nThe comment about arpa/inet.h is not valid anymore since\ncommit d07180f211c08 (\"net: fix conflict with libc\").\n\nThe macro _htons could also be moved in rte_byteorder.h\nby providing some constant byte swapping.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n app/test-pmd/config.c   | 2 +-\n app/test-pmd/csumonly.c | 5 ++---\n app/test-pmd/testpmd.h  | 2 +-\n 3 files changed, 4 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex f0b770e..69a83c2 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -628,7 +628,7 @@ ring_dma_zone_lookup(const char *ring_name, uint8_t port_id, uint16_t q_id)\n union igb_ring_dword {\n \tuint64_t dword;\n \tstruct {\n-#ifdef RTE_ARCH_BIG_ENDIAN\n+#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN\n \t\tuint32_t lo;\n \t\tuint32_t hi;\n #else\ndiff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c\nindex 6f43761..da4bca4 100644\n--- a/app/test-pmd/csumonly.c\n+++ b/app/test-pmd/csumonly.c\n@@ -79,9 +79,8 @@\n #define IP_HDRLEN  0x05 /* default IP header length == five 32-bits words. */\n #define IP_VHL_DEF (IP_VERSION | IP_HDRLEN)\n \n-/* we cannot use htons() from arpa/inet.h due to name conflicts, and we\n- * cannot use rte_cpu_to_be_16() on a constant in a switch/case */\n-#if  __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__\n+/* We cannot use rte_cpu_to_be_16() on a constant in a switch/case */\n+#if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN\n #define _htons(x) ((uint16_t)((((x) & 0x00ffU) << 8) | (((x) & 0xff00U) >> 8)))\n #else\n #define _htons(x) (x)\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex c925910..f8b0740 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -567,7 +567,7 @@ int tx_queue_id_is_invalid(queueid_t txq_id);\n #define RTE_BE_TO_CPU_16(be_16_v)  rte_be_to_cpu_16((be_16_v))\n #define RTE_CPU_TO_BE_16(cpu_16_v) rte_cpu_to_be_16((cpu_16_v))\n #else\n-#ifdef __big_endian__\n+#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN\n #define RTE_BE_TO_CPU_16(be_16_v)  (be_16_v)\n #define RTE_CPU_TO_BE_16(cpu_16_v) (cpu_16_v)\n #else\n",
    "prefixes": [
        "dpdk-dev",
        "2/2"
    ]
}