Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1745/?format=api
{ "id": 1745, "url": "https://patches.dpdk.org/api/patches/1745/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1417625819-3024-1-git-send-email-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1417625819-3024-1-git-send-email-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1417625819-3024-1-git-send-email-bruce.richardson@intel.com", "date": "2014-12-03T16:56:59", "name": "[dpdk-dev] examples: fix symmetric_mp, set NIC rx_drop_en bit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fe40873c46720183662b61c49353bac379af3b78", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1417625819-3024-1-git-send-email-bruce.richardson@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1745/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1745/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2D9F47FCB;\n\tWed, 3 Dec 2014 19:50:09 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 344A87E75\n\tfor <dev@dpdk.org>; Wed, 3 Dec 2014 19:50:06 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP; 03 Dec 2014 09:36:43 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga003.jf.intel.com with ESMTP; 03 Dec 2014 09:33:24 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tsB3Gv0x9015654; Wed, 3 Dec 2014 16:57:00 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id sB3Gv0Rx003061;\n\tWed, 3 Dec 2014 16:57:00 GMT", "(from bricha3@localhost)\n\tby sivswdev01.ir.intel.com with id sB3Gux9B003057;\n\tWed, 3 Dec 2014 16:56:59 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,691,1406617200\"; d=\"scan'208\";a=\"493007365\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 3 Dec 2014 16:56:59 +0000", "Message-Id": "<1417625819-3024-1-git-send-email-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "Subject": "[dpdk-dev] [PATCH] examples: fix symmetric_mp,\n\tset NIC rx_drop_en bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The symmetric_mp example app is set up to allow two processes to\nshare a NIC port, with each pulling packets from one queue. In order\nto have the app continue working when one of the process dies, the\ndrop_en bit should be set in the NIC configuration. Without this bit\nset, the NIC will stall once any queue fills. With the bit set, once\na queue fills, all subsequent packets for that queue are discarded\nallowing other queues to continue operating as normal.\n\nThis setting was missed when converting to use standardised defaults\nin commit 81f7ecd9.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/multi_process/symmetric_mp/main.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c\nindex 01faae9..2fc2acf 100644\n--- a/examples/multi_process/symmetric_mp/main.c\n+++ b/examples/multi_process/symmetric_mp/main.c\n@@ -229,6 +229,7 @@ smp_port_init(uint8_t port, struct rte_mempool *mbuf_pool, uint16_t num_queues)\n \t\t\t}\n \t};\n \tconst uint16_t rx_rings = num_queues, tx_rings = num_queues;\n+\tstruct rte_eth_dev_info info;\n \tint retval;\n \tuint16_t q;\n \n@@ -241,6 +242,9 @@ smp_port_init(uint8_t port, struct rte_mempool *mbuf_pool, uint16_t num_queues)\n \tprintf(\"# Initialising port %u... \", (unsigned)port);\n \tfflush(stdout);\n \n+\trte_eth_dev_info_get(port, &info);\n+\tinfo.default_rxconf.rx_drop_en = 1;\n+\n \tretval = rte_eth_dev_configure(port, rx_rings, tx_rings, &port_conf);\n \tif (retval < 0)\n \t\treturn retval;\n@@ -248,7 +252,7 @@ smp_port_init(uint8_t port, struct rte_mempool *mbuf_pool, uint16_t num_queues)\n \tfor (q = 0; q < rx_rings; q ++) {\n \t\tretval = rte_eth_rx_queue_setup(port, q, RX_RING_SIZE,\n \t\t\t\trte_eth_dev_socket_id(port),\n-\t\t\t\tNULL,\n+\t\t\t\t&info.default_rxconf,\n \t\t\t\tmbuf_pool);\n \t\tif (retval < 0)\n \t\t\treturn retval;\n", "prefixes": [ "dpdk-dev" ] }