Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17424,
    "url": "https://patches.dpdk.org/api/patches/17424/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1480637533-37425-6-git-send-email-wenzhuo.lu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1480637533-37425-6-git-send-email-wenzhuo.lu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1480637533-37425-6-git-send-email-wenzhuo.lu@intel.com",
    "date": "2016-12-02T00:11:47",
    "name": "[dpdk-dev,05/31] net/i40e: set TX loopback from PF",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "f88ed017aa7bf73891d1fad68874a4b82379fe76",
    "submitter": {
        "id": 258,
        "url": "https://patches.dpdk.org/api/people/258/?format=api",
        "name": "Wenzhuo Lu",
        "email": "wenzhuo.lu@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1480637533-37425-6-git-send-email-wenzhuo.lu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/17424/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/17424/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id EB2DCFA3D;\n\tFri,  2 Dec 2016 09:21:41 +0100 (CET)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 0CD2C2C0A\n\tfor <dev@dpdk.org>; Fri,  2 Dec 2016 09:21:19 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga104.fm.intel.com with ESMTP; 02 Dec 2016 00:21:19 -0800",
            "from dpdk26.sh.intel.com ([10.239.128.228])\n\tby orsmga001.jf.intel.com with ESMTP; 02 Dec 2016 00:21:18 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.33,285,1477983600\"; d=\"scan'208\";\n\ta=\"1067004013\"",
        "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Wenzhuo Lu <wenzhuo.lu@intel.com>",
        "Date": "Thu,  1 Dec 2016 19:11:47 -0500",
        "Message-Id": "<1480637533-37425-6-git-send-email-wenzhuo.lu@intel.com>",
        "X-Mailer": "git-send-email 1.9.3",
        "In-Reply-To": "<1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com>",
        "References": "<1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 05/31] net/i40e: set TX loopback from PF",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Support enabling/disabling TX loopback from PF.\nUser can call the API on PF to enable/disable TX loopback\nfor all the PF and VFs.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c            | 219 ++++++++++++++++++++++++++++++\n drivers/net/i40e/rte_pmd_i40e.h           |  16 +++\n drivers/net/i40e/rte_pmd_i40e_version.map |   1 +\n 3 files changed, 236 insertions(+)",
    "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex ec863b9..9fe9672 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -9938,3 +9938,222 @@ static void i40e_set_default_mac_addr(struct rte_eth_dev *dev,\n \n \treturn ret;\n }\n+\n+static int\n+i40e_vsi_rm_mac_filter(struct i40e_vsi *vsi)\n+{\n+\tstruct i40e_mac_filter *f;\n+\tstruct i40e_macvlan_filter *mv_f;\n+\tint i, vlan_num;\n+\tenum rte_mac_filter_type filter_type;\n+\tint ret = I40E_SUCCESS;\n+\n+\t/* remove all the MACs */\n+\tTAILQ_FOREACH(f, &vsi->mac_list, next) {\n+\t\tvlan_num = vsi->vlan_num;\n+\t\tfilter_type = f->mac_info.filter_type;\n+\t\tif (filter_type == RTE_MACVLAN_PERFECT_MATCH ||\n+\t\t    filter_type == RTE_MACVLAN_HASH_MATCH) {\n+\t\t\tif (vlan_num == 0) {\n+\t\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\t    \"VLAN number shouldn't be 0\\n\");\n+\t\t\t\treturn I40E_ERR_PARAM;\n+\t\t\t}\n+\t\t} else if (filter_type == RTE_MAC_PERFECT_MATCH ||\n+\t\t\t   filter_type == RTE_MAC_HASH_MATCH)\n+\t\t\tvlan_num = 1;\n+\n+\t\tmv_f = rte_zmalloc(\"macvlan_data\", vlan_num * sizeof(*mv_f), 0);\n+\t\tif (!mv_f) {\n+\t\t\tPMD_DRV_LOG(ERR, \"failed to allocate memory\");\n+\t\t\treturn I40E_ERR_NO_MEMORY;\n+\t\t}\n+\n+\t\tfor (i = 0; i < vlan_num; i++) {\n+\t\t\tmv_f[i].filter_type = filter_type;\n+\t\t\t(void)rte_memcpy(&mv_f[i].macaddr,\n+\t\t\t\t\t &f->mac_info.mac_addr,\n+\t\t\t\t\t ETH_ADDR_LEN);\n+\t\t}\n+\t\tif (filter_type == RTE_MACVLAN_PERFECT_MATCH ||\n+\t\t    filter_type == RTE_MACVLAN_HASH_MATCH) {\n+\t\t\tret = i40e_find_all_vlan_for_mac(vsi, mv_f, vlan_num,\n+\t\t\t\t\t\t\t &f->mac_info.mac_addr);\n+\t\t\tif (ret != I40E_SUCCESS) {\n+\t\t\t\trte_free(mv_f);\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t}\n+\n+\t\tret = i40e_remove_macvlan_filters(vsi, mv_f, vlan_num);\n+\t\tif (ret != I40E_SUCCESS) {\n+\t\t\trte_free(mv_f);\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\trte_free(mv_f);\n+\t\tret = I40E_SUCCESS;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static int\n+i40e_vsi_restore_mac_filter(struct i40e_vsi *vsi)\n+{\n+\tstruct i40e_mac_filter *f;\n+\tstruct i40e_macvlan_filter *mv_f;\n+\tint i, vlan_num = 0;\n+\tint ret = I40E_SUCCESS;\n+\n+\t/* restore all the MACs */\n+\tTAILQ_FOREACH(f, &vsi->mac_list, next) {\n+\t\tif ((f->mac_info.filter_type == RTE_MACVLAN_PERFECT_MATCH) ||\n+\t\t    (f->mac_info.filter_type == RTE_MACVLAN_HASH_MATCH)) {\n+\t\t\t/**\n+\t\t\t * If vlan_num is 0, that's the first time to add mac,\n+\t\t\t * set mask for vlan_id 0.\n+\t\t\t */\n+\t\t\tif (vsi->vlan_num == 0) {\n+\t\t\t\ti40e_set_vlan_filter(vsi, 0, 1);\n+\t\t\t\tvsi->vlan_num = 1;\n+\t\t\t}\n+\t\t\tvlan_num = vsi->vlan_num;\n+\t\t} else if ((f->mac_info.filter_type == RTE_MAC_PERFECT_MATCH) ||\n+\t\t\t   (f->mac_info.filter_type == RTE_MAC_HASH_MATCH))\n+\t\t\tvlan_num = 1;\n+\n+\t\tmv_f = rte_zmalloc(\"macvlan_data\", vlan_num * sizeof(*mv_f), 0);\n+\t\tif (!mv_f) {\n+\t\t\tPMD_DRV_LOG(ERR, \"failed to allocate memory\");\n+\t\t\treturn I40E_ERR_NO_MEMORY;\n+\t\t}\n+\n+\t\tfor (i = 0; i < vlan_num; i++) {\n+\t\t\tmv_f[i].filter_type = f->mac_info.filter_type;\n+\t\t\t(void)rte_memcpy(&mv_f[i].macaddr,\n+\t\t\t\t\t &f->mac_info.mac_addr,\n+\t\t\t\t\t ETH_ADDR_LEN);\n+\t\t}\n+\n+\t\tif (f->mac_info.filter_type == RTE_MACVLAN_PERFECT_MATCH ||\n+\t\t    f->mac_info.filter_type == RTE_MACVLAN_HASH_MATCH) {\n+\t\t\tret = i40e_find_all_vlan_for_mac(vsi, mv_f, vlan_num,\n+\t\t\t\t\t\t\t &f->mac_info.mac_addr);\n+\t\t\tif (ret != I40E_SUCCESS) {\n+\t\t\t\trte_free(mv_f);\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t}\n+\n+\t\tret = i40e_add_macvlan_filters(vsi, mv_f, vlan_num);\n+\t\tif (ret != I40E_SUCCESS) {\n+\t\t\trte_free(mv_f);\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\trte_free(mv_f);\n+\t\tret = I40E_SUCCESS;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static int\n+i40e_vsi_set_tx_loopback(struct i40e_vsi *vsi, uint8_t on)\n+{\n+\tstruct i40e_vsi_context ctxt;\n+\tstruct i40e_hw *hw;\n+\tint ret;\n+\n+\thw = I40E_VSI_TO_HW(vsi);\n+\n+\t/* Use the FW API if FW >= v5.0 */\n+\tif (hw->aq.fw_maj_ver < 5) {\n+\t\tPMD_INIT_LOG(ERR, \"FW < v5.0, cannot enable loopback\");\n+\t\treturn -ENOSYS;\n+\t}\n+\n+\t/* Check if it has been already on or off */\n+\tif (vsi->info.valid_sections &\n+\t\trte_cpu_to_le_16(I40E_AQ_VSI_PROP_SWITCH_VALID)) {\n+\t\tif (on) {\n+\t\t\tif ((vsi->info.switch_id &\n+\t\t\t     I40E_AQ_VSI_SW_ID_FLAG_ALLOW_LB) ==\n+\t\t\t    I40E_AQ_VSI_SW_ID_FLAG_ALLOW_LB)\n+\t\t\t\treturn 0; /* already on */\n+\t\t} else {\n+\t\t\tif ((vsi->info.switch_id &\n+\t\t\t     I40E_AQ_VSI_SW_ID_FLAG_ALLOW_LB) == 0)\n+\t\t\t\treturn 0; /* already off */\n+\t\t}\n+\t}\n+\n+\t/* remove all the MACs first */\n+\tret = i40e_vsi_rm_mac_filter(vsi);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tvsi->info.valid_sections = cpu_to_le16(I40E_AQ_VSI_PROP_SWITCH_VALID);\n+\tif (on)\n+\t\tvsi->info.switch_id |= I40E_AQ_VSI_SW_ID_FLAG_ALLOW_LB;\n+\telse\n+\t\tvsi->info.switch_id &= ~I40E_AQ_VSI_SW_ID_FLAG_ALLOW_LB;\n+\n+\tmemset(&ctxt, 0, sizeof(ctxt));\n+\t(void)rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info));\n+\tctxt.seid = vsi->seid;\n+\n+\tret = i40e_aq_update_vsi_params(hw, &ctxt, NULL);\n+\tif (ret != I40E_SUCCESS) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to update VSI params\");\n+\t\treturn ret;\n+\t}\n+\n+\t/* add all the MACs back */\n+\tret = i40e_vsi_restore_mac_filter(vsi);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\treturn ret;\n+}\n+\n+int\n+rte_pmd_i40e_set_tx_loopback(uint8_t port, uint8_t on)\n+{\n+\tstruct rte_eth_dev *dev;\n+\tstruct i40e_pf *pf;\n+\tstruct i40e_pf_vf *vf;\n+\tstruct i40e_vsi *vsi;\n+\tuint16_t vf_id;\n+\tint ret;\n+\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\n+\n+\tdev = &rte_eth_devices[port];\n+\n+\tpf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);\n+\n+\t/* setup PF TX loopback */\n+\tvsi = pf->main_vsi;\n+\tret = i40e_vsi_set_tx_loopback(vsi, on);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\t/* setup TX loopback for all the VFs */\n+\tif (!pf->vfs) {\n+\t\tPMD_DRV_LOG(ERR, \"Invalid argument.\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (vf_id = 0; vf_id < pf->vf_num; vf_id++) {\n+\t\tvf = &pf->vfs[vf_id];\n+\t\tvsi = vf->vsi;\n+\n+\t\tret = i40e_vsi_set_tx_loopback(vsi, on);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n+\n+\treturn ret;\n+}\ndiff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h\nindex c8736c8..3c65be4 100644\n--- a/drivers/net/i40e/rte_pmd_i40e.h\n+++ b/drivers/net/i40e/rte_pmd_i40e.h\n@@ -114,4 +114,20 @@ int rte_pmd_i40e_set_vf_vlan_anti_spoof(uint8_t port,\n \t\t\t\t\tuint16_t vf_id,\n \t\t\t\t\tuint8_t on);\n \n+/**\n+ * Enable/Disable TX loopback on all the PF and VFs.\n+ *\n+ * @param port\n+ *    The port identifier of the Ethernet device.\n+ * @param on\n+ *    1 - Enable TX loopback.\n+ *    0 - Disable TX loopback.\n+ * @return\n+ *   - (0) if successful.\n+ *   - (-ENODEV) if *port* invalid.\n+ *   - (-EINVAL) if bad parameter.\n+ */\n+int rte_pmd_i40e_set_tx_loopback(uint8_t port,\n+\t\t\t\t uint8_t on);\n+\n #endif /* _PMD_I40E_H_ */\ndiff --git a/drivers/net/i40e/rte_pmd_i40e_version.map b/drivers/net/i40e/rte_pmd_i40e_version.map\nindex fff6cf9..3da04d3 100644\n--- a/drivers/net/i40e/rte_pmd_i40e_version.map\n+++ b/drivers/net/i40e/rte_pmd_i40e_version.map\n@@ -9,4 +9,5 @@ DPDK_17.02 {\n \trte_pmd_i40e_ping_vfs;\n \trte_pmd_i40e_set_vf_mac_anti_spoof;\n \trte_pmd_i40e_set_vf_vlan_anti_spoof;\n+\trte_pmd_i40e_set_tx_loopback;\n } DPDK_2.0;\n",
    "prefixes": [
        "dpdk-dev",
        "05/31"
    ]
}