Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17341/?format=api
https://patches.dpdk.org/api/patches/17341/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1480509129-27623-1-git-send-email-wang.yong19@zte.com.cn/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1480509129-27623-1-git-send-email-wang.yong19@zte.com.cn>", "list_archive_url": "https://inbox.dpdk.org/dev/1480509129-27623-1-git-send-email-wang.yong19@zte.com.cn", "date": "2016-11-30T12:32:09", "name": "[dpdk-dev] net/qede: fix resource leak", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2f6a83878adb61b0932e5712b09519770ef52281", "submitter": { "id": 609, "url": "https://patches.dpdk.org/api/people/609/?format=api", "name": "Yong Wang", "email": "wang.yong19@zte.com.cn" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1480509129-27623-1-git-send-email-wang.yong19@zte.com.cn/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/17341/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/17341/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 165215582;\n\tWed, 30 Nov 2016 12:32:07 +0100 (CET)", "from mx5.zte.com.cn (mx5.zte.com.cn [63.217.80.70])\n\tby dpdk.org (Postfix) with ESMTP id 849774A59\n\tfor <dev@dpdk.org>; Wed, 30 Nov 2016 12:32:03 +0100 (CET)", "from unknown (HELO mse01.zte.com.cn) (10.30.3.20)\n\tby localhost with (AES256-SHA encrypted) SMTP;\n\t30 Nov 2016 11:31:00 -0000", "from notes_smtp.zte.com.cn ([10.30.1.239])\n\tby mse01.zte.com.cn with ESMTP id uAUBVr2v021156;\n\tWed, 30 Nov 2016 19:31:53 +0800 (GMT-8)\n\t(envelope-from wang.yong19@zte.com.cn)", "from localhost.localdomain.localdomain ([10.43.166.165])\n\tby szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6)\n\twith ESMTP id 2016113019315877-156715 ;\n\tWed, 30 Nov 2016 19:31:58 +0800 " ], "X-MAILFROM": "<wang.yong19@zte.com.cn>", "X-RCPTTO": "<dev@dpdk.org>", "X-FROMIP": "10.30.3.20", "X-SEG-Scaned": "1", "X-Received": "unknown,10.30.3.20,20161130193100", "From": "Yong Wang <wang.yong19@zte.com.cn>", "To": "harish.patil@qlogic.com", "Cc": "dev@dpdk.org, Yong Wang <wang.yong19@zte.com.cn>", "Date": "Wed, 30 Nov 2016 07:32:09 -0500", "Message-Id": "<1480509129-27623-1-git-send-email-wang.yong19@zte.com.cn>", "X-Mailer": "git-send-email 1.8.3.1", "X-MIMETrack": "Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release\n\t8.5.3FP6|November 21, 2013) at 2016-11-30 19:31:59,\n\tSerialize by Router on notes_smtp/zte_ltd(Release 8.5.3FP6|November\n\t21, 2013) at 2016-11-30 19:31:34,\n\tSerialize complete at 2016-11-30 19:31:34", "X-MAIL": "mse01.zte.com.cn uAUBVr2v021156", "X-HQIP": "127.0.0.1", "Subject": "[dpdk-dev] [PATCH] net/qede: fix resource leak", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Current code does not close 'fd' on function exit, leaking resources.\n\nSigned-off-by: Yong Wang <wang.yong19@zte.com.cn>\n---\n drivers/net/qede/qede_main.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c\nindex ab22409..b666e1c 100644\n--- a/drivers/net/qede/qede_main.c\n+++ b/drivers/net/qede/qede_main.c\n@@ -137,6 +137,7 @@ static int qed_load_firmware_data(struct ecore_dev *edev)\n \n \tif (fstat(fd, &st) < 0) {\n \t\tDP_NOTICE(edev, false, \"Can't stat firmware file\\n\");\n+\t\tclose(fd);\n \t\treturn -1;\n \t}\n \n@@ -158,9 +159,11 @@ static int qed_load_firmware_data(struct ecore_dev *edev)\n \tif (edev->fw_len < 104) {\n \t\tDP_NOTICE(edev, false, \"Invalid fw size: %\" PRIu64 \"\\n\",\n \t\t\t edev->fw_len);\n+\t\tclose(fd);\n \t\treturn -EINVAL;\n \t}\n \n+\tclose(fd);\n \treturn 0;\n }\n #endif\n", "prefixes": [ "dpdk-dev" ] }{ "id": 17341, "url": "