Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17331/?format=api
{ "id": 17331, "url": "https://patches.dpdk.org/api/patches/17331/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1480436367-20749-42-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1480436367-20749-42-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1480436367-20749-42-git-send-email-arybchenko@solarflare.com", "date": "2016-11-29T16:19:13", "name": "[dpdk-dev,v2,41/55] net/sfc: minimum port control sufficient to receive traffic", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1fe79bdf09a0fdfae066097bb7a24e4aeb516b01", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1480436367-20749-42-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/17331/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/17331/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5A8AEFB22;\n\tTue, 29 Nov 2016 17:23:11 +0100 (CET)", "from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com\n\t[209.65.160.76]) by dpdk.org (Postfix) with ESMTP id BD82E5587\n\tfor <dev@dpdk.org>; Tue, 29 Nov 2016 17:21:02 +0100 (CET)", "from unknown [12.187.104.26] (EHLO nbfkord-smmo01.seg.att.com)\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id\n\teeaad385.2b3eaf88b940.83703.00-2487.174164.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tTue, 29 Nov 2016 16:21:02 +0000 (UTC)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\taeaad385.0.83424.00-2359.174064.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tTue, 29 Nov 2016 16:20:59 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Tue, 29 Nov 2016 08:20:26 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Tue, 29 Nov 2016 08:20:25 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuATGKO6T030023; Tue, 29 Nov 2016 16:20:24 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuATGKM1n021233; Tue, 29 Nov 2016 16:20:24 GMT" ], "X-MXL-Hash": [ "583daaee4a312a1c-258662ad123deaafa28753d2344ccf9dc2cdb491", "583daaeb3638e3e3-396ef18d6a84bff0c67a1ea33f6ef99ae636b23c" ], "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Tue, 29 Nov 2016 16:19:13 +0000", "Message-ID": "<1480436367-20749-42-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1480436367-20749-1-git-send-email-arybchenko@solarflare.com>", "References": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>\n\t<1480436367-20749-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=UoJlQrEB c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=L24OOQBejmoA:10 a=zRKbQ67AAAAA:8 a=QtmSuGzYx-VwVVu5U]", "[-UA:9 a=PA03WX8tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.2000000000; CM=0.500; S=0.200(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH v2 41/55] net/sfc: minimum port control\n\tsufficient to receive traffic", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Reviewed-by: Andy Moreton <amoreton@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/Makefile | 1 +\n drivers/net/sfc/sfc.c | 16 ++++++\n drivers/net/sfc/sfc.h | 12 ++++\n drivers/net/sfc/sfc_ethdev.c | 2 +\n drivers/net/sfc/sfc_port.c | 131 +++++++++++++++++++++++++++++++++++++++++++\n 5 files changed, 162 insertions(+)\n create mode 100644 drivers/net/sfc/sfc_port.c", "diff": "diff --git a/drivers/net/sfc/Makefile b/drivers/net/sfc/Makefile\nindex 3286fd8..04c1db1 100644\n--- a/drivers/net/sfc/Makefile\n+++ b/drivers/net/sfc/Makefile\n@@ -84,6 +84,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += sfc.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += sfc_mcdi.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += sfc_intr.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += sfc_ev.c\n+SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += sfc_port.c\n \n VPATH += $(SRCDIR)/base\n \ndiff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c\nindex 6870efe..01e0c94 100644\n--- a/drivers/net/sfc/sfc.c\n+++ b/drivers/net/sfc/sfc.c\n@@ -266,10 +266,17 @@ sfc_start(struct sfc_adapter *sa)\n \tif (rc != 0)\n \t\tgoto fail_ev_start;\n \n+\trc = sfc_port_start(sa);\n+\tif (rc != 0)\n+\t\tgoto fail_port_start;\n+\n \tsa->state = SFC_ADAPTER_STARTED;\n \tsfc_log_init(sa, \"done\");\n \treturn 0;\n \n+fail_port_start:\n+\tsfc_ev_stop(sa);\n+\n fail_ev_start:\n \tsfc_intr_stop(sa);\n \n@@ -305,6 +312,7 @@ sfc_stop(struct sfc_adapter *sa)\n \n \tsa->state = SFC_ADAPTER_STOPPING;\n \n+\tsfc_port_stop(sa);\n \tsfc_ev_stop(sa);\n \tsfc_intr_stop(sa);\n \tefx_nic_fini(sa->nic);\n@@ -337,10 +345,17 @@ sfc_configure(struct sfc_adapter *sa)\n \tif (rc != 0)\n \t\tgoto fail_ev_init;\n \n+\trc = sfc_port_init(sa);\n+\tif (rc != 0)\n+\t\tgoto fail_port_init;\n+\n \tsa->state = SFC_ADAPTER_CONFIGURED;\n \tsfc_log_init(sa, \"done\");\n \treturn 0;\n \n+fail_port_init:\n+\tsfc_ev_fini(sa);\n+\n fail_ev_init:\n \tsfc_intr_fini(sa);\n \n@@ -361,6 +376,7 @@ sfc_close(struct sfc_adapter *sa)\n \tSFC_ASSERT(sa->state == SFC_ADAPTER_CONFIGURED);\n \tsa->state = SFC_ADAPTER_CLOSING;\n \n+\tsfc_port_fini(sa);\n \tsfc_ev_fini(sa);\n \tsfc_intr_fini(sa);\n \ndiff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h\nindex 104aee4..042e504 100644\n--- a/drivers/net/sfc/sfc.h\n+++ b/drivers/net/sfc/sfc.h\n@@ -115,6 +115,12 @@ struct sfc_intr {\n \n struct sfc_evq_info;\n \n+struct sfc_port {\n+\tunsigned int\t\t\tflow_ctrl;\n+\tboolean_t\t\t\tflow_ctrl_autoneg;\n+\tsize_t\t\t\t\tpdu;\n+};\n+\n /* Adapter private data */\n struct sfc_adapter {\n \t/*\n@@ -136,6 +142,7 @@ struct sfc_adapter {\n \n \tstruct sfc_mcdi\t\t\tmcdi;\n \tstruct sfc_intr\t\t\tintr;\n+\tstruct sfc_port\t\t\tport;\n \n \tunsigned int\t\t\trxq_max;\n \tunsigned int\t\t\ttxq_max;\n@@ -204,6 +211,11 @@ void sfc_intr_fini(struct sfc_adapter *sa);\n int sfc_intr_start(struct sfc_adapter *sa);\n void sfc_intr_stop(struct sfc_adapter *sa);\n \n+int sfc_port_init(struct sfc_adapter *sa);\n+void sfc_port_fini(struct sfc_adapter *sa);\n+int sfc_port_start(struct sfc_adapter *sa);\n+void sfc_port_stop(struct sfc_adapter *sa);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 3d22654..316723e 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -47,6 +47,8 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tRTE_SET_USED(dev_info);\n \n \tsfc_log_init(sa, \"entry\");\n+\n+\tdev_info->max_rx_pktlen = EFX_MAC_PDU_MAX;\n }\n \n static int\ndiff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc_port.c\nnew file mode 100644\nindex 0000000..844363c\n--- /dev/null\n+++ b/drivers/net/sfc/sfc_port.c\n@@ -0,0 +1,131 @@\n+/*-\n+ * Copyright (c) 2016 Solarflare Communications Inc.\n+ * All rights reserved.\n+ *\n+ * This software was jointly developed between OKTET Labs (under contract\n+ * for Solarflare) and Solarflare Communications, Inc.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are met:\n+ *\n+ * 1. Redistributions of source code must retain the above copyright notice,\n+ * this list of conditions and the following disclaimer.\n+ * 2. Redistributions in binary form must reproduce the above copyright notice,\n+ * this list of conditions and the following disclaimer in the documentation\n+ * and/or other materials provided with the distribution.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,\n+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR\n+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR\n+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,\n+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,\n+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;\n+ * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,\n+ * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR\n+ * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,\n+ * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#include \"efx.h\"\n+\n+#include \"sfc.h\"\n+#include \"sfc_log.h\"\n+\n+\n+int\n+sfc_port_start(struct sfc_adapter *sa)\n+{\n+\tstruct sfc_port *port = &sa->port;\n+\tint rc;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tsfc_log_init(sa, \"init filters\");\n+\trc = efx_filter_init(sa->nic);\n+\tif (rc != 0)\n+\t\tgoto fail_filter_init;\n+\n+\tsfc_log_init(sa, \"init port\");\n+\trc = efx_port_init(sa->nic);\n+\tif (rc != 0)\n+\t\tgoto fail_port_init;\n+\n+\tsfc_log_init(sa, \"set MAC PDU %u\", (unsigned int)port->pdu);\n+\trc = efx_mac_pdu_set(sa->nic, port->pdu);\n+\tif (rc != 0)\n+\t\tgoto fail_mac_pdu_set;\n+\n+\tsfc_log_init(sa, \"set MAC address\");\n+\trc = efx_mac_addr_set(sa->nic,\n+\t\t\t sa->eth_dev->data->mac_addrs[0].addr_bytes);\n+\tif (rc != 0)\n+\t\tgoto fail_mac_addr_set;\n+\n+\tsfc_log_init(sa, \"set MAC filters\");\n+\trc = efx_mac_filter_set(sa->nic, B_TRUE, B_TRUE, B_TRUE, B_TRUE);\n+\tif (rc != 0)\n+\t\tgoto fail_mac_filter_set;\n+\n+\tsfc_log_init(sa, \"disable MAC drain\");\n+\trc = efx_mac_drain(sa->nic, B_FALSE);\n+\tif (rc != 0)\n+\t\tgoto fail_mac_drain;\n+\n+\tsfc_log_init(sa, \"done\");\n+\treturn 0;\n+\n+fail_mac_drain:\n+fail_mac_filter_set:\n+fail_mac_addr_set:\n+fail_mac_pdu_set:\n+\tefx_port_fini(sa->nic);\n+\n+fail_port_init:\n+\tefx_filter_fini(sa->nic);\n+\n+fail_filter_init:\n+\tsfc_log_init(sa, \"failed %d\", rc);\n+\treturn rc;\n+}\n+\n+void\n+sfc_port_stop(struct sfc_adapter *sa)\n+{\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tefx_mac_drain(sa->nic, B_TRUE);\n+\tefx_port_fini(sa->nic);\n+\tefx_filter_fini(sa->nic);\n+\n+\tsfc_log_init(sa, \"done\");\n+}\n+\n+int\n+sfc_port_init(struct sfc_adapter *sa)\n+{\n+\tconst struct rte_eth_dev_data *dev_data = sa->eth_dev->data;\n+\tstruct sfc_port *port = &sa->port;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\t/* Enable flow control by default */\n+\tport->flow_ctrl = EFX_FCNTL_RESPOND | EFX_FCNTL_GENERATE;\n+\tport->flow_ctrl_autoneg = B_TRUE;\n+\n+\tif (dev_data->dev_conf.rxmode.jumbo_frame)\n+\t\tport->pdu = dev_data->dev_conf.rxmode.max_rx_pkt_len;\n+\telse\n+\t\tport->pdu = EFX_MAC_PDU(dev_data->mtu);\n+\n+\tsfc_log_init(sa, \"done\");\n+\treturn 0;\n+}\n+\n+void\n+sfc_port_fini(struct sfc_adapter *sa)\n+{\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tsfc_log_init(sa, \"done\");\n+}\n", "prefixes": [ "dpdk-dev", "v2", "41/55" ] }