Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17254/?format=api
{ "id": 17254, "url": "https://patches.dpdk.org/api/patches/17254/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/9c689005d303b22bd4704d226aff4782a5f5a00b.1479995764.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9c689005d303b22bd4704d226aff4782a5f5a00b.1479995764.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9c689005d303b22bd4704d226aff4782a5f5a00b.1479995764.git.nelio.laranjeiro@6wind.com", "date": "2016-11-24T16:03:36", "name": "[dpdk-dev,7/7] net/mlx5: remove inefficient prefetching", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0f375f9795c20fd6dac53952140362d55283848b", "submitter": { "id": 243, "url": "https://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/9c689005d303b22bd4704d226aff4782a5f5a00b.1479995764.git.nelio.laranjeiro@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/17254/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/17254/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D68AC5A0A;\n\tThu, 24 Nov 2016 17:04:33 +0100 (CET)", "from mail-wj0-f173.google.com (mail-wj0-f173.google.com\n\t[209.85.210.173]) by dpdk.org (Postfix) with ESMTP id 929BA379B\n\tfor <dev@dpdk.org>; Thu, 24 Nov 2016 17:04:07 +0100 (CET)", "by mail-wj0-f173.google.com with SMTP id xy5so36870193wjc.0\n\tfor <dev@dpdk.org>; Thu, 24 Nov 2016 08:04:07 -0800 (PST)", "from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tvr9sm42495142wjc.35.2016.11.24.08.04.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 24 Nov 2016 08:04:06 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=Gr2GhApmUrEtEqkEXpkO77tUa/pMIr4kL+FCbW2BSc8=;\n\tb=Bqb3SLQzFG/OQ0+wQUn3ODRorlNxuEWUfV9zzn16EhgP/MWFg9AzfuCbUiFwmiXiGi\n\tPL5Ku/lr55ayfb0gLlqv99YFrx4Q+95UhHx5Izw+jN9MsZK07f427klciTy7s0hMU/4D\n\tImnbJSv8SnOZonTOevrrAsOfI7oYROxZZlcsQN4yfQllTlOtrajYmtWGMUaMHREfnpU8\n\tkGY1JIpPnE2Nj8G3opAKnmrdUWzH+uiIDIPBsQ3e7ZsJPoU9e1cN83i+kTlxwX8YpS4z\n\tiCO5li3WiU4EHscNT/t+CrokUuzf+w0beq1OPmQ/1SLjxjYt0JA87zppN5SZ+vboO95E\n\tO58A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=Gr2GhApmUrEtEqkEXpkO77tUa/pMIr4kL+FCbW2BSc8=;\n\tb=bxrqciMcGcPqQ8HZdXcqiiOCsftqRjE2DGXVwKEMITDIBfO2UY4Hh6XSfVafkrLESM\n\tVRIK0RipwHGZnjdMnhAplS9ZgMZpVffRwFYB+UIQ+6OKq8uR+ujGLOr2vhUuygL4d+qH\n\tv3uo+BBprWhkW9B00RTNfnqRea6CJZjJn0LhoplYatCi3JYcZkYN79yMalI87duqf7iK\n\tALztiPckBwggSkkPnYZVo//gMcJvo8NVzf+mi3ATRnoDn9kjekdKbuXlPwjVK2z8WBsc\n\tM9sreDf7Q2Lw4kJngGqugmWypMxqN2sDIw/0vW/AiHsepvOYI1z6/WAai896V4T8OyYO\n\tOzbA==", "X-Gm-Message-State": "AKaTC00XFselt90pzRbURY8oWynMoQUFSFdPAcKMOVCWcXROoJ1KvLMbXEs+SMkXuNHYyRQJ", "X-Received": "by 10.194.94.70 with SMTP id da6mr3337293wjb.180.1480003447280; \n\tThu, 24 Nov 2016 08:04:07 -0800 (PST)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org", "Cc": "Thomas Monjalon <thomas.monjalon@6wind.com>,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>", "Date": "Thu, 24 Nov 2016 17:03:36 +0100", "Message-Id": "<9c689005d303b22bd4704d226aff4782a5f5a00b.1479995764.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": [ "<cover.1479995764.git.nelio.laranjeiro@6wind.com>", "<cover.1479995764.git.nelio.laranjeiro@6wind.com>" ], "References": [ "<cover.1479995764.git.nelio.laranjeiro@6wind.com>", "<cover.1479995764.git.nelio.laranjeiro@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH 7/7] net/mlx5: remove inefficient prefetching", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Prefetching completion queue entries is inefficient because too few CPU\ncycles are spent before their use, which results into cache misses anyway.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nAcked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx5/mlx5_rxtx.c | 21 ---------------------\n 1 file changed, 21 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c\nindex 4b8c197..9f74fd4 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.c\n+++ b/drivers/net/mlx5/mlx5_rxtx.c\n@@ -348,23 +348,6 @@ mlx5_tx_dbrec(struct txq *txq)\n }\n \n /**\n- * Prefetch a CQE.\n- *\n- * @param txq\n- * Pointer to TX queue structure.\n- * @param cqe_ci\n- * CQE consumer index.\n- */\n-static inline void\n-tx_prefetch_cqe(struct txq *txq, uint16_t ci)\n-{\n-\tvolatile struct mlx5_cqe *cqe;\n-\n-\tcqe = &(*txq->cqes)[ci & ((1 << txq->cqe_n) - 1)];\n-\trte_prefetch0(cqe);\n-}\n-\n-/**\n * DPDK callback for TX.\n *\n * @param dpdk_txq\n@@ -395,8 +378,6 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \tif (unlikely(!pkts_n))\n \t\treturn 0;\n \t/* Prefetch first packet cacheline. */\n-\ttx_prefetch_cqe(txq, txq->cq_ci);\n-\ttx_prefetch_cqe(txq, txq->cq_ci + 1);\n \trte_prefetch0(*pkts);\n \t/* Start processing. */\n \ttxq_complete(txq);\n@@ -733,7 +714,6 @@ mlx5_tx_burst_mpw(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \tif (unlikely(!pkts_n))\n \t\treturn 0;\n \t/* Prefetch first packet cacheline. */\n-\ttx_prefetch_cqe(txq, txq->cq_ci);\n \trte_prefetch0(tx_mlx5_wqe(txq, txq->wqe_ci));\n \trte_prefetch0(tx_mlx5_wqe(txq, txq->wqe_ci + 1));\n \t/* Start processing. */\n@@ -938,7 +918,6 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts,\n \tif (unlikely(!pkts_n))\n \t\treturn 0;\n \t/* Prefetch first packet cacheline. */\n-\ttx_prefetch_cqe(txq, txq->cq_ci);\n \trte_prefetch0(tx_mlx5_wqe(txq, txq->wqe_ci));\n \trte_prefetch0(tx_mlx5_wqe(txq, txq->wqe_ci + 1));\n \t/* Start processing. */\n", "prefixes": [ "dpdk-dev", "7/7" ] }