Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1722/?format=api
{ "id": 1722, "url": "https://patches.dpdk.org/api/patches/1722/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/533710CFB86FA344BFBF2D6802E60286C9BECF@SHSMSX101.ccr.corp.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<533710CFB86FA344BFBF2D6802E60286C9BECF@SHSMSX101.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/533710CFB86FA344BFBF2D6802E60286C9BECF@SHSMSX101.ccr.corp.intel.com", "date": "2014-12-02T06:58:30", "name": "[dpdk-dev] i40e: bug fix of compile error", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "dc34155870ec96fe5560d1594b372645581bf901", "submitter": { "id": 101, "url": "https://patches.dpdk.org/api/people/101/?format=api", "name": "Michael Qiu", "email": "michael.qiu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/533710CFB86FA344BFBF2D6802E60286C9BECF@SHSMSX101.ccr.corp.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1722/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1722/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4CDB57F50;\n\tTue, 2 Dec 2014 08:04:35 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 3542D7EB0\n\tfor <dev@dpdk.org>; Tue, 2 Dec 2014 08:04:33 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 01 Dec 2014 23:01:42 -0800", "from pgsmsx102.gar.corp.intel.com ([10.221.44.80])\n\tby fmsmga001.fm.intel.com with ESMTP; 01 Dec 2014 23:01:39 -0800", "from shsmsx151.ccr.corp.intel.com (10.239.6.50) by\n\tPGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Tue, 2 Dec 2014 14:58:36 +0800", "from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by\n\tSHSMSX151.ccr.corp.intel.com ([169.254.3.86]) with mapi id\n\t14.03.0195.001; Tue, 2 Dec 2014 14:58:31 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,499,1413270000\"; d=\"scan'208\";a=\"631190892\"", "From": "\"Qiu, Michael\" <michael.qiu@intel.com>", "To": "\"Zhang, Helin\" <helin.zhang@intel.com>, Thomas Monjalon\n\t<thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH] i40e: bug fix of compile error", "Thread-Index": "AQHQDTlYIrgbkTVoBky9G/lz1blIYw==", "Date": "Tue, 2 Dec 2014 06:58:30 +0000", "Message-ID": "<533710CFB86FA344BFBF2D6802E60286C9BECF@SHSMSX101.ccr.corp.intel.com>", "References": "<1417419227-21465-1-git-send-email-helin.zhang@intel.com>\n\t<2036571.ijmOSAQnXA@xps13>\n\t<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7CD380@SHSMSX104.ccr.corp.intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "yes", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "multipart/mixed;\n\tboundary=\"_002_533710CFB86FA344BFBF2D6802E60286C9BECFSHSMSX101ccrcorpi_\"", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH] i40e: bug fix of compile error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On 12/2/2014 8:36 AM, Zhang, Helin wrote:\n>\n>> -----Original Message-----\n>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n>> Sent: Monday, December 1, 2014 7:13 PM\n>> To: Zhang, Helin\n>> Cc: dev@dpdk.org\n>> Subject: Re: [dpdk-dev] [PATCH] i40e: bug fix of compile error\n>>\n>> 2014-12-01 15:33, Helin Zhang:\n>>> The compile error will occur as below when set\n>> 'RTE_LIBRTE_I40E_16BYTE_RX_DESC=y'.\n>>> The changes is just to fix it.\n>>>\n>>> lib/librte_pmd_i40e/i40e_rxtx.c: In function i40e_rxd_build_fdir:\n>>> lib/librte_pmd_i40e/i40e_rxtx.c:431:28: error: volatile union\n>>> <anonymous> has no member named fd\n>>> lib/librte_pmd_i40e/i40e_rxtx.c:427:19: error: unused variable flexbl\n>>> [-Werror=unused-variable]\n>>> lib/librte_pmd_i40e/i40e_rxtx.c:427:11: error: unused variable flexbh\n>>> [-Werror=unused-variable]\n>> It would be nice to reference the commit which introduced the error and explain\n>> it a bit.\n>>\n>>> -\t\t\trte_le_to_cpu_32(rxdp->wb.qword3.hi_dword.flex_bytes_hi);\n>>> +\t\t\trte_le_to_cpu_32(\n>>> +\t\t\trxdp->wb.qword3.hi_dword.flex_bytes_hi);\n>> [...]\n>>> -\t\t\trte_le_to_cpu_32(rxdp->wb.qword3.lo_dword.flex_bytes_lo);\n>>> +\t\t\trte_le_to_cpu_32(\n>>> +\t\t\trxdp->wb.qword3.lo_dword.flex_bytes_lo);\n>> Why are you wrapping these lines (with wrong indentation)?\n>> It makes the fix confuse.\n> Sorry, it is a code style fix, as the length of the line should not be more than 80.\n> Do I need to split the patch or add more commit logs?\n\nI think this coding style fix is not good enough,\n\n\t\tmb->hash.fdir.hi = rte_le_to_cpu_32(rxdp->wb.qword3\n\t\t\t\t\t\t .hi_dword.fd_id);\n\nThis would be better :)\n\nSee the attached diff file, so sorry I indeed do not know how to add\ndiff file in the email(except git send-email), So I just attached it.\n\n>\n>> --\n>> Thomas\n> Regards,\n> Helin\n>", "diff": "diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c\nindex 2d2ef04..e0264fc 100644\n--- a/lib/librte_pmd_i40e/i40e_rxtx.c\n+++ b/lib/librte_pmd_i40e/i40e_rxtx.c\n@@ -427,8 +427,7 @@ i40e_rxd_build_fdir(volatile union i40e_rx_desc *rxdp, struct rte_mbuf *mb)\n \tuint16_t flexbh, flexbl;\n \n #ifdef RTE_LIBRTE_I40E_16BYTE_RX_DESC\n-\tmb->hash.fdir.hi =\n-\t\trte_le_to_cpu_32(rxdp->wb.qword0.hi_dword.fd);\n+\tmb->hash.fdir.hi = rte_le_to_cpu_32(rxdp->wb.qword0.hi_dword.fd);\n \tflags |= PKT_RX_FDIR_ID;\n #else\n \tflexbh = (rte_le_to_cpu_32(rxdp->wb.qword2.ext_status) >>\n@@ -440,17 +439,17 @@ i40e_rxd_build_fdir(volatile union i40e_rx_desc *rxdp, struct rte_mbuf *mb)\n \n \n \tif (flexbh == I40E_RX_DESC_EXT_STATUS_FLEXBH_FD_ID) {\n-\t\tmb->hash.fdir.hi =\n-\t\t\trte_le_to_cpu_32(rxdp->wb.qword3.hi_dword.fd_id);\n+\t\tmb->hash.fdir.hi = rte_le_to_cpu_32(rxdp->wb.qword3\n+\t\t\t\t\t\t .hi_dword.fd_id);\n \t\tflags |= PKT_RX_FDIR_ID;\n \t} else if (flexbh == I40E_RX_DESC_EXT_STATUS_FLEXBH_FLEX) {\n-\t\tmb->hash.fdir.hi =\n-\t\t\trte_le_to_cpu_32(rxdp->wb.qword3.hi_dword.flex_bytes_hi);\n+\t\tmb->hash.fdir.hi = rte_le_to_cpu_32(rxdp->wb.qword3\n+\t\t\t\t\t\t .hi_dword.flex_bytes_hi);\n \t\tflags |= PKT_RX_FDIR_FLX;\n \t}\n \tif (flexbl == I40E_RX_DESC_EXT_STATUS_FLEXBL_FLEX) {\n-\t\tmb->hash.fdir.lo =\n-\t\t\trte_le_to_cpu_32(rxdp->wb.qword3.lo_dword.flex_bytes_lo);\n+\t\tmb->hash.fdir.lo = rte_le_to_cpu_32(rxdp->wb.qword3\n+\t\t\t\t\t\t .lo_dword.flex_bytes_lo);\n \t\tflags |= PKT_RX_FDIR_FLX;\n \t}\n #endif\n", "prefixes": [ "dpdk-dev" ] }