Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17202,
    "url": "https://patches.dpdk.org/api/patches/17202/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1479931644-78960-3-git-send-email-benjamin.walker@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1479931644-78960-3-git-send-email-benjamin.walker@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1479931644-78960-3-git-send-email-benjamin.walker@intel.com",
    "date": "2016-11-23T20:07:20",
    "name": "[dpdk-dev,v2,3/7] pci: Pass rte_pci_addr to functions instead of separate args",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "cbfe288684449b872c83089136dba68fe2f67a91",
    "submitter": {
        "id": 487,
        "url": "https://patches.dpdk.org/api/people/487/?format=api",
        "name": "Walker, Benjamin",
        "email": "benjamin.walker@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1479931644-78960-3-git-send-email-benjamin.walker@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/17202/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/17202/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 81E7A567E;\n\tWed, 23 Nov 2016 21:07:51 +0100 (CET)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 6F5FC5591\n\tfor <dev@dpdk.org>; Wed, 23 Nov 2016 21:07:33 +0100 (CET)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 23 Nov 2016 12:07:31 -0800",
            "from bwalker-desk.ch.intel.com ([143.182.137.60])\n\tby orsmga002.jf.intel.com with ESMTP; 23 Nov 2016 12:07:31 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.31,539,1473145200\"; d=\"scan'208\";a=\"8589961\"",
        "From": "Ben Walker <benjamin.walker@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Ben Walker <benjamin.walker@intel.com>",
        "Date": "Wed, 23 Nov 2016 13:07:20 -0700",
        "Message-Id": "<1479931644-78960-3-git-send-email-benjamin.walker@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1479931644-78960-1-git-send-email-benjamin.walker@intel.com>",
        "References": "<1479929804-19614-1-git-send-email-benjamin.walker@intel.com>\n\t<1479931644-78960-1-git-send-email-benjamin.walker@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 3/7] pci: Pass rte_pci_addr to functions\n\tinstead of separate args",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Instead of passing domain, bus, devid, func, just pass\nan rte_pci_addr.\n\nSigned-off-by: Ben Walker <benjamin.walker@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_pci.c | 32 +++++++++++++-------------------\n 1 file changed, 13 insertions(+), 19 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c\nindex 876ba38..073af5f 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c\n@@ -267,8 +267,7 @@ pci_parse_sysfs_resource(const char *filename, struct rte_pci_device *dev)\n \n /* Scan one pci sysfs entry, and fill the devices list from it. */\n static int\n-pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,\n-\t     uint8_t devid, uint8_t function)\n+pci_scan_one(const char *dirname, const struct rte_pci_addr *addr)\n {\n \tchar filename[PATH_MAX];\n \tunsigned long tmp;\n@@ -281,10 +280,7 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,\n \t\treturn -1;\n \n \tmemset(dev, 0, sizeof(*dev));\n-\tdev->addr.domain = domain;\n-\tdev->addr.bus = bus;\n-\tdev->addr.devid = devid;\n-\tdev->addr.function = function;\n+\tdev->addr = *addr;\n \n \t/* get vendor id */\n \tsnprintf(filename, sizeof(filename), \"%s/vendor\", dirname);\n@@ -429,16 +425,14 @@ pci_update_device(const struct rte_pci_addr *addr)\n \t\t pci_get_sysfs_path(), addr->domain, addr->bus, addr->devid,\n \t\t addr->function);\n \n-\treturn pci_scan_one(filename, addr->domain, addr->bus, addr->devid,\n-\t\t\t\taddr->function);\n+\treturn pci_scan_one(filename, addr);\n }\n \n /*\n  * split up a pci address into its constituent parts.\n  */\n static int\n-parse_pci_addr_format(const char *buf, int bufsize, uint16_t *domain,\n-\t\tuint8_t *bus, uint8_t *devid, uint8_t *function)\n+parse_pci_addr_format(const char *buf, int bufsize, struct rte_pci_addr *addr)\n {\n \t/* first split on ':' */\n \tunion splitaddr {\n@@ -466,10 +460,10 @@ parse_pci_addr_format(const char *buf, int bufsize, uint16_t *domain,\n \n \t/* now convert to int values */\n \terrno = 0;\n-\t*domain = (uint16_t)strtoul(splitaddr.domain, NULL, 16);\n-\t*bus = (uint8_t)strtoul(splitaddr.bus, NULL, 16);\n-\t*devid = (uint8_t)strtoul(splitaddr.devid, NULL, 16);\n-\t*function = (uint8_t)strtoul(splitaddr.function, NULL, 10);\n+\taddr->domain = (uint16_t)strtoul(splitaddr.domain, NULL, 16);\n+\taddr->bus = (uint8_t)strtoul(splitaddr.bus, NULL, 16);\n+\taddr->devid = (uint8_t)strtoul(splitaddr.devid, NULL, 16);\n+\taddr->function = (uint8_t)strtoul(splitaddr.function, NULL, 10);\n \tif (errno != 0)\n \t\tgoto error;\n \n@@ -490,8 +484,7 @@ rte_eal_pci_scan(void)\n \tstruct dirent *e;\n \tDIR *dir;\n \tchar dirname[PATH_MAX];\n-\tuint16_t domain;\n-\tuint8_t bus, devid, function;\n+\tstruct rte_pci_addr addr;\n \n \tdir = opendir(pci_get_sysfs_path());\n \tif (dir == NULL) {\n@@ -500,20 +493,21 @@ rte_eal_pci_scan(void)\n \t\treturn -1;\n \t}\n \n+\n \twhile ((e = readdir(dir)) != NULL) {\n \t\tif (e->d_name[0] == '.')\n \t\t\tcontinue;\n \n-\t\tif (parse_pci_addr_format(e->d_name, sizeof(e->d_name), &domain,\n-\t\t\t\t&bus, &devid, &function) != 0)\n+\t\tif (parse_pci_addr_format(e->d_name, sizeof(e->d_name), &addr) != 0)\n \t\t\tcontinue;\n \n \t\tsnprintf(dirname, sizeof(dirname), \"%s/%s\",\n \t\t\t\tpci_get_sysfs_path(), e->d_name);\n-\t\tif (pci_scan_one(dirname, domain, bus, devid, function) < 0)\n+\t\tif (pci_scan_one(dirname, &addr) < 0)\n \t\t\tgoto error;\n \t}\n \tclosedir(dir);\n+\n \treturn 0;\n \n error:\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "3/7"
    ]
}