Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17201/?format=api
https://patches.dpdk.org/api/patches/17201/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1479931644-78960-1-git-send-email-benjamin.walker@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479931644-78960-1-git-send-email-benjamin.walker@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479931644-78960-1-git-send-email-benjamin.walker@intel.com", "date": "2016-11-23T20:07:18", "name": "[dpdk-dev,v2,1/7] pci: If a driver's probe function fails, unmap resources.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0833510884d335c0f18be98f4ed4f3ba698b2850", "submitter": { "id": 487, "url": "https://patches.dpdk.org/api/people/487/?format=api", "name": "Walker, Benjamin", "email": "benjamin.walker@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1479931644-78960-1-git-send-email-benjamin.walker@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/17201/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/17201/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6CF655598;\n\tWed, 23 Nov 2016 21:07:34 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id CF7805591\n\tfor <dev@dpdk.org>; Wed, 23 Nov 2016 21:07:32 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 23 Nov 2016 12:07:31 -0800", "from bwalker-desk.ch.intel.com ([143.182.137.60])\n\tby orsmga002.jf.intel.com with ESMTP; 23 Nov 2016 12:07:31 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,539,1473145200\"; d=\"scan'208\";a=\"8589952\"", "From": "Ben Walker <benjamin.walker@intel.com>", "To": "dev@dpdk.org", "Cc": "Ben Walker <benjamin.walker@intel.com>", "Date": "Wed, 23 Nov 2016 13:07:18 -0700", "Message-Id": "<1479931644-78960-1-git-send-email-benjamin.walker@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1479929804-19614-1-git-send-email-benjamin.walker@intel.com>", "References": "<1479929804-19614-1-git-send-email-benjamin.walker@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/7] pci: If a driver's probe function fails, \n\tunmap resources.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If resources were mapped prior to probe, unmap them\nif probe fails.\n\nThis does not handle the case where the kernel driver was\nforcibly unbound prior to probe.\n\nSigned-off-by: Ben Walker <benjamin.walker@intel.com>\n---\n lib/librte_eal/common/eal_common_pci.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c\nindex 6bff675..4f8c3a0 100644\n--- a/lib/librte_eal/common/eal_common_pci.c\n+++ b/lib/librte_eal/common/eal_common_pci.c\n@@ -215,8 +215,11 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d\n \n \t\t/* call the driver probe() function */\n \t\tret = dr->probe(dr, dev);\n-\t\tif (ret)\n+\t\tif (ret) {\n \t\t\tdev->driver = NULL;\n+\t\t\tif (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING)\n+\t\t\t\trte_eal_pci_unmap_device(dev);\n+\t\t}\n \n \t\treturn ret;\n \t}\n", "prefixes": [ "dpdk-dev", "v2", "1/7" ] }{ "id": 17201, "url": "