Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17169/?format=api
{ "id": 17169, "url": "https://patches.dpdk.org/api/patches/17169/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1479747322-5774-8-git-send-email-jblunck@infradead.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479747322-5774-8-git-send-email-jblunck@infradead.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1479747322-5774-8-git-send-email-jblunck@infradead.org", "date": "2016-11-21T16:55:22", "name": "[dpdk-dev,v2,8/8] ethdev: Decouple interrupt handling from PCI device", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "083b443d5c7c7f1f4b085cb336cc488e20a5fbfc", "submitter": { "id": 249, "url": "https://patches.dpdk.org/api/people/249/?format=api", "name": "Jan Blunck", "email": "jblunck@infradead.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1479747322-5774-8-git-send-email-jblunck@infradead.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/17169/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/17169/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E63F0D496;\n\tMon, 21 Nov 2016 17:57:35 +0100 (CET)", "from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68]) by dpdk.org (Postfix) with ESMTP id DB9D858C5\n\tfor <dev@dpdk.org>; Mon, 21 Nov 2016 17:57:12 +0100 (CET)", "by mail-wm0-f68.google.com with SMTP id m203so547725wma.3\n\tfor <dev@dpdk.org>; Mon, 21 Nov 2016 08:57:12 -0800 (PST)", "from weierstrass.local.net ([91.200.110.70])\n\tby smtp.gmail.com with ESMTPSA id\n\tv202sm20536051wmv.8.2016.11.21.08.57.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 21 Nov 2016 08:57:11 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=J28s3DYgTJqYXnpTZsnvKgIFzKeuL9DE5/zzGFTCrx8=;\n\tb=M7CPD8fQtsYieeqhoHLzgNZRQmZaa1VOfnQPwBmXQA1hVTIa5TugMxeKNTpbI1rr17\n\t1lrLVUoJVSUH0ZaZlDoHiIwoA9Wxky0yGFsq2VDTE7Pgf9bnugeW7ZdOHErmN4LEDGwv\n\tBJW09hPmiKdBYObVIG07trTxHuS5+qHbA/GQFOvHQUt4GupqI5fZqbd3qdEMIxHgzOrU\n\tT5y7b+ErIHvN68zHTIxuRLj5RCpXuLiwhLT7a1Ogt8oQOG8AHS1hHn/XAH009HmSpqh1\n\tjoC6CYtoFtS5uYC6W1DGVZmsOutJr//roPu1GnuSNuN+Ci2upfxJpukKW/uYqRajiCEU\n\t0xsw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=J28s3DYgTJqYXnpTZsnvKgIFzKeuL9DE5/zzGFTCrx8=;\n\tb=Hz1d+7tST1lXoR3ez1CYAwmYE+c0Wm5pu6/8Y4RvRf2tiQdjQBnzjxy0WWabtWgKFz\n\t8jWR0MJ7bj7eshbmRwwlAeMasv0FYwqXtOsy0Sazysv6Soxlm1AD3T0qvlZPYRie/+yu\n\tD38sCaJLeGUmm+YP51O3978R/lbyYRjuNCeIeYuaYl/kObu9bwUvSr7o+3DlM9C5G6l/\n\trNdm2BbcbZwBEKJmsztSsgIjQiN/U8XFlMsyS44fKV/wXlll2FfKT1nt6CYdvicxUzi4\n\tVDtDIoF0eB4+sA7BrsGa+RBTsgQ6XnXSiQZJtcX4me7k+f2lmu2Ob2OAaGjvjfq16ocZ\n\tXK1Q==", "X-Gm-Message-State": "AKaTC02W13OHPEe7Yph9pHHDaj1RJsLnZqci3CI+nxZfG1g4OK7y4DrZXocKJ0p/rZ/PiQ==", "X-Received": "by 10.28.12.80 with SMTP id 77mr16568519wmm.106.1479747432369;\n\tMon, 21 Nov 2016 08:57:12 -0800 (PST)", "From": "Jan Blunck <jblunck@infradead.org>", "To": "dev@dpdk.org", "Cc": "shreyansh.jain@nxp.com,\n\tdavid.marchand@6wind.com", "Date": "Mon, 21 Nov 2016 17:55:22 +0100", "Message-Id": "<1479747322-5774-8-git-send-email-jblunck@infradead.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1479747322-5774-1-git-send-email-jblunck@infradead.org>", "References": "<1479747322-5774-1-git-send-email-jblunck@infradead.org>", "Subject": "[dpdk-dev] [PATCH v2 8/8] ethdev: Decouple interrupt handling from\n\tPCI device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The struct rte_intr_handle is an abstraction layer for different types of\ninterrupt mechanisms. It is embedded in the low-level device (e.g. PCI).\nOn allocation of a struct rte_eth_dev a reference to the intr_handle\nshould be stored for devices supporting interrupts.\n\nSigned-off-by: Jan Blunck <jblunck@infradead.org>\n---\n lib/librte_ether/rte_ethdev.c | 18 ++++++++++++++++--\n lib/librte_ether/rte_ethdev.h | 1 +\n 2 files changed, 17 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 4288577..4ecea50 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -258,6 +258,7 @@ rte_eth_dev_pci_probe(struct rte_pci_driver *pci_drv,\n \t\t\trte_panic(\"Cannot allocate memzone for private port data\\n\");\n \t}\n \teth_dev->pci_dev = pci_dev;\n+\teth_dev->intr_handle = &pci_dev->intr_handle;\n \teth_dev->driver = eth_drv;\n \teth_dev->data->rx_mbuf_alloc_failed = 0;\n \n@@ -2543,7 +2544,13 @@ rte_eth_dev_rx_intr_ctl(uint8_t port_id, int epfd, int op, void *data)\n \tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);\n \n \tdev = &rte_eth_devices[port_id];\n-\tintr_handle = &dev->pci_dev->intr_handle;\n+\n+\tif (!dev->intr_handle) {\n+\t\tRTE_PMD_DEBUG_TRACE(\"RX Intr handle unset\\n\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tintr_handle = dev->intr_handle;\n \tif (!intr_handle->intr_vec) {\n \t\tRTE_PMD_DEBUG_TRACE(\"RX Intr vector unset\\n\");\n \t\treturn -EPERM;\n@@ -2603,7 +2610,12 @@ rte_eth_dev_rx_intr_ctl_q(uint8_t port_id, uint16_t queue_id,\n \t\treturn -EINVAL;\n \t}\n \n-\tintr_handle = &dev->pci_dev->intr_handle;\n+\tif (!dev->intr_handle) {\n+\t\tRTE_PMD_DEBUG_TRACE(\"RX Intr handle unset\\n\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tintr_handle = dev->intr_handle;\n \tif (!intr_handle->intr_vec) {\n \t\tRTE_PMD_DEBUG_TRACE(\"RX Intr vector unset\\n\");\n \t\treturn -EPERM;\n@@ -3205,6 +3217,8 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev, struct rte_pci_device *pci_de\n \t\treturn;\n \t}\n \n+\teth_dev->intr_handle = &pci_dev->intr_handle;\n+\n \teth_dev->data->dev_flags = 0;\n \tif (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC)\n \t\teth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex 3adbb2b..f1f656a 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -1629,6 +1629,7 @@ struct rte_eth_dev {\n \tconst struct eth_driver *driver;/**< Driver for this device */\n \tconst struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */\n \tstruct rte_pci_device *pci_dev; /**< PCI info. supplied by probing */\n+\tstruct rte_intr_handle *intr_handle; /**< Device interrupt handle */\n \t/** User application callbacks for NIC interrupts */\n \tstruct rte_eth_dev_cb_list link_intr_cbs;\n \t/**\n", "prefixes": [ "dpdk-dev", "v2", "8/8" ] }