Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17145/?format=api
{ "id": 17145, "url": "https://patches.dpdk.org/api/patches/17145/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1479740470-6723-41-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479740470-6723-41-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479740470-6723-41-git-send-email-arybchenko@solarflare.com", "date": "2016-11-21T15:00:54", "name": "[dpdk-dev,40/56] net/sfc: maintain management event queue", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3eda9e37de54eb8f0644f091b2683e2dfc3a3ba5", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1479740470-6723-41-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/17145/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/17145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id BEAFFD5DE;\n\tMon, 21 Nov 2016 16:03:34 +0100 (CET)", "from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com\n\t[209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 755D0376D\n\tfor <dev@dpdk.org>; Mon, 21 Nov 2016 16:01:41 +0100 (CET)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\t45c03385.0.1541303.00-2389.3424247.nbfkord-smmo02.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tMon, 21 Nov 2016 15:01:41 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Mon, 21 Nov 2016 07:01:22 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Mon, 21 Nov 2016 07:01:22 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1Kda007216 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:20 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1J3V006765 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:20 GMT" ], "X-MXL-Hash": "58330c553aaa0c5d-78b4c4c83107bb7e82ee3f86773c9b9b1a9b2a3f", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Mon, 21 Nov 2016 15:00:54 +0000", "Message-ID": "<1479740470-6723-41-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "References": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=UI/baXry c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=L24OOQBejmoA:10 a=zRKbQ67AAAAA:8 a=MObbI1fcmjedsUPTp]", "[rEA:9 a=PA03WX8tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.2000000000; CM=0.500; S=0.200(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH 40/56] net/sfc: maintain management event queue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The event queue is required for device level events (e.g. link status\nchange) and flush events.\nProvide thread-safe function to poll the event queue since it may be\nreally done from different contexts.\n\nReviewed-by: Andy Moreton <amoreton@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/efx/sfc.h | 1 +\n drivers/net/sfc/efx/sfc_ev.c | 50 ++++++++++++++++++++++++++++++++++++++++----\n drivers/net/sfc/efx/sfc_ev.h | 2 ++\n 3 files changed, 49 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/sfc/efx/sfc.h b/drivers/net/sfc/efx/sfc.h\nindex eb8c071..39f15b1 100644\n--- a/drivers/net/sfc/efx/sfc.h\n+++ b/drivers/net/sfc/efx/sfc.h\n@@ -144,6 +144,7 @@ struct sfc_adapter {\n \tstruct sfc_evq_info\t\t*evq_info;\n \n \tunsigned int\t\t\tmgmt_evq_index;\n+\trte_spinlock_t\t\t\tmgmt_evq_lock;\n };\n \n /*\ndiff --git a/drivers/net/sfc/efx/sfc_ev.c b/drivers/net/sfc/efx/sfc_ev.c\nindex aa04b34..1734b1e 100644\n--- a/drivers/net/sfc/efx/sfc_ev.c\n+++ b/drivers/net/sfc/efx/sfc_ev.c\n@@ -213,6 +213,19 @@ sfc_ev_qpoll(struct sfc_evq *evq)\n \t/* Poll-mode driver does not re-prime the event queue for interrupts */\n }\n \n+void\n+sfc_ev_mgmt_qpoll(struct sfc_adapter *sa)\n+{\n+\tif (rte_spinlock_trylock(&sa->mgmt_evq_lock)) {\n+\t\tstruct sfc_evq *mgmt_evq = sa->evq_info[sa->mgmt_evq_index].evq;\n+\n+\t\tif (mgmt_evq->init_state == SFC_EVQ_STARTED)\n+\t\t\tsfc_ev_qpoll(mgmt_evq);\n+\n+\t\trte_spinlock_unlock(&sa->mgmt_evq_lock);\n+\t}\n+}\n+\n int\n sfc_ev_qprime(struct sfc_evq *evq)\n {\n@@ -324,13 +337,26 @@ sfc_ev_start(struct sfc_adapter *sa)\n \tif (rc != 0)\n \t\tgoto fail_ev_init;\n \n+\t/* Start management EVQ used for global events */\n+\trte_spinlock_lock(&sa->mgmt_evq_lock);\n+\n+\trc = sfc_ev_qstart(sa, sa->mgmt_evq_index);\n+\tif (rc != 0)\n+\t\tgoto fail_mgmt_evq_start;\n+\n+\trte_spinlock_unlock(&sa->mgmt_evq_lock);\n+\n \t/*\n-\t * Rx/Tx event queues are started/stopped when corresponding queue\n-\t * is started/stopped.\n+\t * Rx/Tx event queues are started/stopped when corresponding\n+\t * Rx/Tx queue is started/stopped.\n \t */\n \n \treturn 0;\n \n+fail_mgmt_evq_start:\n+\trte_spinlock_unlock(&sa->mgmt_evq_lock);\n+\tefx_ev_fini(sa->nic);\n+\n fail_ev_init:\n \tsfc_log_init(sa, \"failed %d\", rc);\n \treturn rc;\n@@ -345,8 +371,17 @@ sfc_ev_stop(struct sfc_adapter *sa)\n \n \t/* Make sure that all event queues are stopped */\n \tsw_index = sa->evq_count;\n-\twhile (--sw_index >= 0)\n-\t\tsfc_ev_qstop(sa, sw_index);\n+\twhile (--sw_index >= 0) {\n+\t\tif (sw_index == sa->mgmt_evq_index) {\n+\t\t\t/* Locks are required for the management EVQ */\n+\t\t\trte_spinlock_lock(&sa->mgmt_evq_lock);\n+\t\t\tsfc_ev_qstop(sa, sa->mgmt_evq_index);\n+\t\t\trte_spinlock_unlock(&sa->mgmt_evq_lock);\n+\t\t} else {\n+\t\t\tsfc_ev_qstop(sa, sw_index);\n+\t\t}\n+\t}\n+\n \n \tefx_ev_fini(sa->nic);\n }\n@@ -444,6 +479,7 @@ sfc_ev_init(struct sfc_adapter *sa)\n \n \tsa->evq_count = sfc_ev_qcount(sa);\n \tsa->mgmt_evq_index = 0;\n+\trte_spinlock_init(&sa->mgmt_evq_lock);\n \n \t/* Allocate EVQ info array */\n \trc = ENOMEM;\n@@ -459,6 +495,11 @@ sfc_ev_init(struct sfc_adapter *sa)\n \t\t\tgoto fail_ev_qinit_info;\n \t}\n \n+\trc = sfc_ev_qinit(sa, sa->mgmt_evq_index, SFC_MGMT_EVQ_ENTRIES,\n+\t\t\t sa->socket_id);\n+\tif (rc != 0)\n+\t\tgoto fail_mgmt_evq_init;\n+\n \t/*\n \t * Rx/Tx event queues are created/destroyed when corresponding\n \t * Rx/Tx queue is created/destroyed.\n@@ -466,6 +507,7 @@ sfc_ev_init(struct sfc_adapter *sa)\n \n \treturn 0;\n \n+fail_mgmt_evq_init:\n fail_ev_qinit_info:\n \twhile (sw_index-- > 0)\n \t\tsfc_ev_qfini_info(sa, sw_index);\ndiff --git a/drivers/net/sfc/efx/sfc_ev.h b/drivers/net/sfc/efx/sfc_ev.h\nindex 140a436..f7bcf01 100644\n--- a/drivers/net/sfc/efx/sfc_ev.h\n+++ b/drivers/net/sfc/efx/sfc_ev.h\n@@ -132,6 +132,8 @@ void sfc_ev_qstop(struct sfc_adapter *sa, unsigned int sw_index);\n int sfc_ev_qprime(struct sfc_evq *evq);\n void sfc_ev_qpoll(struct sfc_evq *evq);\n \n+void sfc_ev_mgmt_qpoll(struct sfc_adapter *sa);\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "dpdk-dev", "40/56" ] }