Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17108,
    "url": "https://patches.dpdk.org/api/patches/17108/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1479740470-6723-16-git-send-email-arybchenko@solarflare.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1479740470-6723-16-git-send-email-arybchenko@solarflare.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1479740470-6723-16-git-send-email-arybchenko@solarflare.com",
    "date": "2016-11-21T15:00:29",
    "name": "[dpdk-dev,15/56] net/sfc: import libefx PHY flags control support",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "8a06b9674f8d519d1e0d76ac8c322659a08c6a9f",
    "submitter": {
        "id": 607,
        "url": "https://patches.dpdk.org/api/people/607/?format=api",
        "name": "Andrew Rybchenko",
        "email": "arybchenko@solarflare.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1479740470-6723-16-git-send-email-arybchenko@solarflare.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/17108/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/17108/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 69769567E;\n\tMon, 21 Nov 2016 16:02:26 +0100 (CET)",
            "from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com\n\t[209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 32AD8376D\n\tfor <dev@dpdk.org>; Mon, 21 Nov 2016 16:01:28 +0100 (CET)",
            "from unknown [12.187.104.26] (EHLO webmail.solarflare.com)\n\tby nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) over TLS secured\n\tchannel with ESMTP id\n\t74c03385.0.1541296.00-2367.3424172.nbfkord-smmo02.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tMon, 21 Nov 2016 15:01:28 +0000 (UTC)",
            "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Mon, 21 Nov 2016 07:01:21 -0800",
            "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Mon, 21 Nov 2016 07:01:21 -0800",
            "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1Kgr007143 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:20 GMT",
            "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1J36006765 for <dev@dpdk.org>; Mon, 21 Nov 2016 15:01:20 GMT"
        ],
        "X-MXL-Hash": "58330c481f693ba4-922b02c14fe5515ea22d4d29135d0d352d158144",
        "From": "Andrew Rybchenko <arybchenko@solarflare.com>",
        "To": "<dev@dpdk.org>",
        "Date": "Mon, 21 Nov 2016 15:00:29 +0000",
        "Message-ID": "<1479740470-6723-16-git-send-email-arybchenko@solarflare.com>",
        "X-Mailer": "git-send-email 1.8.2.3",
        "In-Reply-To": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>",
        "References": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-AnalysisOut": [
            "[v=2.1 cv=UI/baXry c=0 sm=1 tr=0 p=UPhfUc_oUKe9iv7q:21 a=8B]",
            "[lWFWvVlq5taO8ncb8nKg==:17 a=L24OOQBejmoA:10 a=zRKbQ67AAAAA]",
            "[:8 a=LC9S3fWswQ2SxE5cBckA:9]"
        ],
        "X-Spam": "[F=0.9575116125; CM=0.950; S=0.542(2015072901)]",
        "X-MAIL-FROM": "<arybchenko@solarflare.com>",
        "X-SOURCE-IP": "[12.187.104.26]",
        "Subject": "[dpdk-dev] [PATCH 15/56] net/sfc: import libefx PHY flags control\n\tsupport",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "EFSYS_OPT_PHY_FLAGS should be enabled to use it.\n\nFrom Solarflare Communications Inc.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/efx/base/ef10_phy.c  | 4 ++++\n drivers/net/sfc/efx/base/efx.h       | 3 +++\n drivers/net/sfc/efx/base/efx_check.h | 7 +++++++\n drivers/net/sfc/efx/base/efx_impl.h  | 3 +++\n drivers/net/sfc/efx/base/efx_mcdi.c  | 3 +++\n drivers/net/sfc/efx/base/siena_phy.c | 4 ++++\n 6 files changed, 24 insertions(+)",
    "diff": "diff --git a/drivers/net/sfc/efx/base/ef10_phy.c b/drivers/net/sfc/efx/base/ef10_phy.c\nindex 9e1b9c2..c7e584b 100644\n--- a/drivers/net/sfc/efx/base/ef10_phy.c\n+++ b/drivers/net/sfc/efx/base/ef10_phy.c\n@@ -293,7 +293,11 @@ ef10_phy_reconfigure(\n \tspeed = 0;\n \tMCDI_IN_SET_DWORD(req, SET_LINK_IN_LOOPBACK_SPEED, speed);\n \n+#if EFSYS_OPT_PHY_FLAGS\n+\tMCDI_IN_SET_DWORD(req, SET_LINK_IN_FLAGS, epp->ep_phy_flags);\n+#else\n \tMCDI_IN_SET_DWORD(req, SET_LINK_IN_FLAGS, 0);\n+#endif\t/* EFSYS_OPT_PHY_FLAGS */\n \n \tefx_mcdi_execute(enp, &req);\n \ndiff --git a/drivers/net/sfc/efx/base/efx.h b/drivers/net/sfc/efx/base/efx.h\nindex c2587ca..6dd5a8e 100644\n--- a/drivers/net/sfc/efx/base/efx.h\n+++ b/drivers/net/sfc/efx/base/efx.h\n@@ -668,6 +668,9 @@ typedef struct efx_nic_cfg_s {\n \tuint32_t\t\tenc_rx_prefix_size;\n \tuint32_t\t\tenc_rx_buf_align_start;\n \tuint32_t\t\tenc_rx_buf_align_end;\n+#if EFSYS_OPT_PHY_FLAGS\n+\tuint32_t\t\tenc_phy_flags_mask;\n+#endif\t/* EFSYS_OPT_PHY_FLAGS */\n #if EFSYS_OPT_MCDI\n \tuint8_t\t\t\tenc_mcdi_mdio_channel;\n #endif\t/* EFSYS_OPT_MCDI */\ndiff --git a/drivers/net/sfc/efx/base/efx_check.h b/drivers/net/sfc/efx/base/efx_check.h\nindex 6f0c216..68c01f3 100644\n--- a/drivers/net/sfc/efx/base/efx_check.h\n+++ b/drivers/net/sfc/efx/base/efx_check.h\n@@ -166,6 +166,13 @@\n # error \"PHY_BIST is obsolete (replaced by BIST).\"\n #endif\n \n+#if EFSYS_OPT_PHY_FLAGS\n+/* Support PHY flags */\n+# if !EFSYS_OPT_SIENA\n+#  error \"PHY_FLAGS requires SIENA\"\n+# endif\n+#endif /* EFSYS_OPT_PHY_FLAGS */\n+\n #ifdef EFSYS_OPT_PHY_NULL\n # error \"PHY_NULL is obsolete and is not supported.\"\n #endif\ndiff --git a/drivers/net/sfc/efx/base/efx_impl.h b/drivers/net/sfc/efx/base/efx_impl.h\nindex f776656..489fcbc 100644\n--- a/drivers/net/sfc/efx/base/efx_impl.h\n+++ b/drivers/net/sfc/efx/base/efx_impl.h\n@@ -237,6 +237,9 @@ typedef struct efx_port_s {\n \tuint8_t\t\t\tep_mulcst_addr_list[EFX_MAC_ADDR_LEN *\n \t\t\t\t\t\t    EFX_MAC_MULTICAST_LIST_MAX];\n \tuint32_t\t\tep_mulcst_addr_count;\n+#if EFSYS_OPT_PHY_FLAGS\n+\tuint32_t\t\tep_phy_flags;\n+#endif\t/* EFSYS_OPT_PHY_FLAGS */\n \tefx_phy_media_type_t\tep_fixed_port_type;\n \tefx_phy_media_type_t\tep_module_type;\n \tuint32_t\t\tep_adv_cap_mask;\ndiff --git a/drivers/net/sfc/efx/base/efx_mcdi.c b/drivers/net/sfc/efx/base/efx_mcdi.c\nindex 40cd456..b070887 100644\n--- a/drivers/net/sfc/efx/base/efx_mcdi.c\n+++ b/drivers/net/sfc/efx/base/efx_mcdi.c\n@@ -1425,6 +1425,9 @@ efx_mcdi_get_phy_cfg(\n \n \tepp->ep_phy_cap_mask =\n \t\tMCDI_OUT_DWORD(req, GET_PHY_CFG_OUT_SUPPORTED_CAP);\n+#if EFSYS_OPT_PHY_FLAGS\n+\tencp->enc_phy_flags_mask = MCDI_OUT_DWORD(req, GET_PHY_CFG_OUT_FLAGS);\n+#endif\t/* EFSYS_OPT_PHY_FLAGS */\n \n \tencp->enc_port = (uint8_t)MCDI_OUT_DWORD(req, GET_PHY_CFG_OUT_PRT);\n \ndiff --git a/drivers/net/sfc/efx/base/siena_phy.c b/drivers/net/sfc/efx/base/siena_phy.c\nindex d7e7d77..6451298 100644\n--- a/drivers/net/sfc/efx/base/siena_phy.c\n+++ b/drivers/net/sfc/efx/base/siena_phy.c\n@@ -277,7 +277,11 @@ siena_phy_reconfigure(\n \tspeed = 0;\n \tMCDI_IN_SET_DWORD(req, SET_LINK_IN_LOOPBACK_SPEED, speed);\n \n+#if EFSYS_OPT_PHY_FLAGS\n+\tMCDI_IN_SET_DWORD(req, SET_LINK_IN_FLAGS, epp->ep_phy_flags);\n+#else\n \tMCDI_IN_SET_DWORD(req, SET_LINK_IN_FLAGS, 0);\n+#endif\t/* EFSYS_OPT_PHY_FLAGS */\n \n \tefx_mcdi_execute(enp, &req);\n \n",
    "prefixes": [
        "dpdk-dev",
        "15/56"
    ]
}