Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17092/?format=api
{ "id": 17092, "url": "https://patches.dpdk.org/api/patches/17092/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1479485218-11931-1-git-send-email-alejandro.lucero@netronome.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479485218-11931-1-git-send-email-alejandro.lucero@netronome.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479485218-11931-1-git-send-email-alejandro.lucero@netronome.com", "date": "2016-11-18T16:06:58", "name": "[dpdk-dev,v2] nfp: report link speed using hardware info", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "a36619b1a5e83af22a636ae74c5009150a873f75", "submitter": { "id": 270, "url": "https://patches.dpdk.org/api/people/270/?format=api", "name": "Alejandro Lucero", "email": "alejandro.lucero@netronome.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1479485218-11931-1-git-send-email-alejandro.lucero@netronome.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/17092/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/17092/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3F35654AF;\n\tFri, 18 Nov 2016 17:07:02 +0100 (CET)", "from netronome.com (host-79-78-33-110.static.as9105.net\n\t[79.78.33.110]) by dpdk.org (Postfix) with ESMTP id B99F82C40\n\tfor <dev@dpdk.org>; Fri, 18 Nov 2016 17:07:00 +0100 (CET)", "from netronome.com (localhost [127.0.0.1])\n\tby netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id\n\tuAIG6wOr011970 for <dev@dpdk.org>; Fri, 18 Nov 2016 16:06:58 GMT", "(from alucero@localhost)\n\tby netronome.com (8.14.4/8.14.4/Submit) id uAIG6wWH011969\n\tfor dev@dpdk.org; Fri, 18 Nov 2016 16:06:58 GMT" ], "From": "Alejandro Lucero <alejandro.lucero@netronome.com>", "To": "dev@dpdk.org", "Date": "Fri, 18 Nov 2016 16:06:58 +0000", "Message-Id": "<1479485218-11931-1-git-send-email-alejandro.lucero@netronome.com>", "X-Mailer": "git-send-email 1.9.1", "Subject": "[dpdk-dev] [PATCH v2] nfp: report link speed using hardware info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previous reported speed was hardcoded.\n\nSigned-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>\n---\n drivers/net/nfp/nfp_net.c | 28 ++++++++++++++++++++++++++--\n drivers/net/nfp/nfp_net_ctrl.h | 13 +++++++++++++\n 2 files changed, 39 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c\nindex c6b1587..24f3164 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_net.c\n@@ -816,6 +816,17 @@ static void nfp_net_read_mac(struct nfp_net_hw *hw)\n \tstruct rte_eth_link link, old;\n \tuint32_t nn_link_status;\n \n+\tstatic const uint32_t ls_to_ethtool[] = {\n+\t\t[NFP_NET_CFG_STS_LINK_RATE_UNSUPPORTED] = ETH_SPEED_NUM_NONE,\n+\t\t[NFP_NET_CFG_STS_LINK_RATE_UNKNOWN] = ETH_SPEED_NUM_NONE,\n+\t\t[NFP_NET_CFG_STS_LINK_RATE_1G] = ETH_SPEED_NUM_1G,\n+\t\t[NFP_NET_CFG_STS_LINK_RATE_10G] = ETH_SPEED_NUM_10G,\n+\t\t[NFP_NET_CFG_STS_LINK_RATE_25G] = ETH_SPEED_NUM_25G,\n+\t\t[NFP_NET_CFG_STS_LINK_RATE_40G] = ETH_SPEED_NUM_40G,\n+\t\t[NFP_NET_CFG_STS_LINK_RATE_50G] = ETH_SPEED_NUM_50G,\n+\t\t[NFP_NET_CFG_STS_LINK_RATE_100G] = ETH_SPEED_NUM_100G,\n+\t};\n+\n \tPMD_DRV_LOG(DEBUG, \"Link update\\n\");\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n@@ -831,8 +842,21 @@ static void nfp_net_read_mac(struct nfp_net_hw *hw)\n \t\tlink.link_status = ETH_LINK_UP;\n \n \tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n-\t/* Other cards can limit the tx and rx rate per VF */\n-\tlink.link_speed = ETH_SPEED_NUM_40G;\n+\n+\tnn_link_status = (nn_link_status >> NFP_NET_CFG_STS_LINK_RATE_SHIFT) &\n+\t\t\t NFP_NET_CFG_STS_LINK_RATE_MASK;\n+\n+\tif ((NFD_CFG_MAJOR_VERSION_of(hw->ver) < 4) ||\n+\t ((NFD_CFG_MINOR_VERSION_of(hw->ver) == 4) &&\n+\t (NFD_CFG_MINOR_VERSION_of(hw->ver) == 0)))\n+\t\tlink.link_speed = ETH_SPEED_NUM_40G;\n+\telse {\n+\t\tif (nn_link_status == NFP_NET_CFG_STS_LINK_RATE_UNKNOWN ||\n+\t\t nn_link_status >= RTE_DIM(ls_to_ethtool))\n+\t\t\tlink.link_speed = ETH_SPEED_NUM_NONE;\n+\t\telse\n+\t\t\tlink.link_speed = ls_to_ethtool[nn_link_status];\n+\t}\n \n \tif (old.link_status != link.link_status) {\n \t\tnfp_net_dev_atomic_write_link_status(dev, &link);\ndiff --git a/drivers/net/nfp/nfp_net_ctrl.h b/drivers/net/nfp/nfp_net_ctrl.h\nindex fce8251..f9aaba3 100644\n--- a/drivers/net/nfp/nfp_net_ctrl.h\n+++ b/drivers/net/nfp/nfp_net_ctrl.h\n@@ -157,6 +157,19 @@\n #define NFP_NET_CFG_VERSION_MINOR(x) (((x) & 0xff) << 0)\n #define NFP_NET_CFG_STS 0x0034\n #define NFP_NET_CFG_STS_LINK (0x1 << 0) /* Link up or down */\n+/* Link rate */\n+#define NFP_NET_CFG_STS_LINK_RATE_SHIFT 1\n+#define NFP_NET_CFG_STS_LINK_RATE_MASK 0xF\n+#define NFP_NET_CFG_STS_LINK_RATE \\\n+\t (NFP_NET_CFG_STS_LINK_RATE_MASK << NFP_NET_CFG_STS_LINK_RATE_SHIFT)\n+#define NFP_NET_CFG_STS_LINK_RATE_UNSUPPORTED 0\n+#define NFP_NET_CFG_STS_LINK_RATE_UNKNOWN 1\n+#define NFP_NET_CFG_STS_LINK_RATE_1G 2\n+#define NFP_NET_CFG_STS_LINK_RATE_10G 3\n+#define NFP_NET_CFG_STS_LINK_RATE_25G 4\n+#define NFP_NET_CFG_STS_LINK_RATE_40G 5\n+#define NFP_NET_CFG_STS_LINK_RATE_50G 6\n+#define NFP_NET_CFG_STS_LINK_RATE_100G 7\n #define NFP_NET_CFG_CAP 0x0038\n #define NFP_NET_CFG_MAX_TXRINGS 0x003c\n #define NFP_NET_CFG_MAX_RXRINGS 0x0040\n", "prefixes": [ "dpdk-dev", "v2" ] }