Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17089,
    "url": "https://patches.dpdk.org/api/patches/17089/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1479462013-11562-1-git-send-email-qiming.yang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1479462013-11562-1-git-send-email-qiming.yang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1479462013-11562-1-git-send-email-qiming.yang@intel.com",
    "date": "2016-11-18T09:40:13",
    "name": "[dpdk-dev] examples/ethtool: fix bug in drvinfo callback",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e665ac7013f530e8736055f6854fd7c4e83d4de7",
    "submitter": {
        "id": 522,
        "url": "https://patches.dpdk.org/api/people/522/?format=api",
        "name": "Qiming Yang",
        "email": "qiming.yang@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1479462013-11562-1-git-send-email-qiming.yang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/17089/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/17089/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 986F35594;\n\tFri, 18 Nov 2016 10:44:04 +0100 (CET)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 3D0FC558B\n\tfor <dev@dpdk.org>; Fri, 18 Nov 2016 10:44:01 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 18 Nov 2016 01:44:00 -0800",
            "from dpdk7.bj.intel.com ([172.16.182.76])\n\tby orsmga001.jf.intel.com with ESMTP; 18 Nov 2016 01:43:59 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.31,656,1473145200\"; d=\"scan'208\";\n\ta=\"1061062244\"",
        "From": "Qiming Yang <qiming.yang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "remy.horton@intel.com,\n\tQiming Yang <qiming.yang@intel.com>",
        "Date": "Fri, 18 Nov 2016 17:40:13 +0800",
        "Message-Id": "<1479462013-11562-1-git-send-email-qiming.yang@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] examples/ethtool: fix bug in drvinfo callback",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Function pcmd_drvinfo_callback uses struct info to get\nthe ethtool infomation of each port. Struct info will\nstore the infomation of previous port until this\ninfomation be updated. This patch fixes this issue.\n\nFixes: bda68ab9d1e7 (\"examples/ethtool: add user-space ethtool sample application\")\n\nSigned-off-by: Qiming Yang <qiming.yang@intel.com>\n---\n examples/ethtool/ethtool-app/ethapp.c | 1 +\n 1 file changed, 1 insertion(+)",
    "diff": "diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethtool-app/ethapp.c\nindex 9b77385..192d941 100644\n--- a/examples/ethtool/ethtool-app/ethapp.c\n+++ b/examples/ethtool/ethtool-app/ethapp.c\n@@ -177,6 +177,7 @@ pcmd_drvinfo_callback(__rte_unused void *ptr_params,\n \tint id_port;\n \n \tfor (id_port = 0; id_port < rte_eth_dev_count(); id_port++) {\n+\t\tmemset(&info, 0, sizeof(info));\n \t\tif (rte_ethtool_get_drvinfo(id_port, &info)) {\n \t\t\tprintf(\"Error getting info for port %i\\n\", id_port);\n \t\t\treturn;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}