Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17074,
    "url": "https://patches.dpdk.org/api/patches/17074/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1479392685-19608-1-git-send-email-jblunck@infradead.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1479392685-19608-1-git-send-email-jblunck@infradead.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1479392685-19608-1-git-send-email-jblunck@infradead.org",
    "date": "2016-11-17T14:24:44",
    "name": "[dpdk-dev,1/2] Clear eth_dev->data in rte_eth_dev_allocate()",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e636c37b21a8de699cfe25b1bde6f857ca02248c",
    "submitter": {
        "id": 249,
        "url": "https://patches.dpdk.org/api/people/249/?format=api",
        "name": "Jan Blunck",
        "email": "jblunck@infradead.org"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1479392685-19608-1-git-send-email-jblunck@infradead.org/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/17074/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/17074/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 605435587;\n\tThu, 17 Nov 2016 15:25:14 +0100 (CET)",
            "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 77FFC5587\n\tfor <dev@dpdk.org>; Thu, 17 Nov 2016 15:25:12 +0100 (CET)",
            "by mail-wm0-f65.google.com with SMTP id a20so21807038wme.2\n\tfor <dev@dpdk.org>; Thu, 17 Nov 2016 06:25:12 -0800 (PST)",
            "from weierstrass.local.net ([91.200.110.70])\n\tby smtp.gmail.com with ESMTPSA id\n\tkq7sm3512737wjb.30.2016.11.17.06.25.11 for <dev@dpdk.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 17 Nov 2016 06:25:11 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=sender:from:to:subject:date:message-id;\n\tbh=Iyi6DJdeDtjc4eULs9QXghwmnMMSibvHSCoKwpWgnfk=;\n\tb=HcikQSnnjVXyIbJfr9I5S+OQ4RCxdoZmeC8/PywisVxxj+iRBs9Fjvm2xQwvj3NeIp\n\t+rjBxHkNBlqd9KEtknC+7yUGbbyqonmTrbIeYpxnjjPEMc53CPc4iKs8EAAOKB4aHbhy\n\t05iIalQP6hlNRvmakP2940W1g+OTAPU7hnvuRXtM9tMH94eJBo7981L34i4oXWgQKKM6\n\tpSMkMgpaQUNzps0pPUiN0eFDUs0VINOnEQfB+NVmp7IXWolzwzooznuw2naRJCt5Dxrv\n\tYPC+TFhdHOrzmSn0gSeLO+MZjW5hGqMrG7akuvjidbuZR1mW3YAKFZhCES4Hvl4LU5ff\n\tAZjQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:sender:from:to:subject:date:message-id;\n\tbh=Iyi6DJdeDtjc4eULs9QXghwmnMMSibvHSCoKwpWgnfk=;\n\tb=kds0UEo3ZNWBmBTLVD0t5RFaYFrJ05iKdOGm9EyaTqCPJ2lx7WX6bdX+sq1rKG6aUj\n\tGP+lrjRCB8WSOny8oWOIv6ZQufPWYFoE06jnQNOMs5TFVS5ivwke416VXE6FO6bmLvdH\n\tLY6ac5B7gsdwVaKRHSYZd0HPWvnivENJ92mgM0BISytMe/uy/OetYFEj1TZz8QDgX/1d\n\tYQKvorMwvn+SleFJReDCKSzTgwa9v8uhSzi8Nxdx4PyQTbr0ruR/rNXDAeOsERH/G3/o\n\tklcEs04nLUb5uKx1zdSIlq/HzEy7d6QSu09nsFf9l1T165LbH4GxrueBe3DN1F48mknq\n\trrwQ==",
        "X-Gm-Message-State": "ABUngvd3o/sGBVbntM7MDy6gQp11Bh5/GYGnm5MiBFm9cVrHztoA0ydMMalU4y/9qxAoaw==",
        "X-Received": "by 10.28.236.205 with SMTP id h74mr16065782wmi.104.1479392711999;\n\tThu, 17 Nov 2016 06:25:11 -0800 (PST)",
        "From": "Jan Blunck <jblunck@infradead.org>",
        "To": "dev@dpdk.org",
        "Date": "Thu, 17 Nov 2016 15:24:44 +0100",
        "Message-Id": "<1479392685-19608-1-git-send-email-jblunck@infradead.org>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH 1/2] Clear eth_dev->data in rte_eth_dev_allocate()",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Lets clear the eth_dev->data when allocating a new rte_eth_dev so that\ndrivers only need to set non-zero values.\n\nSigned-off-by: Jan Blunck <jblunck@infradead.org>\n---\n drivers/net/mlx4/mlx4.c       | 1 -\n drivers/net/mlx5/mlx5.c       | 1 -\n lib/librte_ether/rte_ethdev.c | 2 +-\n 3 files changed, 1 insertion(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex da61a85..9264242 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -5834,7 +5834,6 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\t\teth_dev->rx_pkt_burst = mlx4_rx_burst_secondary_setup;\n \t\t} else {\n \t\t\teth_dev->data->dev_private = priv;\n-\t\t\teth_dev->data->rx_mbuf_alloc_failed = 0;\n \t\t\teth_dev->data->mtu = ETHER_MTU;\n \t\t\teth_dev->data->mac_addrs = priv->mac;\n \t\t}\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 90cc35e..b57cad1 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -652,7 +652,6 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\t\teth_dev->rx_pkt_burst = mlx5_rx_burst_secondary_setup;\n \t\t} else {\n \t\t\teth_dev->data->dev_private = priv;\n-\t\t\teth_dev->data->rx_mbuf_alloc_failed = 0;\n \t\t\teth_dev->data->mtu = ETHER_MTU;\n \t\t\teth_dev->data->mac_addrs = priv->mac;\n \t\t}\ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex fde8112..12af4b1 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -212,6 +212,7 @@ rte_eth_dev_allocate(const char *name)\n \n \teth_dev = &rte_eth_devices[port_id];\n \teth_dev->data = &rte_eth_dev_data[port_id];\n+\tmemset(eth_dev->data, 0, sizeof(*eth_dev->data));\n \tsnprintf(eth_dev->data->name, sizeof(eth_dev->data->name), \"%s\", name);\n \teth_dev->data->port_id = port_id;\n \teth_dev->attached = DEV_ATTACHED;\n@@ -259,7 +260,6 @@ rte_eth_dev_pci_probe(struct rte_pci_driver *pci_drv,\n \t}\n \teth_dev->pci_dev = pci_dev;\n \teth_dev->driver = eth_drv;\n-\teth_dev->data->rx_mbuf_alloc_failed = 0;\n \n \t/* init user callbacks */\n \tTAILQ_INIT(&(eth_dev->link_intr_cbs));\n",
    "prefixes": [
        "dpdk-dev",
        "1/2"
    ]
}