Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17037,
    "url": "https://patches.dpdk.org/api/patches/17037/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/fe398ab2248da252ee10892c4fe68e7cd3e239ff.1479309720.git.adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<fe398ab2248da252ee10892c4fe68e7cd3e239ff.1479309720.git.adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/fe398ab2248da252ee10892c4fe68e7cd3e239ff.1479309720.git.adrien.mazarguil@6wind.com",
    "date": "2016-11-16T16:23:39",
    "name": "[dpdk-dev,13/22] app/testpmd: add rte_flow item spec prefix length",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "1ad262e2617cae384f7e2f652ec7f357571ca4cc",
    "submitter": {
        "id": 165,
        "url": "https://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/fe398ab2248da252ee10892c4fe68e7cd3e239ff.1479309720.git.adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/17037/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/17037/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id ABF3DD4B8;\n\tWed, 16 Nov 2016 17:25:30 +0100 (CET)",
            "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id B40D75599\n\tfor <dev@dpdk.org>; Wed, 16 Nov 2016 17:24:37 +0100 (CET)",
            "by mail-wm0-f52.google.com with SMTP id a197so249930534wmd.0\n\tfor <dev@dpdk.org>; Wed, 16 Nov 2016 08:24:37 -0800 (PST)",
            "from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tc202sm12660250wme.1.2016.11.16.08.24.36\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tWed, 16 Nov 2016 08:24:36 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=bdFsLAtEhb1kER+daStmsCl/KZAXYNz+hXFo29CtMaI=;\n\tb=WHr7tKcCR3lg9PFZxJg4+iaOEQtlz9waYsuwB2NoaUhA56OJney1JdNZ+F5xE37vYt\n\tR4vFEuDvZzvPdkZ0qIOtex2bdSS1rP0z2NHm6ljJtag2MYw3OayqIKlXDm3EkZtllU5F\n\tI+0DNmgUPuZtIdG+ne1ip1ssoiMozrIyXWmZGKHDPSwzAD2WaDHY8zCF6HWjtaDnt/2E\n\t9c9pGB0I8ER52XvqDO/QMFzEzyBvsQQ0BBVxWsGFYmdRxQhpOUsmy1xYUYH0yrTIeEiy\n\tz1zxNlo/cKwANzA88jOYY4ubcyFNPOm4EXvcziF1A3FWIICO+3g0QLQk6muBo0NbPWhI\n\t3wPg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=bdFsLAtEhb1kER+daStmsCl/KZAXYNz+hXFo29CtMaI=;\n\tb=ZenD1ig9xh/XeyAHFrDrrs2tep9k1ZnjIzxr2MdqSmicyzQweZ0d+WEPdpWPpqOqBN\n\t/qzT8+Td8BKO1CCfVNOh/0XeIwVfcRuKTmnAw+juTOLRPtMdIqMmKmLaK28eKifYgnVv\n\t/hiQHVOIPIVTfdv16XJ2LPscG3Ij/tRawiTcHeDIR5GPe2UZTKQ4+kOcnHyEsCRJHP0p\n\t6kKV9EYHYnO8DCZMeWEX8/zSlMC0H/ebO6rpJsZkhxURf38TBbbWD4h7/dhZnUmXpXRM\n\tAsAJT/8bW+nrmT65qQazPGeGXYjVitT7kFiE9LnE/3Bms4/doIveJjgV9G67YDopd9aj\n\tpIpQ==",
        "X-Gm-Message-State": "ABUngvcMmVkOIqg1lagH6vx7rXVGP6MjLZdBrC58Jd4KlNSaZJ6B+ZndH+SADkcjC6RgXz3U",
        "X-Received": "by 10.28.91.143 with SMTP id p137mr11418126wmb.51.1479313477378; \n\tWed, 16 Nov 2016 08:24:37 -0800 (PST)",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "Thomas Monjalon <thomas.monjalon@6wind.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>,\n\tOlivier Matz <olivier.matz@6wind.com>",
        "Date": "Wed, 16 Nov 2016 17:23:39 +0100",
        "Message-Id": "<fe398ab2248da252ee10892c4fe68e7cd3e239ff.1479309720.git.adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<cover.1479309719.git.adrien.mazarguil@6wind.com>",
        "References": "<cover.1471632644.git.adrien.mazarguil@6wind.com>\n\t<cover.1479309719.git.adrien.mazarguil@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 13/22] app/testpmd: add rte_flow item spec prefix\n\tlength",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Generating bit-masks from prefix lengths is often more convenient than\nproviding them entirely (e.g. to define IPv4 and IPv6 subnets).\n\nThis commit adds the \"prefix\" operator that assigns generated bit-masks to\nany pattern item specification field.\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n app/test-pmd/cmdline_flow.c | 80 ++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 80 insertions(+)",
    "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 790b4b8..89307cb 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -56,6 +56,7 @@ enum index {\n \t/* Common tokens. */\n \tINTEGER,\n \tUNSIGNED,\n+\tPREFIX,\n \tRULE_ID,\n \tPORT_ID,\n \tGROUP_ID,\n@@ -93,6 +94,7 @@ enum index {\n \tITEM_PARAM_SPEC,\n \tITEM_PARAM_LAST,\n \tITEM_PARAM_MASK,\n+\tITEM_PARAM_PREFIX,\n \tITEM_NEXT,\n \tITEM_END,\n \tITEM_VOID,\n@@ -277,6 +279,7 @@ static const enum index item_param[] = {\n \tITEM_PARAM_SPEC,\n \tITEM_PARAM_LAST,\n \tITEM_PARAM_MASK,\n+\tITEM_PARAM_PREFIX,\n \t0,\n };\n \n@@ -320,6 +323,9 @@ static int parse_list(struct context *, const struct token *,\n static int parse_int(struct context *, const struct token *,\n \t\t     const char *, unsigned int,\n \t\t     void *, unsigned int);\n+static int parse_prefix(struct context *, const struct token *,\n+\t\t\tconst char *, unsigned int,\n+\t\t\tvoid *, unsigned int);\n static int parse_port(struct context *, const struct token *,\n \t\t      const char *, unsigned int,\n \t\t      void *, unsigned int);\n@@ -360,6 +366,13 @@ static const struct token token_list[] = {\n \t\t.call = parse_int,\n \t\t.comp = comp_none,\n \t},\n+\t[PREFIX] = {\n+\t\t.name = \"{prefix}\",\n+\t\t.type = \"PREFIX\",\n+\t\t.help = \"prefix length for bit-mask\",\n+\t\t.call = parse_prefix,\n+\t\t.comp = comp_none,\n+\t},\n \t[RULE_ID] = {\n \t\t.name = \"{rule id}\",\n \t\t.type = \"RULE ID\",\n@@ -527,6 +540,11 @@ static const struct token token_list[] = {\n \t\t.help = \"specify bit-mask with relevant bits set to one\",\n \t\t.call = parse_vc_spec,\n \t},\n+\t[ITEM_PARAM_PREFIX] = {\n+\t\t.name = \"prefix\",\n+\t\t.help = \"generate bit-mask from a prefix length\",\n+\t\t.call = parse_vc_spec,\n+\t},\n \t[ITEM_NEXT] = {\n \t\t.name = \"/\",\n \t\t.help = \"specify next pattern item\",\n@@ -604,6 +622,62 @@ push_args(struct context *ctx, const struct arg *arg)\n \treturn 0;\n }\n \n+/**\n+ * Parse a prefix length and generate a bit-mask.\n+ *\n+ * Last argument (ctx->args) is retrieved to determine mask size, storage\n+ * location and whether the result must use network byte ordering.\n+ */\n+static int\n+parse_prefix(struct context *ctx, const struct token *token,\n+\t     const char *str, unsigned int len,\n+\t     void *buf, unsigned int size)\n+{\n+\tconst struct arg *arg = pop_args(ctx);\n+\tstatic const uint8_t conv[] = \"\\x00\\x80\\xc0\\xe0\\xf0\\xf8\\xfc\\xfe\\xff\";\n+\tchar *end;\n+\tuintmax_t u;\n+\tunsigned int bytes;\n+\tunsigned int extra;\n+\n+\t(void)token;\n+\t/* Argument is expected. */\n+\tif (!arg)\n+\t\treturn -1;\n+\terrno = 0;\n+\tu = strtoumax(str, &end, 0);\n+\tif (errno || (size_t)(end - str) != len)\n+\t\tgoto error;\n+\tbytes = u / 8;\n+\textra = u % 8;\n+\tsize = arg->size;\n+\tif (bytes > size || bytes + !!extra > size)\n+\t\tgoto error;\n+\tif (!ctx->object)\n+\t\treturn len;\n+\tbuf = (uint8_t *)ctx->object + arg->offset;\n+#if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN\n+\tif (!arg->hton) {\n+\t\tmemset((uint8_t *)buf + size - bytes, 0xff, bytes);\n+\t\tmemset(buf, 0x00, size - bytes);\n+\t\tif (extra)\n+\t\t\t((uint8_t *)buf)[size - bytes - 1] = conv[extra];\n+\t} else\n+#endif\n+\t{\n+\t\tmemset(buf, 0xff, bytes);\n+\t\tmemset((uint8_t *)buf + bytes, 0x00, size - bytes);\n+\t\tif (extra)\n+\t\t\t((uint8_t *)buf)[bytes] = conv[extra];\n+\t}\n+\tif (ctx->objmask)\n+\t\tmemset((uint8_t *)ctx->objmask + arg->offset, 0xff, size);\n+\treturn len;\n+error:\n+\tpush_args(ctx, arg);\n+\treturn -1;\n+}\n+\n /** Default parsing function for token name matching. */\n static int\n parse_default(struct context *ctx, const struct token *token,\n@@ -775,6 +849,12 @@ parse_vc_spec(struct context *ctx, const struct token *token,\n \tcase ITEM_PARAM_LAST:\n \t\tindex = 1;\n \t\tbreak;\n+\tcase ITEM_PARAM_PREFIX:\n+\t\t/* Modify next token to expect a prefix. */\n+\t\tif (ctx->next_num < 2)\n+\t\t\treturn -1;\n+\t\tctx->next[ctx->next_num - 2] = NEXT_ENTRY(PREFIX);\n+\t\t/* Fall through. */\n \tcase ITEM_PARAM_MASK:\n \t\tindex = 2;\n \t\tbreak;\n",
    "prefixes": [
        "dpdk-dev",
        "13/22"
    ]
}