Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17022,
    "url": "https://patches.dpdk.org/api/patches/17022/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1479262339-63608-1-git-send-email-zhiyong.yang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1479262339-63608-1-git-send-email-zhiyong.yang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1479262339-63608-1-git-send-email-zhiyong.yang@intel.com",
    "date": "2016-11-16T02:12:19",
    "name": "[dpdk-dev] eal/linuxapp: fix return value check of mknod()",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fef03bb3df97de15b5940713aabf273f51b4c604",
    "submitter": {
        "id": 540,
        "url": "https://patches.dpdk.org/api/people/540/?format=api",
        "name": "Yang, Zhiyong",
        "email": "zhiyong.yang@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1479262339-63608-1-git-send-email-zhiyong.yang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/17022/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/17022/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 687CE106A;\n\tWed, 16 Nov 2016 03:15:13 +0100 (CET)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 4C71747D1\n\tfor <dev@dpdk.org>; Wed, 16 Nov 2016 03:15:09 +0100 (CET)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP; 15 Nov 2016 18:15:08 -0800",
            "from dpdk2.bj.intel.com ([172.16.182.65])\n\tby fmsmga006.fm.intel.com with ESMTP; 15 Nov 2016 18:15:06 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.31,497,1473145200\"; d=\"scan'208\";a=\"31850927\"",
        "From": "Zhiyong Yang <zhiyong.yang@intel.com>",
        "To": "dev@dpdk.org,\n\tanatoly.burakov@intel.com,\n\tdavid.marchand@6wind.com",
        "Cc": "Wei Dai <wei.dai@intel.com>",
        "Date": "Wed, 16 Nov 2016 10:12:19 +0800",
        "Message-Id": "<1479262339-63608-1-git-send-email-zhiyong.yang@intel.com>",
        "X-Mailer": "git-send-email 2.5.5",
        "Subject": "[dpdk-dev] [PATCH] eal/linuxapp: fix return value check of mknod()",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Wei Dai <wei.dai@intel.com>\n\nIn function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c,\nThe return value of mknod() is ret, not f got by fopen().\nSo the value of ret should be checked for mknod().\n\nFixes: 67c536bdad93 (\"pci: move uio mapping in a dedicated file\")\n\nSigned-off-by: Wei Dai <wei.dai@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\nindex 1786b75..3e4ffb5 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\n@@ -133,7 +133,7 @@ pci_mknod_uio_dev(const char *sysfs_uio_path, unsigned uio_num)\n \tsnprintf(filename, sizeof(filename), \"/dev/uio%u\", uio_num);\n \tdev = makedev(major, minor);\n \tret = mknod(filename, S_IFCHR | S_IRUSR | S_IWUSR, dev);\n-\tif (f == NULL) {\n+\tif (ret != 0) {\n \t\tRTE_LOG(ERR, EAL, \"%s(): mknod() failed %s\\n\",\n \t\t\t__func__, strerror(errno));\n \t\treturn -1;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}