Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17021/?format=api
{ "id": 17021, "url": "https://patches.dpdk.org/api/patches/17021/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20161115230629.GA99122@C02PT1RBG8WP.vpn.broadcom.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20161115230629.GA99122@C02PT1RBG8WP.vpn.broadcom.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20161115230629.GA99122@C02PT1RBG8WP.vpn.broadcom.net", "date": "2016-11-15T23:06:29", "name": "[dpdk-dev] net/bnxt: fix a segfault encountered during PMD exit", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "d0e6035286cd0aadbf0f7efeb0d75049f1377592", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 355, "url": "https://patches.dpdk.org/api/users/355/?format=api", "username": "yliu", "first_name": "Yuanhan", "last_name": "Liu", "email": "yuanhan.liu@linux.intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20161115230629.GA99122@C02PT1RBG8WP.vpn.broadcom.net/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/17021/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/17021/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 9496E47CD;\n\tWed, 16 Nov 2016 00:06:38 +0100 (CET)", "from relay.smtp.broadcom.com (unknown [192.19.211.62])\n\tby dpdk.org (Postfix) with ESMTP id F258B3977;\n\tWed, 16 Nov 2016 00:06:35 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.broadcom.com\n\t[10.15.198.34])\n\tby relay.smtp.broadcom.com (Postfix) with ESMTP id E27AE280618;\n\tTue, 15 Nov 2016 15:06:33 -0800 (PST)", "from C02PT1RBG8WP.vpn.broadcom.net (unknown [10.10.117.74])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id 87D9D81F52;\n\tTue, 15 Nov 2016 15:06:32 -0800 (PST)" ], "Date": "Tue, 15 Nov 2016 17:06:29 -0600", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org", "Message-ID": "<20161115230629.GA99122@C02PT1RBG8WP.vpn.broadcom.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "Subject": "[dpdk-dev] [PATCH] net/bnxt: fix a segfault encountered during PMD\n\texit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes segfault encountered during dev_uninit/close routine.\nKNI sample app can be used to reproduce the issue.\n\nbackported from upstream commit 316e412\n\nCc: <stable@dpdk.org>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_ethdev.c | 28 ++++++++++++++++++----------\n 2 files changed, 19 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex df1f771..0e21ace 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -171,6 +171,7 @@ struct bnxt {\n \n \tstruct bnxt_pf_info\t\tpf;\n \tstruct bnxt_vf_info\t\tvf;\n+\tuint8_t\t\t\tdev_stopped;\n };\n \n #endif\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 3795fac..deeb54c 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -384,6 +384,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tint rc;\n \n+\tbp->dev_stopped = 0;\n \trc = bnxt_hwrm_func_reset(bp);\n \tif (rc) {\n \t\tRTE_LOG(ERR, PMD, \"hwrm chip reset failure rc: %x\\n\", rc);\n@@ -427,16 +428,6 @@ static int bnxt_dev_set_link_down_op(struct rte_eth_dev *eth_dev)\n \treturn 0;\n }\n \n-static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n-{\n-\tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n-\n-\tbnxt_free_tx_mbufs(bp);\n-\tbnxt_free_rx_mbufs(bp);\n-\tbnxt_free_mem(bp);\n-\trte_free(eth_dev->data->mac_addrs);\n-}\n-\n /* Unload the driver, release resources */\n static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n {\n@@ -449,6 +440,19 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n \tbnxt_shutdown_nic(bp);\n }\n \n+static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n+\n+\tif (bp->dev_stopped == 0)\n+\t\tbnxt_dev_stop_op(eth_dev);\n+\n+\tbnxt_free_tx_mbufs(bp);\n+\tbnxt_free_rx_mbufs(bp);\n+\tbnxt_free_mem(bp);\n+\trte_free(eth_dev->data->mac_addrs);\n+}\n+\n static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,\n \t\t\t\t uint32_t index)\n {\n@@ -1021,6 +1025,8 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\teth_dev->pci_dev->mem_resource[0].phys_addr,\n \t\teth_dev->pci_dev->mem_resource[0].addr);\n \n+\tbp->dev_stopped = 0;\n+\n \treturn 0;\n \n error_free:\n@@ -1040,6 +1046,8 @@ bnxt_dev_uninit(struct rte_eth_dev *eth_dev) {\n \t\trte_free(bp->grp_info);\n \trc = bnxt_hwrm_func_driver_unregister(bp, 0);\n \tbnxt_free_hwrm_resources(bp);\n+\tif (bp->dev_stopped == 0)\n+\t\tbnxt_dev_close_op(eth_dev);\n \treturn rc;\n }\n \n", "prefixes": [ "dpdk-dev" ] }