Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17006/?format=api
{ "id": 17006, "url": "https://patches.dpdk.org/api/patches/17006/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1478886096-22105-1-git-send-email-harish.patil@qlogic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1478886096-22105-1-git-send-email-harish.patil@qlogic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1478886096-22105-1-git-send-email-harish.patil@qlogic.com", "date": "2016-11-11T17:41:36", "name": "[dpdk-dev,v2] net/qede: fix unknown speed errmsg for 25G link", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "beca915baffa54fb9b22b7fba628c092e9d599e3", "submitter": { "id": 319, "url": "https://patches.dpdk.org/api/people/319/?format=api", "name": "Harish Patil", "email": "harish.patil@qlogic.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1478886096-22105-1-git-send-email-harish.patil@qlogic.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/17006/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/17006/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C5646D598;\n\tFri, 11 Nov 2016 18:41:53 +0100 (CET)", "from mx0b-0016ce01.pphosted.com (mx0a-0016ce01.pphosted.com\n\t[67.231.148.157]) by dpdk.org (Postfix) with ESMTP id C47362BB3\n\tfor <dev@dpdk.org>; Fri, 11 Nov 2016 18:41:50 +0100 (CET)", "from pps.filterd (m0095336.ppops.net [127.0.0.1])\n\tby mx0a-0016ce01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id\n\tuABHf5fQ004712 for <dev@dpdk.org>; Fri, 11 Nov 2016 09:41:47 -0800", "from avcashub1.qlogic.com ([198.186.0.115])\n\tby mx0a-0016ce01.pphosted.com with ESMTP id 26hdh59mcq-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT)\n\tfor <dev@dpdk.org>; Fri, 11 Nov 2016 09:41:47 -0800", "from avluser05.qlc.com (10.1.113.115) by avcashub1.qlogic.org\n\t(10.1.4.190) with Microsoft SMTP Server (TLS) id 14.3.235.1;\n\tFri, 11 Nov 2016 09:41:47 -0800", "(from hpatil@localhost)\tby avluser05.qlc.com (8.14.4/8.14.4/Submit)\n\tid uABHfluI022184;\tFri, 11 Nov 2016 09:41:47 -0800" ], "From": "Harish Patil <harish.patil@qlogic.com>", "To": "<dev@dpdk.org>", "CC": "<Dept-EngDPDKDev@qlogic.com>, Harish Patil <harish.patil@qlogic.com>", "Date": "Fri, 11 Nov 2016 09:41:36 -0800", "Message-ID": "<1478886096-22105-1-git-send-email-harish.patil@qlogic.com>", "X-Mailer": "git-send-email 1.7.10.3", "In-Reply-To": "<1478744784-17469-1-git-send-email-Rasesh.Mody@cavium.com>", "References": "<1478744784-17469-1-git-send-email-Rasesh.Mody@cavium.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "disclaimer": "bypass", "X-Proofpoint-Virus-Version": "vendor=nai engine=5800 definitions=8346\n\tsignatures=670719", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011\n\tlowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1609300000\n\tdefinitions=main-1611110313", "Subject": "[dpdk-dev] [PATCH v2] net/qede: fix unknown speed errmsg for 25G\n\tlink", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "- Fix to use bitmapped values in NVM configuration for speed capability\n advertisement. This issue is specific to 25G NIC since it is capable\n of 25G and 10G speeds.\n\n- Update feature list.\n\nFixes: 64c239b7f8b7 (\"net/qede: fix advertising link speed capability\")\n\nSigned-off-by: Harish Patil <harish.patil@qlogic.com>\n---\n config/common_base | 2 +-\n doc/guides/nics/features/qede.ini | 1 +\n doc/guides/nics/features/qede_vf.ini | 1 +\n doc/guides/nics/qede.rst | 2 +-\n drivers/net/qede/qede_ethdev.c | 15 ++++++++++++++-\n drivers/net/qede/qede_if.h | 2 +-\n drivers/net/qede/qede_main.c | 25 ++-----------------------\n 7 files changed, 21 insertions(+), 27 deletions(-)", "diff": "diff --git a/config/common_base b/config/common_base\nindex 21d18f8..4bff83a 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -315,7 +315,7 @@ CONFIG_RTE_LIBRTE_PMD_BOND=y\n CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB=n\n CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n\n \n-# QLogic 25G/40G/100G PMD\n+# QLogic 10G/25G/40G/100G PMD\n #\n CONFIG_RTE_LIBRTE_QEDE_PMD=y\n CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=n\ndiff --git a/doc/guides/nics/features/qede.ini b/doc/guides/nics/features/qede.ini\nindex 1f3c3f6..7d75030 100644\n--- a/doc/guides/nics/features/qede.ini\n+++ b/doc/guides/nics/features/qede.ini\n@@ -4,6 +4,7 @@\n ; Refer to default.ini for the full list of available PMD features.\n ;\n [Features]\n+Speed capabilities = Y\n Link status = Y\n Link status event = Y\n MTU update = Y\ndiff --git a/doc/guides/nics/features/qede_vf.ini b/doc/guides/nics/features/qede_vf.ini\nindex 1c0f228..acb1b99 100644\n--- a/doc/guides/nics/features/qede_vf.ini\n+++ b/doc/guides/nics/features/qede_vf.ini\n@@ -4,6 +4,7 @@\n ; Refer to default.ini for the full list of available PMD features.\n ;\n [Features]\n+Speed capabilities = Y\n Link status = Y\n Link status event = Y\n MTU update = Y\ndiff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst\nindex b6f54fd..d22ecdd 100644\n--- a/doc/guides/nics/qede.rst\n+++ b/doc/guides/nics/qede.rst\n@@ -71,7 +71,7 @@ Non-supported Features\n Supported QLogic Adapters\n -------------------------\n \n-- QLogic FastLinQ QL4xxxx 25G/40G/100G CNAs.\n+- QLogic FastLinQ QL4xxxx 10G/25G/40G/100G CNAs.\n \n Prerequisites\n -------------\ndiff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex 59129f2..d106dd0 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -647,6 +647,7 @@ qede_dev_info_get(struct rte_eth_dev *eth_dev,\n \tstruct qede_dev *qdev = eth_dev->data->dev_private;\n \tstruct ecore_dev *edev = &qdev->edev;\n \tstruct qed_link_output link;\n+\tuint32_t speed_cap = 0;\n \n \tPMD_INIT_FUNC_TRACE(edev);\n \n@@ -681,7 +682,19 @@ qede_dev_info_get(struct rte_eth_dev *eth_dev,\n \n \tmemset(&link, 0, sizeof(struct qed_link_output));\n \tqdev->ops->common->get_link(edev, &link);\n-\tdev_info->speed_capa = rte_eth_speed_bitflag(link.adv_speed, 0);\n+\tif (link.adv_speed & NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_1G)\n+\t\tspeed_cap |= ETH_LINK_SPEED_1G;\n+\tif (link.adv_speed & NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_10G)\n+\t\tspeed_cap |= ETH_LINK_SPEED_10G;\n+\tif (link.adv_speed & NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_25G)\n+\t\tspeed_cap |= ETH_LINK_SPEED_25G;\n+\tif (link.adv_speed & NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_40G)\n+\t\tspeed_cap |= ETH_LINK_SPEED_40G;\n+\tif (link.adv_speed & NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_50G)\n+\t\tspeed_cap |= ETH_LINK_SPEED_50G;\n+\tif (link.adv_speed & NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_BB_100G)\n+\t\tspeed_cap |= ETH_LINK_SPEED_100G;\n+\tdev_info->speed_capa = speed_cap;\n }\n \n /* return 0 means link status changed, -1 means not changed */\ndiff --git a/drivers/net/qede/qede_if.h b/drivers/net/qede/qede_if.h\nindex 4936349..2131fe2 100644\n--- a/drivers/net/qede/qede_if.h\n+++ b/drivers/net/qede/qede_if.h\n@@ -70,7 +70,7 @@ struct qed_link_output {\n \tuint32_t advertised_caps;\t/* In ADVERTISED defs */\n \tuint32_t lp_caps;\t/* In ADVERTISED defs */\n \tuint32_t speed;\t\t/* In Mb/s */\n-\tuint32_t adv_speed;\t/* In Mb/s */\n+\tuint32_t adv_speed;\t/* Speed mask */\n \tuint8_t duplex;\t\t/* In DUPLEX defs */\n \tuint8_t port;\t\t/* In PORT defs */\n \tbool autoneg;\ndiff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c\nindex d2e476c..ab22409 100644\n--- a/drivers/net/qede/qede_main.c\n+++ b/drivers/net/qede/qede_main.c\n@@ -488,7 +488,6 @@ static void qed_fill_link(struct ecore_hwfn *hwfn,\n \tstruct ecore_mcp_link_state link;\n \tstruct ecore_mcp_link_capabilities link_caps;\n \tuint32_t media_type;\n-\tuint32_t adv_speed;\n \tuint8_t change = 0;\n \n \tmemset(if_link, 0, sizeof(*if_link));\n@@ -516,28 +515,8 @@ static void qed_fill_link(struct ecore_hwfn *hwfn,\n \n \tif_link->duplex = QEDE_DUPLEX_FULL;\n \n-\t/* Fill up the native advertised speed */\n-\tswitch (params.speed.advertised_speeds) {\n-\tcase NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_10G:\n-\t\tadv_speed = 10000;\n-\tbreak;\n-\tcase NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_25G:\n-\t\tadv_speed = 25000;\n-\tbreak;\n-\tcase NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_40G:\n-\t\tadv_speed = 40000;\n-\tbreak;\n-\tcase NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_50G:\n-\t\tadv_speed = 50000;\n-\tbreak;\n-\tcase NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_BB_100G:\n-\t\tadv_speed = 100000;\n-\tbreak;\n-\tdefault:\n-\t\tDP_NOTICE(hwfn, false, \"Unknown speed\\n\");\n-\t\tadv_speed = 0;\n-\t}\n-\tif_link->adv_speed = adv_speed;\n+\t/* Fill up the native advertised speed cap mask */\n+\tif_link->adv_speed = params.speed.advertised_speeds;\n \n \tif (params.speed.autoneg)\n \t\tif_link->supported_caps |= QEDE_SUPPORTED_AUTONEG;\n", "prefixes": [ "dpdk-dev", "v2" ] }