Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 16994,
    "url": "https://patches.dpdk.org/api/patches/16994/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1478795380-16975-1-git-send-email-reshma.pattan@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1478795380-16975-1-git-send-email-reshma.pattan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1478795380-16975-1-git-send-email-reshma.pattan@intel.com",
    "date": "2016-11-10T16:29:40",
    "name": "[dpdk-dev] pdump: fix log message to display correct error number",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "fbd432e766faceb544c0fc7873e15ca539d0a824",
    "submitter": {
        "id": 70,
        "url": "https://patches.dpdk.org/api/people/70/?format=api",
        "name": "Pattan, Reshma",
        "email": "reshma.pattan@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1478795380-16975-1-git-send-email-reshma.pattan@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/16994/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/16994/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 006C7D4B0;\n\tThu, 10 Nov 2016 17:30:01 +0100 (CET)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 03A25D4AA\n\tfor <dev@dpdk.org>; Thu, 10 Nov 2016 17:29:58 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 10 Nov 2016 08:29:57 -0800",
            "from sivswdev02.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.46])\n\tby orsmga001.jf.intel.com with ESMTP; 10 Nov 2016 08:29:42 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.31,619,1473145200\"; d=\"scan'208\";\n\ta=\"1057921913\"",
        "From": "Reshma Pattan <reshma.pattan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Reshma Pattan <reshma.pattan@gmail.com>",
        "Date": "Thu, 10 Nov 2016 16:29:40 +0000",
        "Message-Id": "<1478795380-16975-1-git-send-email-reshma.pattan@intel.com>",
        "X-Mailer": "git-send-email 1.7.0.7",
        "Subject": "[dpdk-dev] [PATCH] pdump: fix log message to display correct error\n\tnumber",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The ethdev Rx/Tx remove callback apis doesn't set rte_errno during\nfailures, instead they just return negative error number, so using\nthat number in logs instead of rte_errno upon Rx and Tx callback\nremoval failures.\n\nFixes: 278f9454 (\"pdump: add new library for packet capture\")\n\nSigned-off-by: Reshma Pattan <reshma.pattan@gmail.com>\n---\n lib/librte_pdump/rte_pdump.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c\nindex 504a1ce..5968683 100644\n--- a/lib/librte_pdump/rte_pdump.c\n+++ b/lib/librte_pdump/rte_pdump.c\n@@ -269,7 +269,7 @@ pdump_regitser_rx_callbacks(uint16_t end_q, uint8_t port, uint16_t queue,\n \t\t\tif (ret < 0) {\n \t\t\t\tRTE_LOG(ERR, PDUMP,\n \t\t\t\t\t\"failed to remove rx callback, errno=%d\\n\",\n-\t\t\t\t\trte_errno);\n+\t\t\t\t\t-ret);\n \t\t\t\treturn ret;\n \t\t\t}\n \t\t\tcbs->cb = NULL;\n@@ -324,7 +324,7 @@ pdump_regitser_tx_callbacks(uint16_t end_q, uint8_t port, uint16_t queue,\n \t\t\tif (ret < 0) {\n \t\t\t\tRTE_LOG(ERR, PDUMP,\n \t\t\t\t\t\"failed to remove tx callback, errno=%d\\n\",\n-\t\t\t\t\trte_errno);\n+\t\t\t\t\t-ret);\n \t\t\t\treturn ret;\n \t\t\t}\n \t\t\tcbs->cb = NULL;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}