Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 16982,
    "url": "https://patches.dpdk.org/api/patches/16982/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1478696906-20948-1-git-send-email-olivier.matz@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1478696906-20948-1-git-send-email-olivier.matz@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1478696906-20948-1-git-send-email-olivier.matz@6wind.com",
    "date": "2016-11-09T13:08:26",
    "name": "[dpdk-dev] app/test: fix crash of lpm test",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "b44db0909359b56fe44aeeb3de4c88b3226fe344",
    "submitter": {
        "id": 8,
        "url": "https://patches.dpdk.org/api/people/8/?format=api",
        "name": "Olivier Matz",
        "email": "olivier.matz@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1478696906-20948-1-git-send-email-olivier.matz@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/16982/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/16982/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D3DF63772;\n\tWed,  9 Nov 2016 14:08:41 +0100 (CET)",
            "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n\t[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id DE9E23770\n\tfor <dev@dpdk.org>; Wed,  9 Nov 2016 14:08:39 +0100 (CET)",
            "from glumotte.dev.6wind.com (unknown [10.16.0.195])\n\tby proxy.6wind.com (Postfix) with ESMTP id 4700F2502B;\n\tWed,  9 Nov 2016 14:08:36 +0100 (CET)"
        ],
        "From": "Olivier Matz <olivier.matz@6wind.com>",
        "To": "dev@dpdk.org,\n\twei.dai@intel.com",
        "Cc": "bruce.richardson@intel.com",
        "Date": "Wed,  9 Nov 2016 14:08:26 +0100",
        "Message-Id": "<1478696906-20948-1-git-send-email-olivier.matz@6wind.com>",
        "X-Mailer": "git-send-email 2.8.1",
        "Subject": "[dpdk-dev] [PATCH] app/test: fix crash of lpm test",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The test recently added accesses to lpm->tbl8[ip >> 8] with is much\nlarger than the size of the table, causing a crash of the test\napplication.\n\nFix this typo by replacing tbl8 by tbl24.\n\nFixes: 231fa88ed522 (\"app/test: verify LPM tbl8 recycle\")\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n\nHi Wei,\n\nI don't know lpm very well and I did not spend much time to understand\nthe test case. I guess that's the proper fix, but please check carefully\nthat I'm not doing something wrong :)\n\nThanks,\nOlivier\n\n\n app/test/test_lpm.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/app/test/test_lpm.c b/app/test/test_lpm.c\nindex 80e0efc..41ae80f 100644\n--- a/app/test/test_lpm.c\n+++ b/app/test/test_lpm.c\n@@ -1256,7 +1256,7 @@ test18(void)\n \trte_lpm_add(lpm, ip, depth, next_hop);\n \n \tTEST_LPM_ASSERT(lpm->tbl24[ip>>8].valid_group);\n-\ttbl8_group_index = lpm->tbl8[ip>>8].group_idx;\n+\ttbl8_group_index = lpm->tbl24[ip>>8].group_idx;\n \n \tdepth = 23;\n \tnext_hop = 2;\n@@ -1272,7 +1272,7 @@ test18(void)\n \trte_lpm_add(lpm, ip, depth, next_hop);\n \n \tTEST_LPM_ASSERT(lpm->tbl24[ip>>8].valid_group);\n-\tTEST_LPM_ASSERT(tbl8_group_index == lpm->tbl8[ip>>8].group_idx);\n+\tTEST_LPM_ASSERT(tbl8_group_index == lpm->tbl24[ip>>8].group_idx);\n \n \tdepth = 24;\n \tnext_hop = 4;\n@@ -1288,7 +1288,7 @@ test18(void)\n \trte_lpm_add(lpm, ip, depth, next_hop);\n \n \tTEST_LPM_ASSERT(lpm->tbl24[ip>>8].valid_group);\n-\tTEST_LPM_ASSERT(tbl8_group_index == lpm->tbl8[ip>>8].group_idx);\n+\tTEST_LPM_ASSERT(tbl8_group_index == lpm->tbl24[ip>>8].group_idx);\n \n \trte_lpm_free(lpm);\n #undef group_idx\n",
    "prefixes": [
        "dpdk-dev"
    ]
}