Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 16980,
    "url": "https://patches.dpdk.org/api/patches/16980/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20161109082341.19825-1-bjorn.topel@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20161109082341.19825-1-bjorn.topel@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20161109082341.19825-1-bjorn.topel@intel.com",
    "date": "2016-11-09T08:23:41",
    "name": "[dpdk-dev] examples/l3fwd: force CRC stripping for i40evf",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "d4ba2f7a312e6427b6cdaf4836416617614e8e2f",
    "submitter": {
        "id": 460,
        "url": "https://patches.dpdk.org/api/people/460/?format=api",
        "name": "Björn Töpel",
        "email": "bjorn.topel@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20161109082341.19825-1-bjorn.topel@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/16980/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/16980/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 681CA377A;\n\tWed,  9 Nov 2016 09:23:56 +0100 (CET)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 948963772\n\tfor <dev@dpdk.org>; Wed,  9 Nov 2016 09:23:54 +0100 (CET)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP; 09 Nov 2016 00:23:53 -0800",
            "from rmitura-mobl1.ger.corp.intel.com (HELO btopel-mobl1.intel.com)\n\t([10.252.24.154])\n\tby fmsmga006.fm.intel.com with ESMTP; 09 Nov 2016 00:23:51 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.31,465,1473145200\"; d=\"scan'208\";a=\"29087125\"",
        "From": "=?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= <bjorn.topel@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "qian.q.xu@intel.com, lei.a.yao@intel.com, jingjing.wu@intel.com,\n\tthomas.monjalon@6wind.com,\n\t=?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= <bjorn.topel@intel.com>",
        "Date": "Wed,  9 Nov 2016 09:23:41 +0100",
        "Message-Id": "<20161109082341.19825-1-bjorn.topel@intel.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Commit 1bbcc5d21129 (\"i40evf: report error for unsupported CRC\nstripping config\") broke l3fwd, since it was forcing that CRC was\nkept. Now, if i40evf is running, CRC stripping will be enabled.\n\nSigned-off-by: Björn Töpel <bjorn.topel@intel.com>\n---\n examples/l3fwd/main.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex 7223e773107e..b60278794135 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -906,6 +906,14 @@ main(int argc, char **argv)\n \t\t\tn_tx_queue = MAX_TX_QUEUE_PER_PORT;\n \t\tprintf(\"Creating queues: nb_rxq=%d nb_txq=%u... \",\n \t\t\tnb_rx_queue, (unsigned)n_tx_queue );\n+\t\trte_eth_dev_info_get(portid, &dev_info);\n+\t\tif (dev_info.driver_name &&\n+\t\t    strcmp(dev_info.driver_name, \"net_i40e_vf\") == 0) {\n+\t\t\t/* i40evf require that CRC stripping is enabled. */\n+\t\t\tport_conf.rxmode.hw_strip_crc = 1;\n+\t\t} else {\n+\t\t\tport_conf.rxmode.hw_strip_crc = 0;\n+\t\t}\n \t\tret = rte_eth_dev_configure(portid, nb_rx_queue,\n \t\t\t\t\t(uint16_t)n_tx_queue, &port_conf);\n \t\tif (ret < 0)\n@@ -946,7 +954,6 @@ main(int argc, char **argv)\n \t\t\tprintf(\"txq=%u,%d,%d \", lcore_id, queueid, socketid);\n \t\t\tfflush(stdout);\n \n-\t\t\trte_eth_dev_info_get(portid, &dev_info);\n \t\t\ttxconf = &dev_info.default_txconf;\n \t\t\tif (port_conf.rxmode.jumbo_frame)\n \t\t\t\ttxconf->txq_flags = 0;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}