Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/16964/?format=api
{ "id": 16964, "url": "https://patches.dpdk.org/api/patches/16964/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1478509409-25508-1-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1478509409-25508-1-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1478509409-25508-1-git-send-email-david.marchand@6wind.com", "date": "2016-11-07T09:03:29", "name": "[dpdk-dev] pci: do not mark device as taken when probe fails", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7025d63083ddc031d1c19493ef81529af6904495", "submitter": { "id": 3, "url": "https://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1478509409-25508-1-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/16964/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/16964/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 552D75598;\n\tMon, 7 Nov 2016 10:03:38 +0100 (CET)", "from mail-wm0-f44.google.com (mail-wm0-f44.google.com\n\t[74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 0AEA05591\n\tfor <dev@dpdk.org>; Mon, 7 Nov 2016 10:03:37 +0100 (CET)", "by mail-wm0-f44.google.com with SMTP id f82so104443290wmf.1\n\tfor <dev@dpdk.org>; Mon, 07 Nov 2016 01:03:37 -0800 (PST)", "from gloops.dev.6wind.com (89.156.119.78.rev.sfr.net.\n\t[78.119.156.89]) by smtp.gmail.com with ESMTPSA id\n\tw65sm12205523wmd.23.2016.11.07.01.03.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 07 Nov 2016 01:03:36 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=eCwGK3EbkD6iq/kKPzsy29yi4yU1br8ztGVqbvVBV2c=;\n\tb=OVOk2YpFyx0+smYxnyikB2mYEvHbWsihRNiSHcbRkyj6uF46pqY0nJ+ANL1xdFbnXG\n\tKRXVMxGocU3rTGM+1Q8bks1UxfwzjxL8wPqIH9z8laPoUay+SvDCBmnJU+YSLAPqQBdc\n\t+Kqc3TgBV8ux6sZatD8c74Ii/Z9YaH1eFI0LdZCl0D/nOIDeUuDfaX/nVOYyPWSy6VRo\n\tQR66MYEaeFWPrr6KQQqM8PRz8lXAZegnuD+X4gU15Xoigib/RO8hc9ggWD6+QoDlUJxc\n\tOGTyX6IAi8MDPhejG+OnrV7kESAI5etJRxPAclfPw39IZ9LlhIAQFo4AmZRvnObUZeLn\n\tKYHw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=eCwGK3EbkD6iq/kKPzsy29yi4yU1br8ztGVqbvVBV2c=;\n\tb=KbmaKEKILyUDCir9pwEzV1z8RxRpVWMnRnScI8zfTtWRyym0BkGujq7E9Ek8MExntM\n\tWoDVn7nF2cCP8ashcv9/2JUp27vd7O4QGhVwpq1WxY1djSDJJrJDs9WuJUwm823ePO+g\n\tGiF22MC4jfXB7LbRe3CXYtvuzNLAVFAJgkBlaSfbpxfkj/z/FVT7lZhFXwoxADiEH2cQ\n\tHhPczSURQhn31Vmqzo89YMl+GgRz06x5pyKImv0WMdCZvLdufUMQN5tP0baZz7NLhox3\n\tvXktSF12J0yN2yHUUyGx/hKmDMWpDu+Ng111m4Mg91LM84v+dDYm+iHy3b8hJrGhnYMb\n\tj9eA==", "X-Gm-Message-State": "ABUngvekAbzgmsvAZ06K/kRWSxkOxXMPxn1w0fmC+QlfYrV+6ZrSVRP+C9zKOIvKmFk/fOAe", "X-Received": "by 10.194.222.105 with SMTP id ql9mr5475456wjc.63.1478509416818; \n\tMon, 07 Nov 2016 01:03:36 -0800 (PST)", "From": "David Marchand <david.marchand@6wind.com>", "To": "thomas.monjalon@6wind.com", "Cc": "dev@dpdk.org,\n\tbenjamin.walker@intel.com", "Date": "Mon, 7 Nov 2016 10:03:29 +0100", "Message-Id": "<1478509409-25508-1-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<CALwxeUtOT1TCaevHwx8kSdEqHd4b5VO1ER2n0Xym94mWvObm_Q@mail.gmail.com>", "References": "<CALwxeUtOT1TCaevHwx8kSdEqHd4b5VO1ER2n0Xym94mWvObm_Q@mail.gmail.com>", "Subject": "[dpdk-dev] [PATCH] pci: do not mark device as taken when probe fails", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "dev->driver should be set only if a driver did take the device.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_eal/common/eal_common_pci.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c\nindex 971ad20..6163b09 100644\n--- a/lib/librte_eal/common/eal_common_pci.c\n+++ b/lib/librte_eal/common/eal_common_pci.c\n@@ -214,7 +214,11 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d\n \t\tdev->driver = dr;\n \n \t\t/* call the driver probe() function */\n-\t\treturn dr->probe(dr, dev);\n+\t\tret = dr->probe(dr, dev);\n+\t\tif (ret)\n+\t\t\tdev->driver = NULL;\n+\n+\t\treturn ret;\n \t}\n \t/* return positive value if driver doesn't support this device */\n \treturn 1;\n", "prefixes": [ "dpdk-dev" ] }