Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/16951/?format=api
{ "id": 16951, "url": "https://patches.dpdk.org/api/patches/16951/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1478338865-26126-10-git-send-email-yuanhan.liu@linux.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1478338865-26126-10-git-send-email-yuanhan.liu@linux.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1478338865-26126-10-git-send-email-yuanhan.liu@linux.intel.com", "date": "2016-11-05T09:41:04", "name": "[dpdk-dev,v2,09/10] net/virtio: fix less queues being enabled issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e52b8bf1ccb845eb30e838c6548cade8c25a7a58", "submitter": { "id": 307, "url": "https://patches.dpdk.org/api/people/307/?format=api", "name": "Yuanhan Liu", "email": "yuanhan.liu@linux.intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1478338865-26126-10-git-send-email-yuanhan.liu@linux.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/16951/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/16951/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 632F358CF;\n\tSat, 5 Nov 2016 10:41:28 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id E4282137C\n\tfor <dev@dpdk.org>; Sat, 5 Nov 2016 10:40:31 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP; 05 Nov 2016 02:40:31 -0700", "from yliu-dev.sh.intel.com ([10.239.67.162])\n\tby fmsmga004.fm.intel.com with ESMTP; 05 Nov 2016 02:40:29 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,448,1473145200\"; \n\td=\"scan'208,223\";a=\"187945173\"", "From": "Yuanhan Liu <yuanhan.liu@linux.intel.com>", "To": "dev@dpdk.org", "Cc": "Thomas Monjalon <thomas.monjalon@6wind.com>,\n\tTan Jianfeng <jianfeng.tan@intel.com>,\n\tKevin Traynor <ktraynor@redhat.com>, \n\tIlya Maximets <i.maximets@samsung.com>,\n\tKyle Larose <klarose@sandvine.com>, \n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tYuanhan Liu <yuanhan.liu@linux.intel.com>", "Date": "Sat, 5 Nov 2016 17:41:04 +0800", "Message-Id": "<1478338865-26126-10-git-send-email-yuanhan.liu@linux.intel.com>", "X-Mailer": "git-send-email 1.9.0", "In-Reply-To": "<1478338865-26126-1-git-send-email-yuanhan.liu@linux.intel.com>", "References": "<1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com>\n\t<1478338865-26126-1-git-send-email-yuanhan.liu@linux.intel.com>", "Subject": "[dpdk-dev] [PATCH v2 09/10] net/virtio: fix less queues being\n\tenabled issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From the virtio spec of view, multiple-queue is always enabled/disabled\nin queue pairs. DPDK somehow allows the case when Tx and Rx queue number\nare different.\n\nCurrently, virtio PMD get the queue pair number from the nb_rx_queues\nfield, which could be an issue when Tx queue number > Rx queue number.\nSay, 2 Tx queues and 1 Rx queues. This would end up with 1 quues being\nenabled. Which is wrong.\n\nThe fix is straightforward. Just pick a bigger number and enable that many\nof queues.\n\nFixes: 823ad647950a (\"virtio: support multiple queues\")\n\nSigned-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 5ec3e0e..d70bd00 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1493,7 +1493,7 @@ virtio_dev_start(struct rte_eth_dev *dev)\n \t *Otherwise the tap backend might already stop its queue due to fullness.\n \t *vhost backend will have no chance to be waked up\n \t */\n-\tnb_queues = dev->data->nb_rx_queues;\n+\tnb_queues = RTE_MAX(dev->data->nb_rx_queues, dev->data->nb_tx_queues);\n \tif (nb_queues > 1) {\n \t\tif (virtio_set_multiple_queues(dev, nb_queues) != 0)\n \t\t\treturn -EINVAL;\n@@ -1501,7 +1501,7 @@ virtio_dev_start(struct rte_eth_dev *dev)\n \n \tPMD_INIT_LOG(DEBUG, \"nb_queues=%d\", nb_queues);\n \n-\tfor (i = 0; i < nb_queues; i++) {\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\trxvq = dev->data->rx_queues[i];\n \t\tvirtqueue_notify(rxvq->vq);\n \t}\n", "prefixes": [ "dpdk-dev", "v2", "09/10" ] }