Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/16950/?format=api
{ "id": 16950, "url": "https://patches.dpdk.org/api/patches/16950/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1478338865-26126-9-git-send-email-yuanhan.liu@linux.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1478338865-26126-9-git-send-email-yuanhan.liu@linux.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1478338865-26126-9-git-send-email-yuanhan.liu@linux.intel.com", "date": "2016-11-05T09:41:03", "name": "[dpdk-dev,v2,08/10] net/virtio: remove started field", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d9abb823c400090d8cf8f82ca2e331dfc97eaa5e", "submitter": { "id": 307, "url": "https://patches.dpdk.org/api/people/307/?format=api", "name": "Yuanhan Liu", "email": "yuanhan.liu@linux.intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1478338865-26126-9-git-send-email-yuanhan.liu@linux.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/16950/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/16950/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 13E085688;\n\tSat, 5 Nov 2016 10:41:26 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id EE211106A\n\tfor <dev@dpdk.org>; Sat, 5 Nov 2016 10:40:29 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP; 05 Nov 2016 02:40:29 -0700", "from yliu-dev.sh.intel.com ([10.239.67.162])\n\tby fmsmga004.fm.intel.com with ESMTP; 05 Nov 2016 02:40:27 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,448,1473145200\"; d=\"scan'208\";a=\"187945165\"", "From": "Yuanhan Liu <yuanhan.liu@linux.intel.com>", "To": "dev@dpdk.org", "Cc": "Thomas Monjalon <thomas.monjalon@6wind.com>,\n\tTan Jianfeng <jianfeng.tan@intel.com>,\n\tKevin Traynor <ktraynor@redhat.com>, \n\tIlya Maximets <i.maximets@samsung.com>,\n\tKyle Larose <klarose@sandvine.com>, \n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tYuanhan Liu <yuanhan.liu@linux.intel.com>", "Date": "Sat, 5 Nov 2016 17:41:03 +0800", "Message-Id": "<1478338865-26126-9-git-send-email-yuanhan.liu@linux.intel.com>", "X-Mailer": "git-send-email 1.9.0", "In-Reply-To": "<1478338865-26126-1-git-send-email-yuanhan.liu@linux.intel.com>", "References": "<1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com>\n\t<1478338865-26126-1-git-send-email-yuanhan.liu@linux.intel.com>", "Subject": "[dpdk-dev] [PATCH v2 08/10] net/virtio: remove started field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The \"hw->started\" field was introduced to stop touching queues\non restart. We never touches queues on restart any more, thus\nit's safe to remove this flag.\n\nSigned-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 15 ++-------------\n drivers/net/virtio/virtio_pci.h | 1 -\n 2 files changed, 2 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 15c48b9..5ec3e0e 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -602,7 +602,6 @@ virtio_dev_close(struct rte_eth_dev *dev)\n \tif (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)\n \t\tvtpci_irq_config(hw, VIRTIO_MSI_NO_VECTOR);\n \tvtpci_reset(hw);\n-\thw->started = 0;\n \tvirtio_dev_free_mbufs(dev);\n \tvirtio_free_queues(hw);\n }\n@@ -1345,17 +1344,14 @@ static int\n eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)\n {\n \tstruct rte_pci_device *pci_dev;\n-\tstruct virtio_hw *hw = eth_dev->data->dev_private;\n \n \tPMD_INIT_FUNC_TRACE();\n \n \tif (rte_eal_process_type() == RTE_PROC_SECONDARY)\n \t\treturn -EPERM;\n \n-\tif (hw->started == 1) {\n-\t\tvirtio_dev_stop(eth_dev);\n-\t\tvirtio_dev_close(eth_dev);\n-\t}\n+\tvirtio_dev_stop(eth_dev);\n+\tvirtio_dev_close(eth_dev);\n \tpci_dev = eth_dev->pci_dev;\n \n \teth_dev->dev_ops = NULL;\n@@ -1474,7 +1470,6 @@ static int\n virtio_dev_start(struct rte_eth_dev *dev)\n {\n \tuint16_t nb_queues, i;\n-\tstruct virtio_hw *hw = dev->data->dev_private;\n \tstruct virtnet_rx *rxvq;\n \tstruct virtnet_tx *txvq __rte_unused;\n \n@@ -1494,12 +1489,6 @@ virtio_dev_start(struct rte_eth_dev *dev)\n \t/* Initialize Link state */\n \tvirtio_dev_link_update(dev, 0);\n \n-\t/* On restart after stop do not touch queues */\n-\tif (hw->started)\n-\t\treturn 0;\n-\n-\thw->started = 1;\n-\n \t/*Notify the backend\n \t *Otherwise the tap backend might already stop its queue due to fullness.\n \t *vhost backend will have no chance to be waked up\ndiff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h\nindex f63f76c..de271bf 100644\n--- a/drivers/net/virtio/virtio_pci.h\n+++ b/drivers/net/virtio/virtio_pci.h\n@@ -252,7 +252,6 @@ struct virtio_hw {\n \tuint16_t vtnet_hdr_size;\n \tuint8_t\t vlan_strip;\n \tuint8_t\t use_msix;\n-\tuint8_t started;\n \tuint8_t modern;\n \tuint8_t use_simple_rxtx;\n \tuint8_t mac_addr[ETHER_ADDR_LEN];\n", "prefixes": [ "dpdk-dev", "v2", "08/10" ] }