Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/16944/?format=api
{ "id": 16944, "url": "https://patches.dpdk.org/api/patches/16944/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1478338865-26126-3-git-send-email-yuanhan.liu@linux.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1478338865-26126-3-git-send-email-yuanhan.liu@linux.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1478338865-26126-3-git-send-email-yuanhan.liu@linux.intel.com", "date": "2016-11-05T09:40:57", "name": "[dpdk-dev,v2,02/10] net/virtio: simplify queue memzone name", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "834a4fe17b69fd9bdc75cae4fea27e566bd96876", "submitter": { "id": 307, "url": "https://patches.dpdk.org/api/people/307/?format=api", "name": "Yuanhan Liu", "email": "yuanhan.liu@linux.intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1478338865-26126-3-git-send-email-yuanhan.liu@linux.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/16944/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/16944/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3B50E2BD0;\n\tSat, 5 Nov 2016 10:41:00 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 0233A137C\n\tfor <dev@dpdk.org>; Sat, 5 Nov 2016 10:40:18 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP; 05 Nov 2016 02:40:18 -0700", "from yliu-dev.sh.intel.com ([10.239.67.162])\n\tby fmsmga004.fm.intel.com with ESMTP; 05 Nov 2016 02:40:16 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,448,1473145200\"; d=\"scan'208\";a=\"187945073\"", "From": "Yuanhan Liu <yuanhan.liu@linux.intel.com>", "To": "dev@dpdk.org", "Cc": "Thomas Monjalon <thomas.monjalon@6wind.com>,\n\tTan Jianfeng <jianfeng.tan@intel.com>,\n\tKevin Traynor <ktraynor@redhat.com>, \n\tIlya Maximets <i.maximets@samsung.com>,\n\tKyle Larose <klarose@sandvine.com>, \n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tYuanhan Liu <yuanhan.liu@linux.intel.com>", "Date": "Sat, 5 Nov 2016 17:40:57 +0800", "Message-Id": "<1478338865-26126-3-git-send-email-yuanhan.liu@linux.intel.com>", "X-Mailer": "git-send-email 1.9.0", "In-Reply-To": "<1478338865-26126-1-git-send-email-yuanhan.liu@linux.intel.com>", "References": "<1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com>\n\t<1478338865-26126-1-git-send-email-yuanhan.liu@linux.intel.com>", "Subject": "[dpdk-dev] [PATCH v2 02/10] net/virtio: simplify queue memzone name", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of setting up a queue memzone name like \"port0_rxq0\", \"port0_txq0\",\nit could be simplified a bit to something like \"port0_vq0\", \"port0_vq1\" ...\n\nMeanwhile, the code is also simplified a bit.\n\nSigned-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 5815875..d082df5 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -312,7 +312,6 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,\n \tstruct virtnet_tx *txvq = NULL;\n \tstruct virtnet_ctl *cvq = NULL;\n \tstruct virtqueue *vq;\n-\tconst char *queue_names[] = {\"rvq\", \"txq\", \"cvq\"};\n \tsize_t sz_vq, sz_q = 0, sz_hdr_mz = 0;\n \tvoid *sw_ring = NULL;\n \tint ret;\n@@ -335,8 +334,8 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,\n \t\treturn -EINVAL;\n \t}\n \n-\tsnprintf(vq_name, sizeof(vq_name), \"port%d_%s%d\",\n-\t\t dev->data->port_id, queue_names[queue_type], queue_idx);\n+\tsnprintf(vq_name, sizeof(vq_name), \"port%d_vq%d\",\n+\t\t dev->data->port_id, vtpci_queue_idx);\n \n \tsz_vq = RTE_ALIGN_CEIL(sizeof(*vq) +\n \t\t\t\tvq_size * sizeof(struct vq_desc_extra),\n@@ -398,9 +397,8 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,\n \t\t (uint64_t)(uintptr_t)mz->addr);\n \n \tif (sz_hdr_mz) {\n-\t\tsnprintf(vq_hdr_name, sizeof(vq_hdr_name), \"port%d_%s%d_hdr\",\n-\t\t\t dev->data->port_id, queue_names[queue_type],\n-\t\t\t queue_idx);\n+\t\tsnprintf(vq_hdr_name, sizeof(vq_hdr_name), \"port%d_vq%d_hdr\",\n+\t\t\t dev->data->port_id, vtpci_queue_idx);\n \t\thdr_mz = rte_memzone_reserve_aligned(vq_hdr_name, sz_hdr_mz,\n \t\t\t\t\t\t socket_id, 0,\n \t\t\t\t\t\t RTE_CACHE_LINE_SIZE);\n", "prefixes": [ "dpdk-dev", "v2", "02/10" ] }