Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/16938/?format=api
{ "id": 16938, "url": "https://patches.dpdk.org/api/patches/16938/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1478238153-92544-1-git-send-email-jingjing.wu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1478238153-92544-1-git-send-email-jingjing.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1478238153-92544-1-git-send-email-jingjing.wu@intel.com", "date": "2016-11-04T05:42:33", "name": "[dpdk-dev] net/i40e: fix dcb configure failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c4573a44f21349462a9f8572046443f11b5472b0", "submitter": { "id": 47, "url": "https://patches.dpdk.org/api/people/47/?format=api", "name": "Jingjing Wu", "email": "jingjing.wu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1478238153-92544-1-git-send-email-jingjing.wu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/16938/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/16938/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 79D7B5581;\n\tFri, 4 Nov 2016 13:57:29 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 391FE3277\n\tfor <dev@dpdk.org>; Fri, 4 Nov 2016 13:57:27 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga104.fm.intel.com with ESMTP; 04 Nov 2016 05:57:28 -0700", "from dpdk2.sh.intel.com ([10.239.128.246])\n\tby orsmga004.jf.intel.com with ESMTP; 04 Nov 2016 05:57:25 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,443,1473145200\"; d=\"scan'208\";a=\"27771864\"", "From": "Jingjing Wu <jingjing.wu@intel.com>", "To": "dev@dpdk.org", "Cc": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\thelin.zhang@intel.com", "Date": "Fri, 4 Nov 2016 13:42:33 +0800", "Message-Id": "<1478238153-92544-1-git-send-email-jingjing.wu@intel.com>", "X-Mailer": "git-send-email 2.4.11", "Subject": "[dpdk-dev] [PATCH] net/i40e: fix dcb configure failure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Removing stopping LLDP in firmware is a workaround for a\nknown errata which can cause Rx hang. But the changing will\ncause DCB configuration fails. That is because when LLDP is\nenabled, the return value of i40e_init_dcb is success. But\nfollowing check just considered the case when LLDP agent\nis disabled.\nThis patch fixes this issue.\n\nFixes: fcbd40d4327b (\"net/i40e: fix Rx hang when disable LLDP\")\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex bb81b15..5afca1e 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -9428,12 +9428,12 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb)\n \t */\n \tif (sw_dcb == TRUE) {\n \t\tret = i40e_init_dcb(hw);\n-\t\t/* if sw_dcb, lldp agent is stopped, the return from\n+\t\t/* If lldp agent is stopped, the return value from\n \t\t * i40e_init_dcb we expect is failure with I40E_AQ_RC_EPERM\n-\t\t * adminq status.\n+\t\t * adminq status. Otherwise, it should return success.\n \t\t */\n-\t\tif (ret != I40E_SUCCESS &&\n-\t\t hw->aq.asq_last_status == I40E_AQ_RC_EPERM) {\n+\t\tif ((ret == I40E_SUCCESS) || (ret != I40E_SUCCESS &&\n+\t\t hw->aq.asq_last_status == I40E_AQ_RC_EPERM)) {\n \t\t\tmemset(&hw->local_dcbx_config, 0,\n \t\t\t\tsizeof(struct i40e_dcbx_config));\n \t\t\t/* set dcb default configuration */\n@@ -9462,8 +9462,8 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb)\n \t\t\t\treturn -ENOSYS;\n \t\t\t}\n \t\t} else {\n-\t\t\tPMD_INIT_LOG(ERR, \"DCBX configuration failed, err = %d,\"\n-\t\t\t\t\t \" aq_err = %d.\", ret,\n+\t\t\tPMD_INIT_LOG(ERR, \"DCB initialization in FW fails,\"\n+\t\t\t\t\t \" err = %d, aq_err = %d.\", ret,\n \t\t\t\t\t hw->aq.asq_last_status);\n \t\t\treturn -ENOTSUP;\n \t\t}\n", "prefixes": [ "dpdk-dev" ] }