Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/16936/?format=api
{ "id": 16936, "url": "https://patches.dpdk.org/api/patches/16936/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1478257688-25209-1-git-send-email-yuanhan.liu@linux.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1478257688-25209-1-git-send-email-yuanhan.liu@linux.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1478257688-25209-1-git-send-email-yuanhan.liu@linux.intel.com", "date": "2016-11-04T11:08:08", "name": "[dpdk-dev,RESEND,v2] net/i40e: fix floating VEB issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "93c6e5b643d6a428c668f98967cafdc58b6a8935", "submitter": { "id": 307, "url": "https://patches.dpdk.org/api/people/307/?format=api", "name": "Yuanhan Liu", "email": "yuanhan.liu@linux.intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1478257688-25209-1-git-send-email-yuanhan.liu@linux.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/16936/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/16936/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E64B3152A;\n\tFri, 4 Nov 2016 12:07:19 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 600B636E\n\tfor <dev@dpdk.org>; Fri, 4 Nov 2016 12:07:18 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga103.jf.intel.com with ESMTP; 04 Nov 2016 04:07:17 -0700", "from yliu-dev.sh.intel.com ([10.239.67.162])\n\tby fmsmga001.fm.intel.com with ESMTP; 04 Nov 2016 04:07:16 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.31,442,1473145200\"; d=\"scan'208\";\n\ta=\"1063881550\"", "From": "Yuanhan Liu <yuanhan.liu@linux.intel.com>", "To": "dev@dpdk.org", "Cc": "Jingjing Wu <jingjing.wu@intel.com>, Yu Liu <yu.y.liu@intel.com>,\n\tBeilei Xing <beilei.xing@intel.com>", "Date": "Fri, 4 Nov 2016 19:08:08 +0800", "Message-Id": "<1478257688-25209-1-git-send-email-yuanhan.liu@linux.intel.com>", "X-Mailer": "git-send-email 1.9.0", "In-Reply-To": "<20161104110129.GZ16751@yliu-dev.sh.intel.com>", "References": "<20161104110129.GZ16751@yliu-dev.sh.intel.com>", "Subject": "[dpdk-dev] [PATCH RESEND v2] net/i40e: fix floating VEB issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Beilei Xing <beilei.xing@intel.com>\n\nTurning off S-TAG identification will impact floating VEB,\nVFs can't communicate with each other.\nThis patch fixes this issue by judging whether floating\nVEB is enabled, S-TAG identification will be turned off\nonly when floating VEB is disabled.\n\nFixes: 4d61120d5ce7 (\"net/i40e: fix dropping packets with ethertype 0x88A8\")\n\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\nAcked-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n v2 changes:\n * Modify the limitation description in i40e.rst\n\n :: Seems that Beilei failed to send this patches out. While I have sent out few\n :: patches out successfully, I'm sending it for her.\n\n doc/guides/nics/i40e.rst | 6 ++++++\n drivers/net/i40e/i40e_ethdev.c | 12 +++++++-----\n 2 files changed, 13 insertions(+), 5 deletions(-)", "diff": "diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst\nindex c0163fc..5780268 100644\n--- a/doc/guides/nics/i40e.rst\n+++ b/doc/guides/nics/i40e.rst\n@@ -453,3 +453,9 @@ To work around this issue, ``ethtool -s <dev> autoneg on`` should be\n set first and then the link can be brought up through ``ifconfig <dev> up``.\n \n NOTE: requires Linux kernel i40e driver version >= 1.4.X\n+\n+Receive packets with Ethertype 0x88A8\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+Due to the FW limitation, PF can receive packets with Ethertype 0x88A8\n+only when floating VEB is disabled.\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex bb81b15..631a93f 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1121,11 +1121,13 @@ eth_i40e_dev_init(struct rte_eth_dev *dev)\n \t/* Disable double vlan by default */\n \ti40e_vsi_config_double_vlan(vsi, FALSE);\n \n-\t/* Disable S-TAG identification by default */\n-\tret = I40E_READ_REG(hw, I40E_PRT_L2TAGSEN);\n-\tif (ret & I40E_L2_TAGS_S_TAG_MASK) {\n-\t\tret &= ~I40E_L2_TAGS_S_TAG_MASK;\n-\t\tI40E_WRITE_REG(hw, I40E_PRT_L2TAGSEN, ret);\n+\t/* Disable S-TAG identification when floating_veb is disabled */\n+\tif (!pf->floating_veb) {\n+\t\tret = I40E_READ_REG(hw, I40E_PRT_L2TAGSEN);\n+\t\tif (ret & I40E_L2_TAGS_S_TAG_MASK) {\n+\t\t\tret &= ~I40E_L2_TAGS_S_TAG_MASK;\n+\t\t\tI40E_WRITE_REG(hw, I40E_PRT_L2TAGSEN, ret);\n+\t\t}\n \t}\n \n \tif (!vsi->max_macaddrs)\n", "prefixes": [ "dpdk-dev", "RESEND", "v2" ] }