Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 16732,
    "url": "https://patches.dpdk.org/api/patches/16732/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1476970481-21034-1-git-send-email-daniels@research.att.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1476970481-21034-1-git-send-email-daniels@research.att.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1476970481-21034-1-git-send-email-daniels@research.att.com",
    "date": "2016-10-20T13:34:41",
    "name": "[dpdk-dev,v2] lib/ether: prevent duplicate callback on list",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "48c5d671b92f27c8f73e9ed187b2f10a4e406e1b",
    "submitter": {
        "id": 588,
        "url": "https://patches.dpdk.org/api/people/588/?format=api",
        "name": "Scott Daniels",
        "email": "daniels@research.att.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1476970481-21034-1-git-send-email-daniels@research.att.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/16732/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/16732/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B73582A5E;\n\tThu, 20 Oct 2016 15:36:00 +0200 (CEST)",
            "from mx0a-00191d01.pphosted.com (mx0b-00191d01.pphosted.com\n\t[67.231.157.136]) by dpdk.org (Postfix) with ESMTP id C2AB629CD\n\tfor <dev@dpdk.org>; Thu, 20 Oct 2016 15:35:58 +0200 (CEST)",
            "from pps.filterd (m0083689.ppops.net [127.0.0.1])\n\tby m0083689.ppops.net-00191d01. (8.16.0.17/8.16.0.17) with SMTP id\n\tu9KDZbqn039689; Thu, 20 Oct 2016 09:35:58 -0400",
            "from alpi155.enaf.aldc.att.com (sbcsmtp7.sbc.com [144.160.229.24])\n\tby m0083689.ppops.net-00191d01. with ESMTP id 266xq18v31-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Thu, 20 Oct 2016 09:35:57 -0400",
            "from enaf.aldc.att.com (localhost [127.0.0.1])\n\tby alpi155.enaf.aldc.att.com (8.14.5/8.14.5) with ESMTP id\n\tu9KDZuNe015506; Thu, 20 Oct 2016 09:35:56 -0400",
            "from mlpi407.sfdc.sbc.com (mlpi407.sfdc.sbc.com [130.9.128.239])\n\tby alpi155.enaf.aldc.att.com (8.14.5/8.14.5) with ESMTP id\n\tu9KDZnl1015381\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Thu, 20 Oct 2016 09:35:51 -0400",
            "from clpi183.sldc.sbc.com (clpi183.sldc.sbc.com [135.41.1.46]) by\n\tmlpi407.sfdc.sbc.com (RSA Interceptor);\n\tThu, 20 Oct 2016 13:35:37 GMT",
            "from sldc.sbc.com (localhost [127.0.0.1])\n\tby clpi183.sldc.sbc.com (8.14.5/8.14.5) with ESMTP id u9KDZ5bP017903; \n\tThu, 20 Oct 2016 08:35:06 -0500",
            "from mail-green.research.att.com (mail-green.research.att.com\n\t[135.207.255.15])\n\tby clpi183.sldc.sbc.com (8.14.5/8.14.5) with ESMTP id u9KDZ24n017624; \n\tThu, 20 Oct 2016 08:35:02 -0500",
            "from cheetah.research.att.com (mt-230-10.research.att.com\n\t[135.207.230.10])\n\tby mail-green.research.att.com (Postfix) with ESMTP id BD138E292E;\n\tThu, 20 Oct 2016 09:34:51 -0400 (EDT)"
        ],
        "From": "\"E. Scott Daniels\" <daniels@research.att.com>",
        "To": "helin.zhang@intel.com, bernard.iremonger@intel.com",
        "Cc": "dev@dpdk.org, az5157@att.com,\n\t\"E. Scott Daniels\" <daniels@research.att.com>",
        "Date": "Thu, 20 Oct 2016 09:34:41 -0400",
        "Message-Id": "<1476970481-21034-1-git-send-email-daniels@research.att.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "X-RSA-Inspected": "yes",
        "X-RSA-Classifications": "public",
        "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2016-10-20_07:, , signatures=0",
        "X-Proofpoint-Spam-Details": "rule=outbound_policy_notspam\n\tpolicy=outbound_policy score=0\n\tpriorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0\n\tbulkscore=0\n\tspamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0\n\tadultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1609300000\n\tdefinitions=main-1610200243",
        "Subject": "[dpdk-dev] [PATCH v2] lib/ether: prevent duplicate callback on list",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This change prevents the attempt to add a structure which is\nalready on the callback list. If a struct with matching\nparameters is found on the list, then no action is taken. If\na struct with matching parameters is found on the list, then\nno action is taken.\n\nFixes: ac2f69c (\"ethdev: fix crash if malloc of user callback fails\")\n\nSigned-off-by: E. Scott Daniels <daniels@research.att.com>\n---\n\nV2:\n* Correct the component name; changed from net/ixgbe.\n* Add Fixes tag.\n* Acked-by: Wenzhuo Lu <Wenzhuo.lu@intel.com>\n\n lib/librte_ether/rte_ethdev.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 0d9d9c1..fde8112 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -2449,14 +2449,15 @@ rte_eth_dev_callback_register(uint8_t port_id,\n \t}\n \n \t/* create a new callback. */\n-\tif (user_cb == NULL)\n+\tif (user_cb == NULL) {\n \t\tuser_cb = rte_zmalloc(\"INTR_USER_CALLBACK\",\n \t\t\t\t\tsizeof(struct rte_eth_dev_callback), 0);\n-\tif (user_cb != NULL) {\n-\t\tuser_cb->cb_fn = cb_fn;\n-\t\tuser_cb->cb_arg = cb_arg;\n-\t\tuser_cb->event = event;\n-\t\tTAILQ_INSERT_TAIL(&(dev->link_intr_cbs), user_cb, next);\n+\t\tif (user_cb != NULL) {\n+\t\t\tuser_cb->cb_fn = cb_fn;\n+\t\t\tuser_cb->cb_arg = cb_arg;\n+\t\t\tuser_cb->event = event;\n+\t\t\tTAILQ_INSERT_TAIL(&(dev->link_intr_cbs), user_cb, next);\n+\t\t}\n \t}\n \n \trte_spinlock_unlock(&rte_eth_dev_cb_lock);\n",
    "prefixes": [
        "dpdk-dev",
        "v2"
    ]
}