Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/15463/?format=api
{ "id": 15463, "url": "https://patches.dpdk.org/api/patches/15463/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1472279367-25042-10-git-send-email-rasesh.mody@qlogic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1472279367-25042-10-git-send-email-rasesh.mody@qlogic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1472279367-25042-10-git-send-email-rasesh.mody@qlogic.com", "date": "2016-08-27T06:29:25", "name": "[dpdk-dev,15/17] qede: fix driver version string", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f9545f1d925749535bf57fe4d7a3febd0ef5827e", "submitter": { "id": 325, "url": "https://patches.dpdk.org/api/people/325/?format=api", "name": "Rasesh Mody", "email": "rasesh.mody@qlogic.com" }, "delegate": { "id": 10, "url": "https://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1472279367-25042-10-git-send-email-rasesh.mody@qlogic.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/15463/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/15463/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 31BB95927;\n\tSat, 27 Aug 2016 08:30:11 +0200 (CEST)", "from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com\n\t[67.231.156.153]) by dpdk.org (Postfix) with ESMTP id 5ADC1590E\n\tfor <dev@dpdk.org>; Sat, 27 Aug 2016 08:30:09 +0200 (CEST)", "from pps.filterd (m0085408.ppops.net [127.0.0.1])\n\tby mx0b-0016ce01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id\n\tu7R6RRHV024695 for <dev@dpdk.org>; Fri, 26 Aug 2016 23:30:08 -0700", "from avcashub1.qlogic.com ([198.186.0.117])\n\tby mx0b-0016ce01.pphosted.com with ESMTP id 250fja6nbt-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT)\n\tfor <dev@dpdk.org>; Fri, 26 Aug 2016 23:30:08 -0700", "from avluser05.qlc.com (10.1.113.115) by qlc.com (10.1.4.192) with\n\tMicrosoft SMTP Server id 14.3.235.1;\n\tFri, 26 Aug 2016 23:30:07 -0700", "(from rmody@localhost)\tby avluser05.qlc.com (8.14.4/8.14.4/Submit)\n\tid u7R6U70R025125;\tFri, 26 Aug 2016 23:30:07 -0700" ], "X-Authentication-Warning": "avluser05.qlc.com: rmody set sender to\n\trasesh.mody@qlogic.com using -f", "From": "Rasesh Mody <rasesh.mody@qlogic.com>", "To": "<dev@dpdk.org>", "CC": "<Dept-EngDPDKDev@qlogic.com>, Harish Patil <harish.patil@qlogic.com>", "Date": "Fri, 26 Aug 2016 23:29:25 -0700", "Message-ID": "<1472279367-25042-10-git-send-email-rasesh.mody@qlogic.com>", "X-Mailer": "git-send-email 1.7.10.3", "In-Reply-To": "<1472279367-25042-1-git-send-email-rasesh.mody@qlogic.com>", "References": "<1472279367-25042-1-git-send-email-rasesh.mody@qlogic.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "disclaimer": "bypass", "X-Proofpoint-Virus-Version": "vendor=nai engine=5800 definitions=8269\n\tsignatures=670749", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0\n\tpriorityscore=1501 suspectscore=1\n\tmalwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015\n\timpostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1604210000\n\tdefinitions=main-1608270068", "Subject": "[dpdk-dev] [PATCH 15/17] qede: fix driver version string", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Harish Patil <harish.patil@qlogic.com>\n\nThis patch fixes the base driver version display.\nThe driver version notation is:\n<Base-Version_PMD-Version>\n\nFixes: 2ea6f76 (\"qede: add core driver\")\n\nSigned-off-by: Harish Patil <harish.patil@qlogic.com>\n---\n drivers/net/qede/qede_ethdev.c | 43 ++++++++++++++++++++--------------------\n drivers/net/qede/qede_ethdev.h | 17 ++++++++--------\n drivers/net/qede/qede_if.h | 3 +--\n drivers/net/qede/qede_main.c | 4 ++--\n 4 files changed, 32 insertions(+), 35 deletions(-)", "diff": "diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex b9677cc..2778d3b 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -8,6 +8,7 @@\n \n #include \"qede_ethdev.h\"\n #include <rte_alarm.h>\n+#include <rte_version.h>\n \n /* Globals */\n static const struct qed_eth_ops *qed_ops;\n@@ -188,31 +189,28 @@ static void qede_print_adapter_info(struct qede_dev *qdev)\n {\n \tstruct ecore_dev *edev = &qdev->edev;\n \tstruct qed_dev_info *info = &qdev->dev_info.common;\n-\tstatic char ver_str[QED_DRV_VER_STR_SIZE];\n+\tstatic char drv_ver[QEDE_PMD_DRV_VER_STR_SIZE];\n+\tstatic char ver_str[QEDE_PMD_DRV_VER_STR_SIZE];\n \n \tDP_INFO(edev, \"*********************************\\n\");\n+\tDP_INFO(edev, \" DPDK version:%s\\n\", rte_version());\n \tDP_INFO(edev, \" Chip details : %s%d\\n\",\n-\t\tECORE_IS_BB(edev) ? \"BB\" : \"AH\",\n-\t\tCHIP_REV_IS_A0(edev) ? 0 : 1);\n-\n-\tsprintf(ver_str, \"%s %s_%d.%d.%d.%d\", QEDE_PMD_VER_PREFIX,\n-\t\tedev->ver_str, QEDE_PMD_VERSION_MAJOR, QEDE_PMD_VERSION_MINOR,\n-\t\tQEDE_PMD_VERSION_REVISION, QEDE_PMD_VERSION_PATCH);\n-\tstrcpy(qdev->drv_ver, ver_str);\n-\tDP_INFO(edev, \" Driver version : %s\\n\", ver_str);\n-\n-\tsprintf(ver_str, \"%d.%d.%d.%d\", info->fw_major, info->fw_minor,\n-\t\tinfo->fw_rev, info->fw_eng);\n+\t\t ECORE_IS_BB(edev) ? \"BB\" : \"AH\",\n+\t\t CHIP_REV_IS_A0(edev) ? 0 : 1);\n+\tsnprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, \"%d.%d.%d.%d\",\n+\t\t info->fw_major, info->fw_minor, info->fw_rev, info->fw_eng);\n+\tsnprintf(drv_ver, QEDE_PMD_DRV_VER_STR_SIZE, \"%s_%s\",\n+\t\t ver_str, QEDE_PMD_VERSION);\n+\tDP_INFO(edev, \" Driver version : %s\\n\", drv_ver);\n \tDP_INFO(edev, \" Firmware version : %s\\n\", ver_str);\n \n-\tsprintf(ver_str, \"%d.%d.%d.%d\",\n+\tsnprintf(ver_str, MCP_DRV_VER_STR_SIZE,\n+\t\t \"%d.%d.%d.%d\",\n \t\t(info->mfw_rev >> 24) & 0xff,\n \t\t(info->mfw_rev >> 16) & 0xff,\n \t\t(info->mfw_rev >> 8) & 0xff, (info->mfw_rev) & 0xff);\n-\tDP_INFO(edev, \" Management firmware version : %s\\n\", ver_str);\n-\n+\tDP_INFO(edev, \" Management Firmware version : %s\\n\", ver_str);\n \tDP_INFO(edev, \" Firmware file : %s\\n\", fw_file);\n-\n \tDP_INFO(edev, \"*********************************\\n\");\n }\n \n@@ -1349,11 +1347,12 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)\n \t/* Start the Slowpath-process */\n \tmemset(¶ms, 0, sizeof(struct qed_slowpath_params));\n \tparams.int_mode = ECORE_INT_MODE_MSIX;\n-\tparams.drv_major = QEDE_MAJOR_VERSION;\n-\tparams.drv_minor = QEDE_MINOR_VERSION;\n-\tparams.drv_rev = QEDE_REVISION_VERSION;\n-\tparams.drv_eng = QEDE_ENGINEERING_VERSION;\n-\tstrncpy((char *)params.name, \"qede LAN\", QED_DRV_VER_STR_SIZE);\n+\tparams.drv_major = QEDE_PMD_VERSION_MAJOR;\n+\tparams.drv_minor = QEDE_PMD_VERSION_MINOR;\n+\tparams.drv_rev = QEDE_PMD_VERSION_REVISION;\n+\tparams.drv_eng = QEDE_PMD_VERSION_PATCH;\n+\tstrncpy((char *)params.name, QEDE_PMD_VER_PREFIX,\n+\t\tQEDE_PMD_DRV_VER_STR_SIZE);\n \n \t/* For CMT mode device do periodic polling for slowpath events.\n \t * This is required since uio device uses only one MSI-x\n@@ -1390,7 +1389,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)\n \n \tqede_alloc_etherdev(adapter, &dev_info);\n \n-\tadapter->ops->common->set_id(edev, edev->name, QEDE_DRV_MODULE_VERSION);\n+\tadapter->ops->common->set_id(edev, edev->name, QEDE_PMD_VERSION);\n \n \tif (!is_vf)\n \t\tadapter->dev_info.num_mac_addrs =\ndiff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h\nindex d1daa44..7453539 100644\n--- a/drivers/net/qede/qede_ethdev.h\n+++ b/drivers/net/qede/qede_ethdev.h\n@@ -46,15 +46,14 @@\n #define QEDE_PMD_VERSION_REVISION 0\n #define QEDE_PMD_VERSION_PATCH\t 1\n \n-#define QEDE_MAJOR_VERSION\t\t8\n-#define QEDE_MINOR_VERSION\t\t7\n-#define QEDE_REVISION_VERSION\t\t9\n-#define QEDE_ENGINEERING_VERSION\t0\n+#define QEDE_PMD_VERSION qede_stringify(QEDE_PMD_VERSION_MAJOR) \".\" \\\n+\t\t\t qede_stringify(QEDE_PMD_VERSION_MINOR) \".\" \\\n+\t\t\t qede_stringify(QEDE_PMD_VERSION_REVISION) \".\" \\\n+\t\t\t qede_stringify(QEDE_PMD_VERSION_PATCH)\n+\n+#define QEDE_PMD_DRV_VER_STR_SIZE NAME_SIZE\n+#define QEDE_PMD_VER_PREFIX \"QEDE PMD\"\n \n-#define QEDE_DRV_MODULE_VERSION qede_stringify(QEDE_MAJOR_VERSION) \".\"\t\\\n-\t\tqede_stringify(QEDE_MINOR_VERSION) \".\"\t\t\t\\\n-\t\tqede_stringify(QEDE_REVISION_VERSION) \".\"\t\t\\\n-\t\tqede_stringify(QEDE_ENGINEERING_VERSION)\n \n #define QEDE_RSS_INDIR_INITED (1 << 0)\n #define QEDE_RSS_KEY_INITED (1 << 1)\n@@ -149,7 +148,7 @@ struct qede_dev {\n \tbool accept_any_vlan;\n \tstruct ether_addr primary_mac;\n \tbool handle_hw_err;\n-\tchar drv_ver[QED_DRV_VER_STR_SIZE];\n+\tchar drv_ver[QEDE_PMD_DRV_VER_STR_SIZE];\n };\n \n /* Static functions */\ndiff --git a/drivers/net/qede/qede_if.h b/drivers/net/qede/qede_if.h\nindex 935eed8..2d38b1b 100644\n--- a/drivers/net/qede/qede_if.h\n+++ b/drivers/net/qede/qede_if.h\n@@ -76,14 +76,13 @@ struct qed_link_output {\n \tuint32_t pause_config;\n };\n \n-#define QED_DRV_VER_STR_SIZE 80\n struct qed_slowpath_params {\n \tuint32_t int_mode;\n \tuint8_t drv_major;\n \tuint8_t drv_minor;\n \tuint8_t drv_rev;\n \tuint8_t drv_eng;\n-\tuint8_t name[QED_DRV_VER_STR_SIZE];\n+\tuint8_t name[NAME_SIZE];\n };\n \n #define ILT_PAGE_SIZE_TCFC 0x8000\t/* 32KB */\ndiff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c\nindex c7a7159..0b5513c 100644\n--- a/drivers/net/qede/qede_main.c\n+++ b/drivers/net/qede/qede_main.c\n@@ -408,7 +408,7 @@ qed_fill_eth_dev_info(struct ecore_dev *edev, struct qed_dev_eth_info *info)\n \n static void\n qed_set_id(struct ecore_dev *edev, char name[NAME_SIZE],\n-\t const char ver_str[VER_SIZE])\n+\t const char ver_str[NAME_SIZE])\n {\n \tint i;\n \n@@ -416,7 +416,7 @@ qed_set_id(struct ecore_dev *edev, char name[NAME_SIZE],\n \tfor_each_hwfn(edev, i) {\n \t\tsnprintf(edev->hwfns[i].name, NAME_SIZE, \"%s-%d\", name, i);\n \t}\n-\trte_memcpy(edev->ver_str, ver_str, VER_SIZE);\n+\tmemcpy(edev->ver_str, ver_str, NAME_SIZE);\n \tedev->drv_type = DRV_ID_DRV_TYPE_LINUX;\n }\n \n", "prefixes": [ "dpdk-dev", "15/17" ] }