Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/15052/?format=api
{ "id": 15052, "url": "https://patches.dpdk.org/api/patches/15052/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1469797306-14527-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1469797306-14527-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1469797306-14527-1-git-send-email-thomas.monjalon@6wind.com", "date": "2016-07-29T13:01:46", "name": "[dpdk-dev] log: remove history dump", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9c240e3e869a1380e655f671c8ace413efe57c78", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1469797306-14527-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/15052/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/15052/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id F1228559C;\n\tFri, 29 Jul 2016 15:01:52 +0200 (CEST)", "from mail-wm0-f46.google.com (mail-wm0-f46.google.com\n\t[74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 6EC0C5580\n\tfor <dev@dpdk.org>; Fri, 29 Jul 2016 15:01:52 +0200 (CEST)", "by mail-wm0-f46.google.com with SMTP id q128so289225237wma.1\n\tfor <dev@dpdk.org>; Fri, 29 Jul 2016 06:01:52 -0700 (PDT)", "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\tex14sm65900wjc.30.2016.07.29.06.01.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 29 Jul 2016 06:01:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=DH7Jx16kvWpMcrz8HYlJ5HmYP9l41M9Sp8NWqnI7564=;\n\tb=cXHJPqhVq9xxDNZiUnObpVb6IPOSIYxbxFlY1k5ausGAoNgoYc7NZOkm1z2STeRP6k\n\tQBEUEAokteSQ2jNTd7z/VX3TlGywaHTpJpC3Q3NQABD8RHP6BO5N0wlgS0YS+chaGB0c\n\tmMn8I+vlMNTIXx3oPFUzhHhwdTBbiMdDggT7sO329Aq+9NZNjOi3U6sifAQklYDsBnOs\n\tFaHwsH1cPfM7PA0cZrxhSZxyhY97N8XbSZTQCghLL+l8mX/VD7vkshzjP5Ew8gZ8Fvs6\n\tSKcghSirHk8JDtsMRtolH+M1Pp9reOWLaJJMuPQfNY6z+o1sSWQsBh5PhQKDyN5ZfmXN\n\tQYEw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=DH7Jx16kvWpMcrz8HYlJ5HmYP9l41M9Sp8NWqnI7564=;\n\tb=PIhflKyeMfqfSSVn5Gkni25rQL4b8Pa+xi1Lr7/JYsaMqe4CmkUk060O7nQFEJyTYE\n\t4Q84QKojYSTivWWkcUb/ltne1mh9hQmWqDC9u7I8oH78RyqNpIzHcHB4o+RVuVfTPscR\n\tEI021SZxzQy+pPeWJ1wTP7qxR22/N+YVgj8bOFaoOc8ewKofyIagQPivZYEOjRRInPFy\n\thQq1EKMQbxj4lw8W9P8nnsB/UDVqxke938f/Ev2jluEDDKdGvDjTGyQKnOppAtfglbNy\n\tCOzOpfMKgwLG8EFvHJqv+RoyVRoSBmvNhJsAJO5yiPBYg8SU+Wjm9GaCUUm70270xhzN\n\tqWlQ==", "X-Gm-Message-State": "AEkoout1fYbfPErVGIJUftw6mKgq/RrmsfYwqYpfJVa6VGdF9WgWL6AT7b8YPA6vkNWT9f1B", "X-Received": "by 10.28.227.11 with SMTP id a11mr44892020wmh.29.1469797312069; \n\tFri, 29 Jul 2016 06:01:52 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "david.marchand@6wind.com", "Cc": "dev@dpdk.org", "Date": "Fri, 29 Jul 2016 15:01:46 +0200", "Message-Id": "<1469797306-14527-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "Subject": "[dpdk-dev] [PATCH] log: remove history dump", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The log history feature was deprecated in 16.07.\nThe remaining empty functions are removed in 16.11.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n doc/guides/rel_notes/deprecation.rst | 3 ---\n doc/guides/rel_notes/release_16_11.rst | 4 +++-\n lib/librte_eal/common/eal_common_log.c | 19 ---------------\n lib/librte_eal/common/include/rte_log.h | 41 ---------------------------------\n 4 files changed, 3 insertions(+), 64 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex d2dc4a9..1b953fe 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -8,9 +8,6 @@ API and ABI deprecation notices are to be posted here.\n Deprecation Notices\n -------------------\n \n-* The log history is deprecated.\n- It is voided in 16.07 and will be removed in release 16.11.\n-\n * The ethdev library file will be renamed from libethdev.* to librte_ethdev.*\n in release 16.11 in order to have a more consistent namespace.\n \ndiff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst\nindex a6e3307..0b9022d 100644\n--- a/doc/guides/rel_notes/release_16_11.rst\n+++ b/doc/guides/rel_notes/release_16_11.rst\n@@ -94,6 +94,8 @@ API Changes\n \n This section is a comment. Make sure to start the actual text at the margin.\n \n+* The log history is removed.\n+\n \n ABI Changes\n -----------\n@@ -131,7 +133,7 @@ The libraries prepended with a plus sign were incremented in this version.\n librte_cmdline.so.2\n librte_cryptodev.so.1\n librte_distributor.so.1\n- librte_eal.so.2\n+ + librte_eal.so.3\n librte_hash.so.2\n librte_ip_frag.so.1\n librte_ivshmem.so.1\ndiff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c\nindex 7916c78..967991a 100644\n--- a/lib/librte_eal/common/eal_common_log.c\n+++ b/lib/librte_eal/common/eal_common_log.c\n@@ -64,19 +64,6 @@ static RTE_DEFINE_PER_LCORE(struct log_cur_msg, log_cur_msg);\n \n /* default logs */\n \n-int\n-rte_log_add_in_history(const char *buf __rte_unused, size_t size __rte_unused)\n-{\n-\treturn 0;\n-}\n-\n-void\n-rte_log_set_history(int enable)\n-{\n-\tif (enable)\n-\t\tRTE_LOG(WARNING, EAL, \"The log history is deprecated.\\n\");\n-}\n-\n /* Change the stream that will be used by logging system */\n int\n rte_openlog_stream(FILE *f)\n@@ -131,12 +118,6 @@ int rte_log_cur_msg_logtype(void)\n \treturn RTE_PER_LCORE(log_cur_msg).logtype;\n }\n \n-/* Dump log history to file */\n-void\n-rte_log_dump_history(FILE *out __rte_unused)\n-{\n-}\n-\n /*\n * Generates a log message The message will be sent in the stream\n * defined by the previous call to rte_openlog_stream().\ndiff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h\nindex b1add04..919563c 100644\n--- a/lib/librte_eal/common/include/rte_log.h\n+++ b/lib/librte_eal/common/include/rte_log.h\n@@ -42,8 +42,6 @@\n * This file provides a log API to RTE applications.\n */\n \n-#include \"rte_common.h\" /* for __rte_deprecated macro */\n-\n #ifdef __cplusplus\n extern \"C\" {\n #endif\n@@ -181,45 +179,6 @@ int rte_log_cur_msg_loglevel(void);\n int rte_log_cur_msg_logtype(void);\n \n /**\n- * @deprecated\n- * Enable or disable the history (enabled by default)\n- *\n- * @param enable\n- * true to enable, or 0 to disable history.\n- */\n-__rte_deprecated\n-void rte_log_set_history(int enable);\n-\n-/**\n- * @deprecated\n- * Dump the log history to a file\n- *\n- * @param f\n- * A pointer to a file for output\n- */\n-__rte_deprecated\n-void rte_log_dump_history(FILE *f);\n-\n-/**\n- * @deprecated\n- * Add a log message to the history.\n- *\n- * This function can be called from a user-defined log stream. It adds\n- * the given message in the history that can be dumped using\n- * rte_log_dump_history().\n- *\n- * @param buf\n- * A data buffer containing the message to be saved in the history.\n- * @param size\n- * The length of the data buffer.\n- * @return\n- * - 0: Success.\n- * - (-ENOBUFS) if there is no room to store the message.\n- */\n-__rte_deprecated\n-int rte_log_add_in_history(const char *buf, size_t size);\n-\n-/**\n * Generates a log message.\n *\n * The message will be sent in the stream defined by the previous call\n", "prefixes": [ "dpdk-dev" ] }