Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14593/?format=api
{ "id": 14593, "url": "https://patches.dpdk.org/api/patches/14593/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1467796386-20291-1-git-send-email-christian.ehrhardt@canonical.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1467796386-20291-1-git-send-email-christian.ehrhardt@canonical.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1467796386-20291-1-git-send-email-christian.ehrhardt@canonical.com", "date": "2016-07-06T09:13:06", "name": "[dpdk-dev,v4] mk: filter duplicate configuration entries", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "96d80186bf58746c6962bd89f67041f024868af4", "submitter": { "id": 382, "url": "https://patches.dpdk.org/api/people/382/?format=api", "name": "Christian Ehrhardt", "email": "christian.ehrhardt@canonical.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1467796386-20291-1-git-send-email-christian.ehrhardt@canonical.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/14593/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/14593/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id BBBD369FF;\n\tWed, 6 Jul 2016 11:13:11 +0200 (CEST)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 51AC969FE\n\tfor <dev@dpdk.org>; Wed, 6 Jul 2016 11:13:11 +0200 (CEST)", "from 1.general.paelzer.uk.vpn ([10.172.196.172]\n\thelo=localhost.localdomain)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from <christian.ehrhardt@canonical.com>)\n\tid 1bKitJ-0007ec-6T; Wed, 06 Jul 2016 09:13:09 +0000" ], "From": "Christian Ehrhardt <christian.ehrhardt@canonical.com>", "To": "christian.ehrhardt@canonical.com, ferruh.yigit@intel.com,\n\tthomas.monjalon@6wind.com, dev@dpdk.org", "Date": "Wed, 6 Jul 2016 11:13:06 +0200", "Message-Id": "<1467796386-20291-1-git-send-email-christian.ehrhardt@canonical.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<CAATJJ0+sK1xrY4DgdUVH8MjmChdt5=dSFQEXTjhiG3HOOgdMEw@mail.gmail.com>", "References": "<CAATJJ0+sK1xrY4DgdUVH8MjmChdt5=dSFQEXTjhiG3HOOgdMEw@mail.gmail.com>", "Subject": "[dpdk-dev] [PATCH v4] mk: filter duplicate configuration entries", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "*updates in v4*\n- replace awk usage with sed\n- re-add the old loop to be able to get rid of awk\n- add more explanation to the header of the makefile section\n\n*updates in v3*\n- replace tac with sed '1!G;h;$!d' to avoid build time dependency\n\n*updates in v2*\n- move to .config target\n- fix usage order of tac\n- simplify inner section by only using awk (instead of awk+loop+bash+sed)\n\nDue to the hierarchy and the demand to keep the base config showing all\noptions, some config keys end up multiple times in the .config file.\n\nDue to the way the actual config is sourced only the last entry is\nimportant. That can confuse people changing values in .config which\nare then ignored.\n\nA suggested solution was to filter for duplicates at the end of the\nactual config step which is implemented here.\n\nSigned-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>\n---\n mk/rte.sdkconfig.mk | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk\nindex a3acfe6..70c59d6 100644\n--- a/mk/rte.sdkconfig.mk\n+++ b/mk/rte.sdkconfig.mk\n@@ -79,11 +79,20 @@ $(RTE_OUTPUT):\n ifdef NODOTCONF\n $(RTE_OUTPUT)/.config: ;\n else\n+# Generate config from template, if there are duplicates keep only the last.\n+# To do so the temp config is checked for duplicate keys with cut/sort/uniq\n+# Then for each of those identified duplicates as long as there are more than\n+# just one left the last match is removed.\n $(RTE_OUTPUT)/.config: $(RTE_CONFIG_TEMPLATE) FORCE | $(RTE_OUTPUT)\n \t$(Q)if [ \"$(RTE_CONFIG_TEMPLATE)\" != \"\" -a -f \"$(RTE_CONFIG_TEMPLATE)\" ]; then \\\n \t\t$(CPP) -undef -P -x assembler-with-cpp \\\n \t\t-ffreestanding \\\n \t\t-o $(RTE_OUTPUT)/.config_tmp $(RTE_CONFIG_TEMPLATE) ; \\\n+\t\tfor config in $$(grep -v \"^#\" $(RTE_OUTPUT)/.config_tmp | cut -d\"=\" -f1 | sort | uniq -d); do \\\n+\t\t\twhile [ $$(grep \"^$${config}=\" $(RTE_OUTPUT)/.config_tmp -c ) -gt 1 ]; do \\\n+\t\t\t\tsed -i \"0,/^$${config}=/{//d}\" $(RTE_OUTPUT)/.config_tmp; \\\n+\t\t\tdone; \\\n+\t\tdone; \\\n \t\tif ! cmp -s $(RTE_OUTPUT)/.config_tmp $(RTE_OUTPUT)/.config; then \\\n \t\t\tcp $(RTE_OUTPUT)/.config_tmp $(RTE_OUTPUT)/.config ; \\\n \t\t\tcp $(RTE_OUTPUT)/.config_tmp $(RTE_OUTPUT)/.config.orig ; \\\n", "prefixes": [ "dpdk-dev", "v4" ] }