Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1453/?format=api
{ "id": 1453, "url": "https://patches.dpdk.org/api/patches/1453/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1416692622-28886-5-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1416692622-28886-5-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1416692622-28886-5-git-send-email-thomas.monjalon@6wind.com", "date": "2014-11-22T21:43:36", "name": "[dpdk-dev,04/10] eal: factorize internal config reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9661e050b59474baf128022b4c5bb2804e9c8f3c", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1416692622-28886-5-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1453/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1453/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C25ED7FB8;\n\tSat, 22 Nov 2014 22:33:47 +0100 (CET)", "from mail-wg0-f48.google.com (mail-wg0-f48.google.com\n\t[74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 403DC7F94\n\tfor <dev@dpdk.org>; Sat, 22 Nov 2014 22:33:42 +0100 (CET)", "by mail-wg0-f48.google.com with SMTP id y19so9325785wgg.7\n\tfor <dev@dpdk.org>; Sat, 22 Nov 2014 13:44:22 -0800 (PST)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by mx.google.com with ESMTPSA id\n\tcz3sm13724087wjb.23.2014.11.22.13.44.21 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 22 Nov 2014 13:44:22 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=40bBrVRg6PizziVbKixTVgSqeRKjMrGTHA0zbT9pY2o=;\n\tb=ks+Imx/1cW/eNzPUDh1s7DcYa0YsN3vpNOf5mmm4pDNnVjUgdDuU5OgYSFaDERIPa8\n\tfkTX+Jk0SVTnimu5cRzSoFkO+yjXZJfQbGBs7E79GV89WfkV3nyB0ym3+YFJ+jj/kQgN\n\t5srgt82Ga9PbQhiB6DToEXJAa65R/rmtW1VlaNXcAM35Mjz+yA+hBgHApT3YuwUVswda\n\tvMebdFhSU9uMsd7ZDwKWZ84Cfj2imfddz2udGzJ8Y4Ny58FZ/FC5HYSTlD8mZyvwIg/6\n\tQ4lHSfOWz9mAeUYXNfbjIbg4ib86ma64e8MuvvxO+J1U/r0OlTa8C1kMlYFC2UqOvJV1\n\tweaw==", "X-Gm-Message-State": "ALoCoQlIB0RRCRqyyFyXvD3zIeuT/Vut3C/9nZdEn9wkUujs6ao58qXsYQWyQm31Smf31mu9qGhs", "X-Received": "by 10.180.83.37 with SMTP id n5mr8382171wiy.83.1416692662815;\n\tSat, 22 Nov 2014 13:44:22 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Sat, 22 Nov 2014 22:43:36 +0100", "Message-Id": "<1416692622-28886-5-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.1.3", "In-Reply-To": "<1416692622-28886-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1416692622-28886-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH 04/10] eal: factorize internal config reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Now that internal config structure is common to Linux and BSD,\nwe can have a common function to initialize it.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n lib/librte_eal/bsdapp/eal/eal.c | 24 +------------------\n lib/librte_eal/common/eal_common_options.c | 37 ++++++++++++++++++++++++++++++\n lib/librte_eal/common/eal_internal_cfg.h | 2 ++\n lib/librte_eal/linuxapp/eal/eal.c | 28 +---------------------\n 4 files changed, 41 insertions(+), 50 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c\nindex ca99cb9..391ce53 100644\n--- a/lib/librte_eal/bsdapp/eal/eal.c\n+++ b/lib/librte_eal/bsdapp/eal/eal.c\n@@ -321,29 +321,7 @@ eal_parse_args(int argc, char **argv)\n \n \targvopt = argv;\n \n-\tinternal_config.memory = 0;\n-\tinternal_config.force_nrank = 0;\n-\tinternal_config.force_nchannel = 0;\n-\tinternal_config.hugefile_prefix = HUGEFILE_PREFIX_DEFAULT;\n-\tinternal_config.hugepage_dir = NULL;\n-\tinternal_config.force_sockets = 0;\n-\tinternal_config.syslog_facility = LOG_DAEMON;\n-\t/* default value from build option */\n-\tinternal_config.log_level = RTE_LOG_LEVEL;\n-#ifdef RTE_LIBEAL_USE_HPET\n-\tinternal_config.no_hpet = 0;\n-#else\n-\tinternal_config.no_hpet = 1;\n-#endif\n-\t/* zero out the NUMA config */\n-\tfor (i = 0; i < RTE_MAX_NUMA_NODES; i++)\n-\t\tinternal_config.socket_mem[i] = 0;\n-\n-\t/* zero out hugedir descriptors */\n-\tfor (i = 0; i < MAX_HUGEPAGE_SIZES; i++)\n-\t\tinternal_config.hugepage_info[i].lock_descriptor = 0;\n-\n-\tinternal_config.vmware_tsc_map = 0;\n+\teal_reset_internal_config(&internal_config);\n \n \twhile ((opt = getopt_long(argc, argvopt, eal_short_options,\n \t\t\t\t eal_long_options, &option_index)) != EOF) {\ndiff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 7a5d55e..ffc615a 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -47,6 +47,7 @@\n \n #include \"eal_internal_cfg.h\"\n #include \"eal_options.h\"\n+#include \"eal_filesystem.h\"\n \n #define BITS_PER_HEX 4\n \n@@ -84,6 +85,42 @@ eal_long_options[] = {\n \t{0, 0, 0, 0}\n };\n \n+void\n+eal_reset_internal_config(struct internal_config *internal_cfg)\n+{\n+\tint i;\n+\n+\tinternal_cfg->memory = 0;\n+\tinternal_cfg->force_nrank = 0;\n+\tinternal_cfg->force_nchannel = 0;\n+\tinternal_cfg->hugefile_prefix = HUGEFILE_PREFIX_DEFAULT;\n+\tinternal_cfg->hugepage_dir = NULL;\n+\tinternal_cfg->force_sockets = 0;\n+\t/* zero out the NUMA config */\n+\tfor (i = 0; i < RTE_MAX_NUMA_NODES; i++)\n+\t\tinternal_cfg->socket_mem[i] = 0;\n+\t/* zero out hugedir descriptors */\n+\tfor (i = 0; i < MAX_HUGEPAGE_SIZES; i++)\n+\t\tinternal_cfg->hugepage_info[i].lock_descriptor = -1;\n+\tinternal_cfg->base_virtaddr = 0;\n+\n+\tinternal_cfg->syslog_facility = LOG_DAEMON;\n+\t/* default value from build option */\n+\tinternal_cfg->log_level = RTE_LOG_LEVEL;\n+\n+\tinternal_cfg->xen_dom0_support = 0;\n+\n+\t/* if set to NONE, interrupt mode is determined automatically */\n+\tinternal_cfg->vfio_intr_mode = RTE_INTR_MODE_NONE;\n+\n+#ifdef RTE_LIBEAL_USE_HPET\n+\tinternal_cfg->no_hpet = 0;\n+#else\n+\tinternal_cfg->no_hpet = 1;\n+#endif\n+\tinternal_cfg->vmware_tsc_map = 0;\n+}\n+\n /*\n * Parse the coremask given as argument (hexadecimal string) and fill\n * the global configuration (core role and core count) with the parsed\ndiff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h\nindex 19c84e7..a80aeab 100644\n--- a/lib/librte_eal/common/eal_internal_cfg.h\n+++ b/lib/librte_eal/common/eal_internal_cfg.h\n@@ -88,4 +88,6 @@ struct internal_config {\n };\n extern struct internal_config internal_config; /**< Global EAL configuration. */\n \n+void eal_reset_internal_config(struct internal_config *internal_cfg);\n+\n #endif\ndiff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex 7a1d087..bb35669 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -513,33 +513,7 @@ eal_parse_args(int argc, char **argv)\n \n \targvopt = argv;\n \n-\tinternal_config.memory = 0;\n-\tinternal_config.force_nrank = 0;\n-\tinternal_config.force_nchannel = 0;\n-\tinternal_config.hugefile_prefix = HUGEFILE_PREFIX_DEFAULT;\n-\tinternal_config.hugepage_dir = NULL;\n-\tinternal_config.force_sockets = 0;\n-\tinternal_config.syslog_facility = LOG_DAEMON;\n-\t/* default value from build option */\n-\tinternal_config.log_level = RTE_LOG_LEVEL;\n-\tinternal_config.xen_dom0_support = 0;\n-\t/* if set to NONE, interrupt mode is determined automatically */\n-\tinternal_config.vfio_intr_mode = RTE_INTR_MODE_NONE;\n-#ifdef RTE_LIBEAL_USE_HPET\n-\tinternal_config.no_hpet = 0;\n-#else\n-\tinternal_config.no_hpet = 1;\n-#endif\n-\t/* zero out the NUMA config */\n-\tfor (i = 0; i < RTE_MAX_NUMA_NODES; i++)\n-\t\tinternal_config.socket_mem[i] = 0;\n-\n-\t/* zero out hugedir descriptors */\n-\tfor (i = 0; i < MAX_HUGEPAGE_SIZES; i++)\n-\t\tinternal_config.hugepage_info[i].lock_descriptor = -1;\n-\n-\tinternal_config.vmware_tsc_map = 0;\n-\tinternal_config.base_virtaddr = 0;\n+\teal_reset_internal_config(&internal_config);\n \n \twhile ((opt = getopt_long(argc, argvopt, eal_short_options,\n \t\t\t\t eal_long_options, &option_index)) != EOF) {\n", "prefixes": [ "dpdk-dev", "04/10" ] }