Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14193/?format=api
{ "id": 14193, "url": "https://patches.dpdk.org/api/patches/14193/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1466586355-30777-13-git-send-email-nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1466586355-30777-13-git-send-email-nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1466586355-30777-13-git-send-email-nelio.laranjeiro@6wind.com", "date": "2016-06-22T09:05:42", "name": "[dpdk-dev,v4,12/25] mlx5: add Tx/Rx burst function selection wrapper", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "370492255b8d19965b5c987aded92189f3639dc7", "submitter": { "id": 243, "url": "https://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 10, "url": "https://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1466586355-30777-13-git-send-email-nelio.laranjeiro@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/14193/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/14193/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id BFBB8C424;\n\tWed, 22 Jun 2016 11:06:38 +0200 (CEST)", "from mail-lf0-f53.google.com (mail-lf0-f53.google.com\n\t[209.85.215.53]) by dpdk.org (Postfix) with ESMTP id E7E85C13A\n\tfor <dev@dpdk.org>; Wed, 22 Jun 2016 11:06:21 +0200 (CEST)", "by mail-lf0-f53.google.com with SMTP id h129so67625051lfh.1\n\tfor <dev@dpdk.org>; Wed, 22 Jun 2016 02:06:21 -0700 (PDT)", "from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tz5sm7019178wme.5.2016.06.22.02.06.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 22 Jun 2016 02:06:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Zf/b62rCWOQGdkGqxa4CHML1magBjZZNV54X7GzXzwo=;\n\tb=QIiVfK0rZdjI759Zh/ivKTpeOlLjMs8XNNHSZ0exqnnc7PpEIRHXUNpROrLPACIfsp\n\trtLD9Hi3VRBTtsf8cDPxsaL4TUWz0X/+PxBl6NT6G+t1+nlPUh9gql6rCwxrchmhXePp\n\ttLoD8QwcDApMCsIJyujRU9fqZV0WVWzDhr+5I8zJigHM1Bmrwiyh4b4mo0q1/iYFpYfJ\n\tzcYTbp1Vw4P7ouTppwQbClgY/wlke9c+b+I9BnUy6H83RzDSpOyeg71Rid0Zth81h9W2\n\tI3ygEeObjJBF+4wYDrnmwkpeNTKeFJ3UmUQ9Zr6xfpEiagTuRTuvxzdQjWZkLLwTxuyF\n\t/TSQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Zf/b62rCWOQGdkGqxa4CHML1magBjZZNV54X7GzXzwo=;\n\tb=QZtwEQdBmU+ZNubKnJEecvdDFE0KizCuZY76UK1ClT89F4fsULz8yPmKcfU8UzsXDD\n\t0vns/e3SME8tH6mA3ihnmzFtkNgkP33qzN8ew/RQaffab+RXzEekKf5gYCH/ApNJ9m5u\n\tzNXWOfoB+V2e59qPPQv5wabXQ7RXT9Bgn1zxQmkDQAT4jpcKNpe6wRo+tu8+GFzJWq8e\n\taLpaJIi3jEkq9KZ7rjt4/M6fOCkCRmUXMxIeS9sbBNtTPlVcwnsm2vk6c+TO+wuhgN4/\n\tDVEc8B8HhSFGSFHT/KJaaTWZPYNu41JrLS7rt6Br9o8ZWgOp6MrgvP8fiy65ffO6KcIA\n\tMNCg==", "X-Gm-Message-State": "ALyK8tJ7VWptj7moBQ4Mb5LsXCuw4a+OyNMeYskt3+StRFWtCJNPUYjqzdcbr9up9+phe2DX", "X-Received": "by 10.28.182.68 with SMTP id g65mr7296482wmf.12.1466586381607;\n\tWed, 22 Jun 2016 02:06:21 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>", "Date": "Wed, 22 Jun 2016 11:05:42 +0200", "Message-Id": "<1466586355-30777-13-git-send-email-nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1466586355-30777-1-git-send-email-nelio.laranjeiro@6wind.com>", "References": "<1466493818-1877-1-git-send-email-nelio.laranjeiro@6wind.com>\n\t<1466586355-30777-1-git-send-email-nelio.laranjeiro@6wind.com>", "Subject": "[dpdk-dev] [PATCH v4 12/25] mlx5: add Tx/Rx burst function\n\tselection wrapper", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "These wrappers are meant to prevent code duplication later.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx5/mlx5.h | 2 ++\n drivers/net/mlx5/mlx5_ethdev.c | 34 ++++++++++++++++++++++++++++------\n drivers/net/mlx5/mlx5_txq.c | 2 +-\n 3 files changed, 31 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 935e1b0..3dca03d 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -196,6 +196,8 @@ void priv_dev_interrupt_handler_install(struct priv *, struct rte_eth_dev *);\n int mlx5_set_link_down(struct rte_eth_dev *dev);\n int mlx5_set_link_up(struct rte_eth_dev *dev);\n struct priv *mlx5_secondary_data_setup(struct priv *priv);\n+void priv_select_tx_function(struct priv *);\n+void priv_select_rx_function(struct priv *);\n \n /* mlx5_mac.c */\n \ndiff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex 4095a06..759434e 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -1099,8 +1099,8 @@ priv_set_link(struct priv *priv, int up)\n \t\terr = priv_set_flags(priv, ~IFF_UP, IFF_UP);\n \t\tif (err)\n \t\t\treturn err;\n-\t\tdev->rx_pkt_burst = mlx5_rx_burst;\n-\t\tdev->tx_pkt_burst = mlx5_tx_burst;\n+\t\tpriv_select_tx_function(priv);\n+\t\tpriv_select_rx_function(priv);\n \t} else {\n \t\terr = priv_set_flags(priv, ~IFF_UP, ~IFF_UP);\n \t\tif (err)\n@@ -1290,13 +1290,11 @@ mlx5_secondary_data_setup(struct priv *priv)\n \trte_mb();\n \tpriv->dev->data = &sd->data;\n \trte_mb();\n-\tpriv->dev->tx_pkt_burst = mlx5_tx_burst;\n-\tpriv->dev->rx_pkt_burst = removed_rx_burst;\n+\tpriv_select_tx_function(priv);\n+\tpriv_select_rx_function(priv);\n \tpriv_unlock(priv);\n end:\n \t/* More sanity checks. */\n-\tassert(priv->dev->tx_pkt_burst == mlx5_tx_burst);\n-\tassert(priv->dev->rx_pkt_burst == removed_rx_burst);\n \tassert(priv->dev->data == &sd->data);\n \trte_spinlock_unlock(&sd->lock);\n \treturn priv;\n@@ -1307,3 +1305,27 @@ error:\n \trte_spinlock_unlock(&sd->lock);\n \treturn NULL;\n }\n+\n+/**\n+ * Configure the TX function to use.\n+ *\n+ * @param priv\n+ * Pointer to private structure.\n+ */\n+void\n+priv_select_tx_function(struct priv *priv)\n+{\n+\tpriv->dev->tx_pkt_burst = mlx5_tx_burst;\n+}\n+\n+/**\n+ * Configure the RX function to use.\n+ *\n+ * @param priv\n+ * Pointer to private structure.\n+ */\n+void\n+priv_select_rx_function(struct priv *priv)\n+{\n+\tpriv->dev->rx_pkt_burst = mlx5_rx_burst;\n+}\ndiff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c\nindex 9f3a33b..d7cc39d 100644\n--- a/drivers/net/mlx5/mlx5_txq.c\n+++ b/drivers/net/mlx5/mlx5_txq.c\n@@ -477,7 +477,7 @@ mlx5_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,\n \t\t (void *)dev, (void *)txq_ctrl);\n \t\t(*priv->txqs)[idx] = &txq_ctrl->txq;\n \t\t/* Update send callback. */\n-\t\tdev->tx_pkt_burst = mlx5_tx_burst;\n+\t\tpriv_select_tx_function(priv);\n \t}\n \tpriv_unlock(priv);\n \treturn -ret;\n", "prefixes": [ "dpdk-dev", "v4", "12/25" ] }