Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140025/?format=api
{ "id": 140025, "url": "https://patches.dpdk.org/api/patches/140025/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240512055109.96609-1-yoav.w@claroty.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240512055109.96609-1-yoav.w@claroty.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240512055109.96609-1-yoav.w@claroty.com", "date": "2024-05-12T05:51:09", "name": "bpf: don't verify classic bpfs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b91359fe932bb170cec4fc5cbfda184c2fb8329f", "submitter": { "id": 3313, "url": "https://patches.dpdk.org/api/people/3313/?format=api", "name": "Yoav Winstein", "email": "yoav.w@claroty.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240512055109.96609-1-yoav.w@claroty.com/mbox/", "series": [ { "id": 31908, "url": "https://patches.dpdk.org/api/series/31908/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31908", "date": "2024-05-12T05:51:09", "name": "bpf: don't verify classic bpfs", "version": 1, "mbox": "https://patches.dpdk.org/series/31908/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/140025/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/140025/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E0B1B44008;\n\tSun, 12 May 2024 07:51:19 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AC39940268;\n\tSun, 12 May 2024 07:51:19 +0200 (CEST)", "from mail-wm1-f97.google.com (mail-wm1-f97.google.com\n [209.85.128.97]) by mails.dpdk.org (Postfix) with ESMTP id 55E684003C\n for <dev@dpdk.org>; Sun, 12 May 2024 07:51:18 +0200 (CEST)", "by mail-wm1-f97.google.com with SMTP id\n 5b1f17b1804b1-41fc2f7fbb5so17147605e9.1\n for <dev@dpdk.org>; Sat, 11 May 2024 22:51:18 -0700 (PDT)", "from claroty.com ([31.186.239.8])\n by smtp-relay.gmail.com with ESMTPS id\n 5b1f17b1804b1-41f882100ffsm9047575e9.43.2024.05.11.22.51.17\n for <dev@dpdk.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 11 May 2024 22:51:17 -0700 (PDT)", "by mail-wr1-f69.google.com with SMTP id\n ffacd0b85a97d-346c08df987so1771905f8f.0\n for <dev@dpdk.org>; Sat, 11 May 2024 22:51:17 -0700 (PDT)", "from localhost.localdomain ([94.188.185.10])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3502bbbbfecsm8159446f8f.105.2024.05.11.22.51.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 11 May 2024 22:51:16 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715493078; x=1716097878;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:dkim-signature:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BjmABP97bv1QBl9qGQ1USnTz0HSunGzny0EmK3+xyvA=;\n b=SvltGAq6UsPfCCRGjJAG/CB/kVJJKGsVWSwyjNlnPHjg72aFhJfX6b1h7X/AzrUN+G\n f5HloSpUvg6KyHUw5JgY2qgWsf95R68fXGWu9V2apt30ME/qPfSxLYWZ3gQ5g+tioqNG\n ExbWxoFfCZnNoOT4paOXmN/ObDGnk7QpPkxrxQA7kwz69fqFF+MnnjNRDwn4F6u00liV\n 6lY3HQI52imuFe4fjFyUJqM4f0xpVcfhUFED79z279BSTAZs/vCSZhJHK80vE+Ts+R22\n 4/cTMrxwclJ34fQzROgNdaQ7X06uNcsy6nN+VCPSOLxvAQU/Op2TalvaVlC6/ZD4sLr4\n Dxsw==", "X-Gm-Message-State": "AOJu0YzEUbWncPYK7aFsquAdmqW8TZyxUnSp5nqlEcpUNqnOu6IZsC4u\n Ti3xHAS2QpBQuQtdwUzcTQNzjiTV+imSwMrOhRQnZtGVUBaFJE7kqShD1Q2SdCF2Kr2RsPYJ6HP\n easfReJ7WL4Ka4qOmCd1y/1XFo0Zwee7zS88MbzHv", "X-Google-Smtp-Source": "\n AGHT+IGI2EPzwk1L3aqdXZbi6QTDSntwjftGwZid75qyDcrWJX7A4Jd4TFHuFBt5trSNmlusbcXNUSiOMIs2", "X-Received": [ "by 2002:adf:e58e:0:b0:34d:8206:e76b with SMTP id\n ffacd0b85a97d-35018117631mr8643078f8f.9.1715493077944;\n Sat, 11 May 2024 22:51:17 -0700 (PDT)", "by 2002:a5d:4311:0:b0:34d:ab1a:6384 with SMTP id\n ffacd0b85a97d-3504989eb09mr5628443f8f.13.1715493076757;\n Sat, 11 May 2024 22:51:16 -0700 (PDT)", "by 2002:a5d:4311:0:b0:34d:ab1a:6384 with SMTP id\n ffacd0b85a97d-3504989eb09mr5628433f8f.13.1715493076425;\n Sat, 11 May 2024 22:51:16 -0700 (PDT)" ], "X-Relaying-Domain": "claroty.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=claroty.com; s=google; t=1715493077; x=1716097877; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=BjmABP97bv1QBl9qGQ1USnTz0HSunGzny0EmK3+xyvA=;\n b=Qj8hJ5RfHGB3R0gQVccGYp28hFtfhTVJZFFq+DWQWKFd2isT8DdghMrEoH/fqaK2Mq\n yaXyaO6YMf1hmh66gZh7kcGyNpGdXgD5Ib1EuoJcq8bQJVVT4W6Efu/R6rF0Sj09dKsb\n JI5NuQW+hWTysq9W6VB+6rRlGFltmvWtngS/eYPdRfCVl0zkilubPSosrIrnDllACpGs\n SfGUH4LKURttwBS+72SeZ1QbPwtxSqM4QSdWhyeRkwLLrTkwK3XzXV1579+kEnTzou6q\n xys1nzsbOYG59zEcdNhVeSkcV0OSolLCsSJYIAWBrrZvJVgZTIDEQai/d0vn9BVDJEVu\n 5Iag==", "From": "Yoav Winstein <yoav.w@claroty.com>", "To": "dev@dpdk.org", "Cc": "Yoav Winstein <yoav.w@claroty.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "Subject": "[PATCH] bpf: don't verify classic bpfs", "Date": "Sun, 12 May 2024 08:51:09 +0300", "Message-Id": "<20240512055109.96609-1-yoav.w@claroty.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "x-netskope-inspected": "true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "I noticed that when classic BPFs with lots of branching instructions are compiled, __rte_bpf_bpf_validate runs way too slow. A simple bpf such as: 'ether host a0:38:6d:af:17:eb or b3:a3:ff:b6:c1:ef or ...' 12 times results in ~1 minute of bpf validation. This patch makes __rte_bpf_bpf_validate be aware of bpf_prm originating from classic BPF, allowing to safely skip over the validation.\n\nSigned-off-by: Yoav Winstein <yoav.w@claroty.com>\n---\n app/test/test_bpf.c | 2 ++\n lib/bpf/bpf_convert.c | 1 +\n lib/bpf/bpf_load.c | 6 ++++--\n lib/bpf/rte_bpf.h | 1 +\n 4 files changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c\nindex 53e3a31123..7aae290c1a 100644\n--- a/app/test/test_bpf.c\n+++ b/app/test/test_bpf.c\n@@ -3407,6 +3407,8 @@ static const char * const sample_filters[] = {\n \t\" and (tcp[((tcp[12] & 0xF0) >> 4 ) * 4 + 1] = 0x03)\"\n \t\" and (tcp[((tcp[12] & 0xF0) >> 4 ) * 4 + 2] < 0x04)\"\n \t\" and ((ip[2:2] - 4 * (ip[0] & 0x0F) - 4 * ((tcp[12] & 0xF0) >> 4) > 69))\",\n+\t/* Performance */\n+\t\"ether host a0:38:6d:af:17:eb or b3:a3:ff:b6:c1:ef or 4a:e8:e7:5b:76:ce or 0d:87:fa:7a:a6:6d or bb:fd:c6:4b:bc:ae or 4e:28:dc:f1:1c:f6 or 3d:f2:b7:99:54:55 or 1c:5a:90:4b:82:ce or a7:28:08:ea:c9:84 or 1f:c0:2f:2f:0a:01 or c6:64:91:e9:78:f2 or 5b:cc:3f:90:39:ae or 4c:38:8f:ed:16:5c or cb:89:cb:54:0f:4f or 1e:0d:d7:b2:21:84 or 91:07:2b:88:e0:96 or 6c:ca:cf:bf:cf:3e or b9:df:f1:d6:dd:11 or ea:34:0b:b3:96:9e or 70:e5:18:9f:22:93\",\n \t/* Other */\n \t\"len = 128\",\n };\ndiff --git a/lib/bpf/bpf_convert.c b/lib/bpf/bpf_convert.c\nindex d7ff2b4325..bc3c9a5d8e 100644\n--- a/lib/bpf/bpf_convert.c\n+++ b/lib/bpf/bpf_convert.c\n@@ -567,6 +567,7 @@ rte_bpf_convert(const struct bpf_program *prog)\n \t/* Classic BPF programs use mbufs */\n \tprm->prog_arg.type = RTE_BPF_ARG_PTR_MBUF;\n \tprm->prog_arg.size = sizeof(struct rte_mbuf);\n+\tprm->skip_verification = true;\n \n \treturn prm;\n }\ndiff --git a/lib/bpf/bpf_load.c b/lib/bpf/bpf_load.c\nindex de43347405..e30797cb49 100644\n--- a/lib/bpf/bpf_load.c\n+++ b/lib/bpf/bpf_load.c\n@@ -108,13 +108,15 @@ rte_bpf_load(const struct rte_bpf_prm *prm)\n \t\treturn NULL;\n \t}\n \n-\trc = __rte_bpf_validate(bpf);\n+\tif (!prm->skip_verification)\n+\t\trc = __rte_bpf_validate(bpf);\n+\n \tif (rc == 0) {\n \t\t__rte_bpf_jit(bpf);\n \t\tif (mprotect(bpf, bpf->sz, PROT_READ) != 0)\n \t\t\trc = -ENOMEM;\n \t}\n-\n+\t\n \tif (rc != 0) {\n \t\trte_bpf_destroy(bpf);\n \t\trte_errno = -rc;\ndiff --git a/lib/bpf/rte_bpf.h b/lib/bpf/rte_bpf.h\nindex 80ebb0210f..6f3b4e3c31 100644\n--- a/lib/bpf/rte_bpf.h\n+++ b/lib/bpf/rte_bpf.h\n@@ -94,6 +94,7 @@ struct rte_bpf_prm {\n \t/**< array of external symbols that eBPF code is allowed to reference */\n \tuint32_t nb_xsym; /**< number of elements in xsym */\n \tstruct rte_bpf_arg prog_arg; /**< eBPF program input arg description */\n+\tbool skip_verification; /**< should skip eBPF verification before load */\n };\n \n /**\n", "prefixes": [] }