Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140023/?format=api
{ "id": 140023, "url": "https://patches.dpdk.org/api/patches/140023/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240511052618.1890677-1-frank.du@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240511052618.1890677-1-frank.du@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240511052618.1890677-1-frank.du@intel.com", "date": "2024-05-11T05:26:18", "name": "[v2] net/af_xdp: fix umem map size for zero copy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3e9fbbfa9b318c16f4f154670e2d97150f1121c9", "submitter": { "id": 2892, "url": "https://patches.dpdk.org/api/people/2892/?format=api", "name": "Du, Frank", "email": "frank.du@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240511052618.1890677-1-frank.du@intel.com/mbox/", "series": [ { "id": 31906, "url": "https://patches.dpdk.org/api/series/31906/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31906", "date": "2024-05-11T05:26:18", "name": "[v2] net/af_xdp: fix umem map size for zero copy", "version": 2, "mbox": "https://patches.dpdk.org/series/31906/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/140023/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/140023/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5EE8C43FEF;\n\tSat, 11 May 2024 07:42:33 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2C1A140293;\n\tSat, 11 May 2024 07:42:33 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by mails.dpdk.org (Postfix) with ESMTP id E07ED40261\n for <dev@dpdk.org>; Sat, 11 May 2024 07:42:30 +0200 (CEST)", "from orviesa003.jf.intel.com ([10.64.159.143])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 May 2024 22:42:30 -0700", "from media-frankdu-kahawai-node2.sh.intel.com ([10.67.119.123])\n by orviesa003.jf.intel.com with ESMTP; 10 May 2024 22:42:28 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1715406151; x=1746942151;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Ws1Q9YQemwTBLPvlqpQYFhrORBkNACM4GrpEvog4gfY=;\n b=BQFeOmuV43kftYTnaQK2LPEovjf4enrx2569rQ/G2WdqY5KkqMKyC4+J\n KJ7RtzbZ/0ReEo/OhCtuVWMyv69f7IqodLL4d1KJ1DU5fw3NkhbU+bWhf\n bR8r06Kuk+yoVJuKI46a1UZDOvYEEDamu7jr/803m52UlKUj6xD4F16zT\n 67ho110b5ayLO2QiIQaD48Zic4XVHGL5VuXYiLeCpac58g+Pblscb5gvj\n IwT+B8/MPO9oslRiGEQ75QZSSx+HpiWlfetDxLrxpALx5lxEty5wRbo6l\n hYUcCuuecfbmPSwxqBXLVi0nWCj25T0wujuSTOS76aBofd9Am/k+z4b3O g==;", "X-CSE-ConnectionGUID": [ "C4T5QsyCQjuClPuuv2vcgQ==", "VuCTljLOStacenHL17qyUg==" ], "X-CSE-MsgGUID": [ "jEJgo2BYTlq9JjAx3JOYQA==", "HXAYhmDyR8mvIl/YEV5jEQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11069\"; a=\"11627531\"", "E=Sophos;i=\"6.08,153,1712646000\"; d=\"scan'208\";a=\"11627531\"", "E=Sophos;i=\"6.08,153,1712646000\"; d=\"scan'208\";a=\"34509707\"" ], "X-ExtLoop1": "1", "From": "Frank Du <frank.du@intel.com>", "To": "dev@dpdk.org", "Cc": "ciara.loftus@intel.com", "Subject": "[PATCH v2] net/af_xdp: fix umem map size for zero copy", "Date": "Sat, 11 May 2024 13:26:18 +0800", "Message-Id": "<20240511052618.1890677-1-frank.du@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240426005128.148730-1-frank.du@intel.com>", "References": "<20240426005128.148730-1-frank.du@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current calculation assumes that the mbufs are contiguous. However,\nthis assumption is incorrect when the memory spans across a huge page.\nCorrect to directly read the size from the mempool memory chunks.\n\nSigned-off-by: Frank Du <frank.du@intel.com>\n\n---\nv2:\n* Add virtual contiguous detect for for multiple memhdrs.\n---\n drivers/net/af_xdp/rte_eth_af_xdp.c | 34 ++++++++++++++++++++++++-----\n 1 file changed, 28 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c\nindex 268a130c49..7456108d6d 100644\n--- a/drivers/net/af_xdp/rte_eth_af_xdp.c\n+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c\n@@ -1039,16 +1039,35 @@ eth_link_update(struct rte_eth_dev *dev __rte_unused,\n }\n \n #if defined(XDP_UMEM_UNALIGNED_CHUNK_FLAG)\n-static inline uintptr_t get_base_addr(struct rte_mempool *mp, uint64_t *align)\n+static inline uintptr_t get_memhdr_info(struct rte_mempool *mp, uint64_t *align, size_t *len)\n {\n-\tstruct rte_mempool_memhdr *memhdr;\n+\tstruct rte_mempool_memhdr *memhdr, *next;\n \tuintptr_t memhdr_addr, aligned_addr;\n+\tsize_t memhdr_len = 0;\n \n+\t/* get the mempool base addr and align */\n \tmemhdr = STAILQ_FIRST(&mp->mem_list);\n \tmemhdr_addr = (uintptr_t)memhdr->addr;\n \taligned_addr = memhdr_addr & ~(getpagesize() - 1);\n \t*align = memhdr_addr - aligned_addr;\n+\tmemhdr_len += memhdr->len;\n+\n+\t/* check if virtual contiguous memory for multiple memhdrs */\n+\tnext = STAILQ_NEXT(memhdr, next);\n+\twhile (next != NULL) {\n+\t\tif ((uintptr_t)next->addr != (uintptr_t)memhdr->addr + memhdr->len) {\n+\t\t\tAF_XDP_LOG(ERR, \"memory chunks not virtual contiguous, \"\n+\t\t\t\t\t\"next: %p, cur: %p(len: %\" PRId64 \" )\\n\",\n+\t\t\t\t\tnext->addr, memhdr->addr, memhdr->len);\n+\t\t\treturn 0;\n+\t\t}\n+\t\t/* virtual contiguous */\n+\t\tmemhdr = next;\n+\t\tmemhdr_len += memhdr->len;\n+\t\tnext = STAILQ_NEXT(memhdr, next);\n+\t}\n \n+\t*len = memhdr_len;\n \treturn aligned_addr;\n }\n \n@@ -1125,6 +1144,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,\n \tvoid *base_addr = NULL;\n \tstruct rte_mempool *mb_pool = rxq->mb_pool;\n \tuint64_t umem_size, align = 0;\n+\tsize_t len = 0;\n \n \tif (internals->shared_umem) {\n \t\tif (get_shared_umem(rxq, internals->if_name, &umem) < 0)\n@@ -1156,10 +1176,12 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,\n \t\t}\n \n \t\tumem->mb_pool = mb_pool;\n-\t\tbase_addr = (void *)get_base_addr(mb_pool, &align);\n-\t\tumem_size = (uint64_t)mb_pool->populated_size *\n-\t\t\t\t(uint64_t)usr_config.frame_size +\n-\t\t\t\talign;\n+\t\tbase_addr = (void *)get_memhdr_info(mb_pool, &align, &len);\n+\t\tif (!base_addr) {\n+\t\t\tAF_XDP_LOG(ERR, \"Failed to parse memhdr info from pool\\n\");\n+\t\t\tgoto err;\n+\t\t}\n+\t\tumem_size = (uint64_t)len + align;\n \n \t\tret = xsk_umem__create(&umem->umem, base_addr, umem_size,\n \t\t\t\t&rxq->fq, &rxq->cq, &usr_config);\n", "prefixes": [ "v2" ] }