Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140015/?format=api
{ "id": 140015, "url": "https://patches.dpdk.org/api/patches/140015/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240510050507.14381-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240510050507.14381-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240510050507.14381-4-stephen@networkplumber.org", "date": "2024-05-10T05:01:23", "name": "[RFC,3/3] net/tap: use generic SW stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "df0b9ba3340820b770cece1c16830f606a9a7141", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240510050507.14381-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 31900, "url": "https://patches.dpdk.org/api/series/31900/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31900", "date": "2024-05-10T05:01:20", "name": "generic sw counters", "version": 1, "mbox": "https://patches.dpdk.org/series/31900/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/140015/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/140015/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 574BD43FEC;\n\tFri, 10 May 2024 07:05:35 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6FAF940685;\n\tFri, 10 May 2024 07:05:18 +0200 (CEST)", "from mail-pl1-f170.google.com (mail-pl1-f170.google.com\n [209.85.214.170])\n by mails.dpdk.org (Postfix) with ESMTP id A6E2E40395\n for <dev@dpdk.org>; Fri, 10 May 2024 07:05:14 +0200 (CEST)", "by mail-pl1-f170.google.com with SMTP id\n d9443c01a7336-1ed41eb3382so11862695ad.0\n for <dev@dpdk.org>; Thu, 09 May 2024 22:05:14 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-1ef0c25566asm23007385ad.283.2024.05.09.22.05.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 May 2024 22:05:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715317514;\n x=1715922314; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LLMszliOaj8mteL5ALmEOeHR8g/+1DUpiL1DIWKZMxE=;\n b=jLpjZ4fy9NN8BgsGIk1h6Zlnf7CZgMl0vuS4iNkkbJsmaBCmb2uSC93k1jNaay5QzL\n xP2ypaDI/Kz+6OH0hhcnJsQ744SuM6hkzYg5rPmGxeI9gruwswTXbDjklhZp0BDHh6wh\n 1fEyPx0KdXOuMLwsZ2dueSifg8XUQb3q/umWLLHTx1TsJSyIpDxP4TPagQGgsxWOVMSf\n eVpBnp0He044rxA5NIFvL4XqGuGcF8vmbRpllBQUv8o/YvqOPrOTdZKFAi8/fDL4Soux\n FHy0J6XfOuXKsyPkbhwnGQ25WPdoi3gk0lkWEW3Dq++4XlZmmLizCosZUIe9y8KWFlcN\n 36sg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715317514; x=1715922314;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=LLMszliOaj8mteL5ALmEOeHR8g/+1DUpiL1DIWKZMxE=;\n b=HEG8d+lHtFraAQaOSFkn5xOyHqM5QF+mO+NQaVl0bnH12HJiox5yxOks5zC5ZQPS6+\n DG9FJuYcj1R6gLaDHOXXbsujcs7bYD0LhfJLjM7lwhfz9fccgZ9g7rs7S+YOFHWIcnE2\n BbcaQVk+ep2M0SCH8wHmV4mYxLFtZOVwoYi1goPCswPleKMVS52NHoGG8AIybriXOqIO\n o4EHl+1jq6ru1o/W/P4tf7m9qnX0axo7lAjP8utApLT7uEDK0eqQPB1wsufujBWuTZvL\n Kytihp++NghNTlza7sTw+ZzHAZYgbLd8ugwADoHRMOzVRlKAcx/GbnFj29ZRefjYQDTC\n ePXQ==", "X-Gm-Message-State": "AOJu0YxAGlDqLAiYLThvFPS5kQ1x23Xfz/SGtpSgWxJPRnmZGO3kw6pv\n X6JgQygjllnZy+2nHhDnE+sv63ZRHCFxmGmAcjZbhkwHvAaCXUX8tVVuT1jXUh/0tEBv9kLC5Y2\n +vbw=", "X-Google-Smtp-Source": "\n AGHT+IEi/C5oT19Dplssh6sQGmxRN+pL3BUEIOJOYjhJ1tgqxVw59TThAQp1ZhxG6Yx0kEbrPBEYMA==", "X-Received": "by 2002:a17:903:1c2:b0:1e2:bbc0:a671 with SMTP id\n d9443c01a7336-1ef43f4e22amr25020925ad.52.1715317513875;\n Thu, 09 May 2024 22:05:13 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[RFC 3/3] net/tap: use generic SW stats", "Date": "Thu, 9 May 2024 22:01:23 -0700", "Message-ID": "<20240510050507.14381-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240510050507.14381-1-stephen@networkplumber.org>", "References": "<20240425174617.2126159-1-ferruh.yigit@amd.com>\n <20240510050507.14381-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use new common sw statistics.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/rte_eth_tap.c | 100 ++++++----------------------------\n drivers/net/tap/rte_eth_tap.h | 17 ++----\n 2 files changed, 21 insertions(+), 96 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 69d9da695b..faf978b59e 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -432,7 +432,6 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tstruct rx_queue *rxq = queue;\n \tstruct pmd_process_private *process_private;\n \tuint16_t num_rx;\n-\tunsigned long num_rx_bytes = 0;\n \tuint32_t trigger = tap_trigger;\n \n \tif (trigger == rxq->trigger_seen)\n@@ -455,7 +454,7 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \n \t\t/* Packet couldn't fit in the provided mbuf */\n \t\tif (unlikely(rxq->pi.flags & TUN_PKT_STRIP)) {\n-\t\t\trxq->stats.ierrors++;\n+\t\t\trte_eth_qsw_error_inc(&rxq->stats);\n \t\t\tcontinue;\n \t\t}\n \n@@ -467,7 +466,9 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\tstruct rte_mbuf *buf = rte_pktmbuf_alloc(rxq->mp);\n \n \t\t\tif (unlikely(!buf)) {\n-\t\t\t\trxq->stats.rx_nombuf++;\n+\t\t\t\tstruct rte_eth_dev *dev = &rte_eth_devices[rxq->in_port];\n+\t\t\t\t++dev->data->rx_mbuf_alloc_failed;\n+\n \t\t\t\t/* No new buf has been allocated: do nothing */\n \t\t\t\tif (!new_tail || !seg)\n \t\t\t\t\tgoto end;\n@@ -509,11 +510,9 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \n \t\t/* account for the receive frame */\n \t\tbufs[num_rx++] = mbuf;\n-\t\tnum_rx_bytes += mbuf->pkt_len;\n+\t\trte_eth_qsw_update(&rxq->stats, mbuf);\n \t}\n end:\n-\trxq->stats.ipackets += num_rx;\n-\trxq->stats.ibytes += num_rx_bytes;\n \n \tif (trigger && num_rx < nb_pkts)\n \t\trxq->trigger_seen = trigger;\n@@ -523,8 +522,7 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \n static inline int\n tap_write_mbufs(struct tx_queue *txq, uint16_t num_mbufs,\n-\t\t\tstruct rte_mbuf **pmbufs,\n-\t\t\tuint16_t *num_packets, unsigned long *num_tx_bytes)\n+\t\tstruct rte_mbuf **pmbufs)\n {\n \tstruct pmd_process_private *process_private;\n \tint i;\n@@ -647,8 +645,7 @@ tap_write_mbufs(struct tx_queue *txq, uint16_t num_mbufs,\n \t\tif (n <= 0)\n \t\t\treturn -1;\n \n-\t\t(*num_packets)++;\n-\t\t(*num_tx_bytes) += rte_pktmbuf_pkt_len(mbuf);\n+\t\trte_eth_qsw_update(&txq->stats, mbuf);\n \t}\n \treturn 0;\n }\n@@ -660,8 +657,6 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n {\n \tstruct tx_queue *txq = queue;\n \tuint16_t num_tx = 0;\n-\tuint16_t num_packets = 0;\n-\tunsigned long num_tx_bytes = 0;\n \tuint32_t max_size;\n \tint i;\n \n@@ -693,7 +688,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\ttso_segsz = mbuf_in->tso_segsz + hdrs_len;\n \t\t\tif (unlikely(tso_segsz == hdrs_len) ||\n \t\t\t\ttso_segsz > *txq->mtu) {\n-\t\t\t\ttxq->stats.errs++;\n+\t\t\t\trte_eth_qsw_error_inc(&txq->stats);\n \t\t\t\tbreak;\n \t\t\t}\n \t\t\tgso_ctx->gso_size = tso_segsz;\n@@ -728,10 +723,10 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\tnum_mbufs = 1;\n \t\t}\n \n-\t\tret = tap_write_mbufs(txq, num_mbufs, mbuf,\n-\t\t\t\t&num_packets, &num_tx_bytes);\n+\t\tret = tap_write_mbufs(txq, num_mbufs, mbuf);\n \t\tif (ret == -1) {\n-\t\t\ttxq->stats.errs++;\n+\t\t\trte_eth_qsw_error_inc(&txq->stats);\n+\n \t\t\t/* free tso mbufs */\n \t\t\tif (num_tso_mbufs > 0)\n \t\t\t\trte_pktmbuf_free_bulk(mbuf, num_tso_mbufs);\n@@ -749,10 +744,6 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t}\n \t}\n \n-\ttxq->stats.opackets += num_packets;\n-\ttxq->stats.errs += nb_pkts - num_tx;\n-\ttxq->stats.obytes += num_tx_bytes;\n-\n \treturn num_tx;\n }\n \n@@ -1052,68 +1043,6 @@ tap_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \treturn 0;\n }\n \n-static int\n-tap_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *tap_stats)\n-{\n-\tunsigned int i, imax;\n-\tunsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;\n-\tunsigned long rx_bytes_total = 0, tx_bytes_total = 0;\n-\tunsigned long rx_nombuf = 0, ierrors = 0;\n-\tconst struct pmd_internals *pmd = dev->data->dev_private;\n-\n-\t/* rx queue statistics */\n-\timax = (dev->data->nb_rx_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS) ?\n-\t\tdev->data->nb_rx_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS;\n-\tfor (i = 0; i < imax; i++) {\n-\t\ttap_stats->q_ipackets[i] = pmd->rxq[i].stats.ipackets;\n-\t\ttap_stats->q_ibytes[i] = pmd->rxq[i].stats.ibytes;\n-\t\trx_total += tap_stats->q_ipackets[i];\n-\t\trx_bytes_total += tap_stats->q_ibytes[i];\n-\t\trx_nombuf += pmd->rxq[i].stats.rx_nombuf;\n-\t\tierrors += pmd->rxq[i].stats.ierrors;\n-\t}\n-\n-\t/* tx queue statistics */\n-\timax = (dev->data->nb_tx_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS) ?\n-\t\tdev->data->nb_tx_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS;\n-\n-\tfor (i = 0; i < imax; i++) {\n-\t\ttap_stats->q_opackets[i] = pmd->txq[i].stats.opackets;\n-\t\ttap_stats->q_obytes[i] = pmd->txq[i].stats.obytes;\n-\t\ttx_total += tap_stats->q_opackets[i];\n-\t\ttx_err_total += pmd->txq[i].stats.errs;\n-\t\ttx_bytes_total += tap_stats->q_obytes[i];\n-\t}\n-\n-\ttap_stats->ipackets = rx_total;\n-\ttap_stats->ibytes = rx_bytes_total;\n-\ttap_stats->ierrors = ierrors;\n-\ttap_stats->rx_nombuf = rx_nombuf;\n-\ttap_stats->opackets = tx_total;\n-\ttap_stats->oerrors = tx_err_total;\n-\ttap_stats->obytes = tx_bytes_total;\n-\treturn 0;\n-}\n-\n-static int\n-tap_stats_reset(struct rte_eth_dev *dev)\n-{\n-\tint i;\n-\tstruct pmd_internals *pmd = dev->data->dev_private;\n-\n-\tfor (i = 0; i < RTE_PMD_TAP_MAX_QUEUES; i++) {\n-\t\tpmd->rxq[i].stats.ipackets = 0;\n-\t\tpmd->rxq[i].stats.ibytes = 0;\n-\t\tpmd->rxq[i].stats.ierrors = 0;\n-\t\tpmd->rxq[i].stats.rx_nombuf = 0;\n-\n-\t\tpmd->txq[i].stats.opackets = 0;\n-\t\tpmd->txq[i].stats.errs = 0;\n-\t\tpmd->txq[i].stats.obytes = 0;\n-\t}\n-\n-\treturn 0;\n-}\n \n static int\n tap_dev_close(struct rte_eth_dev *dev)\n@@ -1917,8 +1846,11 @@ static const struct eth_dev_ops ops = {\n \t.mac_addr_set = tap_mac_set,\n \t.mtu_set = tap_mtu_set,\n \t.set_mc_addr_list = tap_set_mc_addr_list,\n-\t.stats_get = tap_stats_get,\n-\t.stats_reset = tap_stats_reset,\n+\t.stats_get = rte_eth_qsw_stats_get,\n+\t.stats_reset = rte_eth_qsw_stats_reset,\n+\t.xstats_get_names = rte_eth_qsw_xstats_get_names,\n+\t.xstats_get = rte_eth_qsw_xstats_get,\n+\t.xstats_reset = rte_eth_qsw_stats_reset,\n \t.dev_supported_ptypes_get = tap_dev_supported_ptypes_get,\n \t.rss_hash_update = tap_rss_hash_update,\n \t.flow_ops_get = tap_dev_flow_ops_get,\ndiff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h\nindex 5ac93f93e9..c05a89a6ab 100644\n--- a/drivers/net/tap/rte_eth_tap.h\n+++ b/drivers/net/tap/rte_eth_tap.h\n@@ -14,6 +14,7 @@\n #include <linux/if_tun.h>\n \n #include <ethdev_driver.h>\n+#include <ethdev_swstats.h>\n #include <rte_ether.h>\n #include <rte_gso.h>\n #include \"tap_log.h\"\n@@ -32,22 +33,13 @@ enum rte_tuntap_type {\n \tETH_TUNTAP_TYPE_MAX,\n };\n \n-struct pkt_stats {\n-\tuint64_t opackets; /* Number of output packets */\n-\tuint64_t ipackets; /* Number of input packets */\n-\tuint64_t obytes; /* Number of bytes on output */\n-\tuint64_t ibytes; /* Number of bytes on input */\n-\tuint64_t errs; /* Number of TX error packets */\n-\tuint64_t ierrors; /* Number of RX error packets */\n-\tuint64_t rx_nombuf; /* Nb of RX mbuf alloc failures */\n-};\n-\n struct rx_queue {\n+\tstruct rte_eth_qsw_stats stats;\t/* MUST BE FIRST */\n+\n \tstruct rte_mempool *mp; /* Mempool for RX packets */\n \tuint32_t trigger_seen; /* Last seen Rx trigger value */\n \tuint16_t in_port; /* Port ID */\n \tuint16_t queue_id;\t\t/* queue ID*/\n-\tstruct pkt_stats stats; /* Stats for this RX queue */\n \tuint16_t nb_rx_desc; /* max number of mbufs available */\n \tstruct rte_eth_rxmode *rxmode; /* RX features */\n \tstruct rte_mbuf *pool; /* mbufs pool for this queue */\n@@ -56,10 +48,11 @@ struct rx_queue {\n };\n \n struct tx_queue {\n+\tstruct rte_eth_qsw_stats stats;\t/* MUST BE FIRST */\n+\n \tint type; /* Type field - TUN|TAP */\n \tuint16_t *mtu; /* Pointer to MTU from dev_data */\n \tuint16_t csum:1; /* Enable checksum offloading */\n-\tstruct pkt_stats stats; /* Stats for this TX queue */\n \tstruct rte_gso_ctx gso_ctx; /* GSO context */\n \tuint16_t out_port; /* Port ID */\n \tuint16_t queue_id;\t\t/* queue ID*/\n", "prefixes": [ "RFC", "3/3" ] }