Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1400/?format=api
{ "id": 1400, "url": "https://patches.dpdk.org/api/patches/1400/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1416524335-22753-6-git-send-email-olivier.matz@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1416524335-22753-6-git-send-email-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1416524335-22753-6-git-send-email-olivier.matz@6wind.com", "date": "2014-11-20T22:58:47", "name": "[dpdk-dev,v3,05/13] mbuf: remove too specific PKT_TX_OFFLOAD_MASK definition", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7487994bf3888850bd904939100d758fe26607b3", "submitter": { "id": 8, "url": "https://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1416524335-22753-6-git-send-email-olivier.matz@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1400/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1400/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B52187FB1;\n\tThu, 20 Nov 2014 23:48:49 +0100 (CET)", "from mail-wi0-f178.google.com (mail-wi0-f178.google.com\n\t[209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 51DF87F0C\n\tfor <dev@dpdk.org>; Thu, 20 Nov 2014 23:48:36 +0100 (CET)", "by mail-wi0-f178.google.com with SMTP id hi2so7002875wib.17\n\tfor <dev@dpdk.org>; Thu, 20 Nov 2014 14:59:08 -0800 (PST)", "from glumotte.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tcz3sm5380581wjb.23.2014.11.20.14.59.07 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 20 Nov 2014 14:59:07 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=a5cLiWemz8fhl6MipA8RW4fDAS4VW9JGCm+j03ad3SA=;\n\tb=dukQGcQTLW/TGqs899mJGv14klgua7V4HxG0iiGf2E4nlDF20RV+bBVHWCBskUGU3Y\n\t9GeMQELssUDToBcNgVpNvndhEkLuDNR/CVWTSlEaXQm5fBSfVhiINj9wGN+LaaodEY3A\n\tMCpkkdaSt80i7m07PakHYCFk/f0Z4bEibvFNewRJ5tLjQmNxMkGYnRkdWxp2KyFovPka\n\tkaJfXfeKSxYubrslUCDmSbzlPapSW9Bgb5rxZEhjQBOdJuBkii2uIxDiiISHDaMkDdQY\n\tVQlE/OyMjbJlkodCX6jUOaRsH0W6oiJEjw8NJOvUTROz0Jz26y+ZGD/3QvgG03FZmM3h\n\t8GtQ==", "X-Gm-Message-State": "ALoCoQkteMEENC9OEc4ZCAgxRm8movRp04nuHXS+YRIfXfXGpDVjv5d1+3hleZUh8qKKiEHLaUO3", "X-Received": "by 10.194.119.230 with SMTP id kx6mr1493072wjb.80.1416524348216; \n\tThu, 20 Nov 2014 14:59:08 -0800 (PST)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Date": "Thu, 20 Nov 2014 23:58:47 +0100", "Message-Id": "<1416524335-22753-6-git-send-email-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1416524335-22753-1-git-send-email-olivier.matz@6wind.com>", "References": "<1415984609-2484-1-git-send-email-olivier.matz@6wind.com>\n\t<1416524335-22753-1-git-send-email-olivier.matz@6wind.com>", "Cc": "jigsaw@gmail.com", "Subject": "[dpdk-dev] [PATCH v3 05/13] mbuf: remove too specific\n\tPKT_TX_OFFLOAD_MASK definition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This definition is specific to Intel PMD drivers and its definition\n\"indicate what bits required for building TX context\" shows that it\nshould not be in the generic rte_mbuf.h but in the PMD driver.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_mbuf/rte_mbuf.h | 5 -----\n lib/librte_pmd_e1000/igb_rxtx.c | 8 +++++++-\n lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 8 +++++++-\n 3 files changed, 14 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex 0c96b00..62d952d 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -124,11 +124,6 @@ extern \"C\" {\n /* Use final bit of flags to indicate a control mbuf */\n #define CTRL_MBUF_FLAG (1ULL << 63) /**< Mbuf contains control data */\n \n-/**\n- * Bit Mask to indicate what bits required for building TX context\n- */\n-#define PKT_TX_OFFLOAD_MASK (PKT_TX_VLAN_PKT | PKT_TX_IP_CKSUM | PKT_TX_L4_MASK)\n-\n /* define a set of marker types that can be used to refer to set points in the\n * mbuf */\n typedef void *MARKER[0]; /**< generic marker for a point in a structure */\ndiff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c\nindex b406397..433c616 100644\n--- a/lib/librte_pmd_e1000/igb_rxtx.c\n+++ b/lib/librte_pmd_e1000/igb_rxtx.c\n@@ -84,6 +84,12 @@\n \t\tETH_RSS_IPV6_UDP | \\\n \t\tETH_RSS_IPV6_UDP_EX)\n \n+/* Bit Mask to indicate what bits required for building TX context */\n+#define IGB_TX_OFFLOAD_MASK (\t\t\t \\\n+\t\tPKT_TX_VLAN_PKT |\t\t \\\n+\t\tPKT_TX_IP_CKSUM |\t\t \\\n+\t\tPKT_TX_L4_MASK)\n+\n static inline struct rte_mbuf *\n rte_rxmbuf_alloc(struct rte_mempool *mp)\n {\n@@ -400,7 +406,7 @@ eth_igb_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\tol_flags = tx_pkt->ol_flags;\n \t\tvlan_macip_lens.f.vlan_tci = tx_pkt->vlan_tci;\n \t\tvlan_macip_lens.f.l2_l3_len = tx_pkt->l2_l3_len;\n-\t\ttx_ol_req = ol_flags & PKT_TX_OFFLOAD_MASK;\n+\t\ttx_ol_req = ol_flags & IGB_TX_OFFLOAD_MASK;\n \n \t\t/* If a Context Descriptor need be built . */\n \t\tif (tx_ol_req) {\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\nindex 7e470ce..ca35db2 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n@@ -90,6 +90,12 @@\n \t\tETH_RSS_IPV6_UDP | \\\n \t\tETH_RSS_IPV6_UDP_EX)\n \n+/* Bit Mask to indicate what bits required for building TX context */\n+#define IXGBE_TX_OFFLOAD_MASK (\t\t\t \\\n+\t\tPKT_TX_VLAN_PKT |\t\t \\\n+\t\tPKT_TX_IP_CKSUM |\t\t \\\n+\t\tPKT_TX_L4_MASK)\n+\n static inline struct rte_mbuf *\n rte_rxmbuf_alloc(struct rte_mempool *mp)\n {\n@@ -580,7 +586,7 @@ ixgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\tol_flags = tx_pkt->ol_flags;\n \n \t\t/* If hardware offload required */\n-\t\ttx_ol_req = ol_flags & PKT_TX_OFFLOAD_MASK;\n+\t\ttx_ol_req = ol_flags & IXGBE_TX_OFFLOAD_MASK;\n \t\tif (tx_ol_req) {\n \t\t\tvlan_macip_lens.f.vlan_tci = tx_pkt->vlan_tci;\n \t\t\tvlan_macip_lens.f.l2_l3_len = tx_pkt->l2_l3_len;\n", "prefixes": [ "dpdk-dev", "v3", "05/13" ] }