List comments

GET /api/patches/140/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 348,
        "web_url": "https://patches.dpdk.org/comment/348/",
        "msgid": "<53E9CFF8.6060002@6wind.com>",
        "date": "2014-08-12T08:27:36",
        "subject": "Re: [dpdk-dev] [RFC PATCH 02/14] mbuf: remove rte_ctrlmbuf",
        "submitter": {
            "id": 8,
            "url": "https://patches.dpdk.org/api/people/8/",
            "name": "Olivier Matz",
            "email": "olivier.matz@6wind.com"
        },
        "content": "Hi Bruce,\n\nOn 08/11/2014 10:44 PM, Bruce Richardson wrote:\n> From: Olivier Matz <olivier.matz@6wind.com>\n>\n> The initial role of rte_ctrlmbuf is to carry generic messages (data\n> pointer + data length) but it's not used by the DPDK or it applications.\n> Keeping it implies:\n>    - loosing 1 byte in the rte_mbuf structure\n>    - having some dead code rte_mbuf.[ch]\n>\n> This patch removes this feature. Thanks to it, it is now possible to\n> simplify the rte_mbuf structure by merging the rte_pktmbuf structure\n> in it. This is done in next commit.\n>\n> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>\n>\n> Conflicts:\n> \tlib/librte_pmd_vmxnet3/vmxnet3_rxtx.c\n>\n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nSame here, \"git grep ctrlmbuf\" finds results in\nexamples/ip_pipeline/cmdline.c and examples/ip_pipeline/init.c\n\nYou can also see it by doing\n\"make examples T=x86_64-native-linuxapp-gcc\" from dpdk root.\n\n\n> @@ -204,14 +182,10 @@ struct rte_mbuf {\n>   #else\n>   \tuint16_t refcnt_reserved;     /**< Do not use this field */\n>   #endif\n> -\tuint8_t type;                 /**< Type of mbuf. */\n> -\tuint8_t reserved;             /**< Unused field. Required for padding. */\n> +\tuint16_t reserved;             /**< Unused field. Required for padding. */\n\nThis line breaks the alignment of comments (this typo was already\npresent in my initial patch). By the way, there was also a patch\ncalled \"mbuf: cosmetic changes in rte_mbuf structure\" to restore\nthe comments alignment for all the fields of the structure. Maybe\nit should be integrated in your series.\n\nRegards,\nOlivier",
        "headers": {
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Content-Transfer-Encoding": "7bit",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:message-id:date:from:user-agent:mime-version:to\n\t:subject:references:in-reply-to:content-type\n\t:content-transfer-encoding;\n\tbh=MqZTOHhQA11A/00KAy+j+QFam1ZEpOhC2ODhTm4uB1Y=;\n\tb=eqQnQdRkdTgLOoraWNO0OZEVYJdD2rczYCvd4RlmjzvHjxYmFAx4Cpxc4vQgZpTKJY\n\tkvkopDWaJ4r7orHQ9tjsRGdc4ar6S2P0FgUEuA1ut8HbXvO1KuDfcreBcExIdHTWODCU\n\toKqvBuptcLimFhBETsW89WaYRsDJCAzCgZDc/EAnBIBZ42c9kyiE4peg1uyQb0rNPsx6\n\tFHybKciKetu9Vmc50SdCFZ1jPORzvNaAMVn4DW12mPC5wgx3Nhx7cg/hARiWh1blv6De\n\tYUqx5U+2o5kVDTjj6ZavqomtVpiU7zsYY5yRDUbuLO8GwlCBUE6dJPlOaaD82yx23Xrx\n\tntVg==",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Date": "Tue, 12 Aug 2014 10:27:36 +0200",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1407789890-17355-1-git-send-email-bruce.richardson@intel.com>\n\t<1407789890-17355-3-git-send-email-bruce.richardson@intel.com>",
            "In-Reply-To": "<1407789890-17355-3-git-send-email-bruce.richardson@intel.com>",
            "X-Gm-Message-State": "ALoCoQk6Z086ibavoS1+9BTw6isoR5meyt4P8lETFL6MmpdwdaKVMbUDphJl4EcBzjmW0hvPn/u5",
            "Content-Type": "text/plain; charset=ISO-8859-1; format=flowed",
            "To": "Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org",
            "User-Agent": "Mozilla/5.0 (X11; Linux x86_64;\n\trv:24.0) Gecko/20100101 Icedove/24.5.0",
            "MIME-Version": "1.0",
            "Received": [
                "from mail-we0-f182.google.com (mail-we0-f182.google.com\n\t[74.125.82.182]) by dpdk.org (Postfix) with ESMTP id AEA0CB39D\n\tfor <dev@dpdk.org>; Tue, 12 Aug 2014 10:24:44 +0200 (CEST)",
                "by mail-we0-f182.google.com with SMTP id k48so9613981wev.13\n\tfor <dev@dpdk.org>; Tue, 12 Aug 2014 01:27:39 -0700 (PDT)",
                "from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tft17sm7631219wjc.14.2014.08.12.01.27.37 for <multiple recipients>\n\t(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);\n\tTue, 12 Aug 2014 01:27:37 -0700 (PDT)"
            ],
            "From": "Olivier MATZ <olivier.matz@6wind.com>",
            "Message-ID": "<53E9CFF8.6060002@6wind.com>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Subject": "Re: [dpdk-dev] [RFC PATCH 02/14] mbuf: remove rte_ctrlmbuf",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-List-Received-Date": "Tue, 12 Aug 2014 08:24:44 -0000",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Return-Path": "<olivier.matz@6wind.com>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-Received": "by 10.194.92.148 with SMTP id cm20mr3703872wjb.57.1407832059005; \n\tTue, 12 Aug 2014 01:27:39 -0700 (PDT)",
            "X-Mailman-Version": "2.1.15"
        }
    }
]