Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139995/?format=api
{ "id": 139995, "url": "https://patches.dpdk.org/api/patches/139995/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240508105713.3207940-1-psatheesh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240508105713.3207940-1-psatheesh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240508105713.3207940-1-psatheesh@marvell.com", "date": "2024-05-08T10:57:13", "name": "common/cnxk: fix flow aging cleanup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7ffc3d91d69f192e2b067e74b1fc746433bdbbc7", "submitter": { "id": 1663, "url": "https://patches.dpdk.org/api/people/1663/?format=api", "name": "Satheesh Paul Antonysamy", "email": "psatheesh@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240508105713.3207940-1-psatheesh@marvell.com/mbox/", "series": [ { "id": 31894, "url": "https://patches.dpdk.org/api/series/31894/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31894", "date": "2024-05-08T10:57:13", "name": "common/cnxk: fix flow aging cleanup", "version": 1, "mbox": "https://patches.dpdk.org/series/31894/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139995/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139995/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3728143FDF;\n\tWed, 8 May 2024 12:57:24 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5CAD6436AD;\n\tWed, 8 May 2024 12:57:23 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 4D653432C4;\n Wed, 8 May 2024 12:57:21 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id\n 4489OOTU007954;\n Wed, 8 May 2024 03:57:20 -0700", "from dc5-exch05.marvell.com ([199.233.59.128])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3xysfnjya7-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 08 May 2024 03:57:20 -0700 (PDT)", "from DC5-EXCH05.marvell.com (10.69.176.209) by\n DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1544.4; Wed, 8 May 2024 03:57:19 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com\n (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend\n Transport; Wed, 8 May 2024 03:57:19 -0700", "from cavium-OptiPlex-3070-BM17.. (unknown [10.28.34.33])\n by maili.marvell.com (Postfix) with ESMTP id 8A3D83F7091;\n Wed, 8 May 2024 03:57:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding:content-type; s=pfpt0220; bh=NrmXG5m0\n ibmFXyxQg9yIy4pd985+IETTqFKjwk7tT3A=; b=HwBqysowLKT3HxLbiwE5I/CA\n GSyIDn4OdnOfeHi+b4OVYJxcJ1azBGtkxJzVOvuFeFSgErzy6iFUFploUTYgxqrL\n 8LnKqqv8O0f7M5qnv3UIjKPYoPhk6+tANgjyFgDojyo/QBeNDdpETvcQBD39oDv5\n Q1XPbE1ISr6SNeeZnu6hk1mQKs39SEZpEFAKgg+MLU1NVzIBCNzH9X0bRfcbXWaI\n lv8BjGRgjcZGJcQqINfJ9wR5Wz9603yHQvnwWq4AKdAqi18IaQ+OCwwB8R3CPAB3\n FuaOChmC557w3bH1O9ulus5x3mzz8Rr4LwEy+43kHpk0Ao7Rdzv6AKu4Nic4vQ==", "From": "<psatheesh@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>, Harman Kalra <hkalra@marvell.com>", "CC": "<dev@dpdk.org>, Satheesh Paul <psatheesh@marvell.com>, <stable@dpdk.org>", "Subject": "[dpdk-dev] [PATCH] common/cnxk: fix flow aging cleanup", "Date": "Wed, 8 May 2024 16:27:13 +0530", "Message-ID": "<20240508105713.3207940-1-psatheesh@marvell.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "u1njhzXOIxtx9jmXVp580kZTlmi3AaJs", "X-Proofpoint-GUID": "u1njhzXOIxtx9jmXVp580kZTlmi3AaJs", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26\n definitions=2024-05-08_07,2024-05-08_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Satheesh Paul <psatheesh@marvell.com>\n\nThe aged flows poll thread is not stopped before NPC cleanup\nresulting in a segmentation fault. Fixing this by stopping\naged flows poll thread before proceeding with NPC cleanup.\n\nFixes: 357f5ebc8a24 (\"common/cnxk: support flow aging\")\nCc: stable@dpdk.org\n\nSigned-off-by: Satheesh Paul <psatheesh@marvell.com>\nReviewed-by: Kiran Kumar K <kirankumark@marvell.com>\n---\n drivers/common/cnxk/roc_npc.c | 5 +++--\n drivers/common/cnxk/roc_npc_aging.c | 8 +++++---\n 2 files changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c\nindex d6ad3756bb..37e1a6a7ef 100644\n--- a/drivers/common/cnxk/roc_npc.c\n+++ b/drivers/common/cnxk/roc_npc.c\n@@ -389,6 +389,8 @@ roc_npc_fini(struct roc_npc *roc_npc)\n \tstruct npc *npc = roc_npc_to_npc_priv(roc_npc);\n \tint rc;\n \n+\tnpc_aging_ctrl_thread_destroy(roc_npc);\n+\n \trc = npc_flow_free_all_resources(npc);\n \tif (rc) {\n \t\tplt_err(\"Error when deleting NPC MCAM entries, counters\");\n@@ -1810,8 +1812,7 @@ roc_npc_flow_destroy(struct roc_npc *roc_npc, struct roc_npc_flow *flow)\n \tif (flow->has_age_action)\n \t\tnpc_age_flow_list_entry_delete(roc_npc, flow);\n \n-\tif (roc_npc->flow_age.age_flow_refcnt == 0 &&\n-\t\tplt_thread_is_valid(roc_npc->flow_age.aged_flows_poll_thread))\n+\tif (roc_npc->flow_age.age_flow_refcnt == 0)\n \t\tnpc_aging_ctrl_thread_destroy(roc_npc);\n \n done:\ndiff --git a/drivers/common/cnxk/roc_npc_aging.c b/drivers/common/cnxk/roc_npc_aging.c\nindex e0f2dc2291..15f6e61d76 100644\n--- a/drivers/common/cnxk/roc_npc_aging.c\n+++ b/drivers/common/cnxk/roc_npc_aging.c\n@@ -303,9 +303,11 @@ npc_aging_ctrl_thread_destroy(struct roc_npc *roc_npc)\n \tstruct roc_npc_flow_age *flow_age;\n \n \tflow_age = &roc_npc->flow_age;\n-\tflow_age->aged_flows_get_thread_exit = true;\n-\tplt_thread_join(flow_age->aged_flows_poll_thread, NULL);\n-\tnpc_aged_flows_bitmap_free(roc_npc);\n+\tif (plt_thread_is_valid(flow_age->aged_flows_poll_thread)) {\n+\t\tflow_age->aged_flows_get_thread_exit = true;\n+\t\tplt_thread_join(flow_age->aged_flows_poll_thread, NULL);\n+\t\tnpc_aged_flows_bitmap_free(roc_npc);\n+\t}\n }\n \n void *\n", "prefixes": [] }