Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139986/?format=api
{ "id": 139986, "url": "https://patches.dpdk.org/api/patches/139986/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240507124305.2318-23-venkatkumar.ande@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240507124305.2318-23-venkatkumar.ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240507124305.2318-23-venkatkumar.ande@amd.com", "date": "2024-05-07T12:43:03", "name": "[v2,23/25] net/axgbe: fix the false linkup in axgbe PHY status", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "e8fb2062e871523d7fd1ccba8261f69ba76a6124", "submitter": { "id": 3256, "url": "https://patches.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240507124305.2318-23-venkatkumar.ande@amd.com/mbox/", "series": [ { "id": 31890, "url": "https://patches.dpdk.org/api/series/31890/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31890", "date": "2024-05-07T12:42:41", "name": "[v2,01/25] net/axgbe: fix mdio access for non-zero ports and CL45 PHYs", "version": 2, "mbox": "https://patches.dpdk.org/series/31890/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139986/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139986/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9EFF143FC9;\n\tTue, 7 May 2024 14:46:21 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D49B94338B;\n\tTue, 7 May 2024 14:44:42 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2055.outbound.protection.outlook.com [40.107.92.55])\n by mails.dpdk.org (Postfix) with ESMTP id CEDFB433C0;\n Tue, 7 May 2024 14:44:40 +0200 (CEST)", "from PR2P264CA0002.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::14) by\n DS0PR12MB9039.namprd12.prod.outlook.com (2603:10b6:8:de::21) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7544.41; Tue, 7 May 2024 12:44:37 +0000", "from SN1PEPF00036F42.namprd05.prod.outlook.com\n (2603:10a6:101:0:cafe::25) by PR2P264CA0002.outlook.office365.com\n (2603:10a6:101::14) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend\n Transport; Tue, 7 May 2024 12:44:36 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n SN1PEPF00036F42.mail.protection.outlook.com (10.167.248.26) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7544.18 via Frontend Transport; Tue, 7 May 2024 12:44:36 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May\n 2024 07:44:28 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=S0yDblOMXvmGMQsNJrxHM0d/8mQr3u/Lo5l8O/1txnnnFZXdp9WyhQet/06YZ3EQJranNsxey3BGzlfXrrfMMilHO33E779O65XpRYXUCTyIlvso8AdRdNWiPXE8rj189VHhTtashvc15EbgD6FCJE4LFouAH62jF+XuPUxdVLBkW/3b/2GPUxcrFOVyrAD28eg95vErHMw12rGjfcCG5q52OxaVUuuamtH3OIsMIYmovTTEqtRN6P6WRitKEelerBH3uvqjhAul9HQ3wGKTczyNBxeh2meto4Lf/w6YZRVqjn7/ofntFZrxvr2myrweBXtQ17Bvs2EkpCDsNRAmZw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=daOCjbN5Y1j/CO3DYdSNbANIUhg+AgINEDMsQKPOXu0=;\n b=EOK41WZBfGWWFizClolbyWVPiGahWeFsQIjRM8fOLF3ldcRWNX+5YiiqAdZ7rtYclQhAlCocCNUAwuiPLaF5NdnOSmeUT92tEV+BzA3oZd0RxKgfMrTNiCH9ir1XnMm35/JLShYbse/j2sKt7FjFypbjVA/6uJsWT6BWG2Lq+KLtPPgg4KmOPRi8ycXJoxP2n1iKux8PtIZHOthS5mp6jsGp6UPIyvczl53qnKSxPu3Cs1Er1eIfcPEVgd0L9nXJjNzqG9yNe28csVfxMrty0Il90miH85k8AR6tvbUa6WFZzqNyqiEHjmUVhinDdWeydSeq9PdzZ8zbcTrM0Y1G+Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=daOCjbN5Y1j/CO3DYdSNbANIUhg+AgINEDMsQKPOXu0=;\n b=NOF1ybdqPzrJ6IIXjhkf4W5MovxLPxnG+8K4sbhedHiqaWyYrQTyP/jmsDfz1d4dce9v3owdBphLwtQKB7GjrGd6aHs6mA1DjbzbueRdZBupqtMskRo1h5Cy0c5sqQHDf7hrZ5pc2G5wgYGJHqrO82APpUuUJS1abgJjTxQ0iWM=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <venkatkumar.ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <venkatkumar.ande@amd.com>,\n <stable@dpdk.org>", "Subject": "[PATCH v2 23/25] net/axgbe: fix the false linkup in axgbe PHY status", "Date": "Tue, 7 May 2024 18:13:03 +0530", "Message-ID": "<20240507124305.2318-23-venkatkumar.ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240507124305.2318-1-venkatkumar.ande@amd.com>", "References": "<20240412125013.10498-1-VenkatKumar.Ande@amd.com>\n <20240507124305.2318-1-venkatkumar.ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SN1PEPF00036F42:EE_|DS0PR12MB9039:EE_", "X-MS-Office365-Filtering-Correlation-Id": "f15f7a07-76fc-4103-00b2-08dc6e9373f7", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|36860700004|82310400017|1800799015|376005;", "X-Microsoft-Antispam-Message-Info": "\n O7/NW0y5wlRHJDb/7bNg3gk3xGnthEZMWzdhZo9guXsnLpEB/S1oZ/fjpmsu+B5iqaeST7hkV/yZCStXRnVgJFSakEmTAbRra2U6oITzrc3KhQ9WKY+cb3XYXrA3Lxiv3IOa474bfMJGx7wukrJwKnpB1zU04P7eX5tuAyX+W91xyQeTQn5pKlWdYdWb67FDlyicx80q8JdeH/8v6MSrLqRyCEveBlB6El2zgLcmfSXA11W5YvThAQ3wftZ3hVMeoSTUkTTWGdRaHRTSh5f8AKy/x0mekYJMDsIj90sPgykjspPHkOUfq+cYB29uWfHZ0oTyWSJMnOcJy7LgCdb1rRWof7AdMNYP7J7luEbOUbqltfmlTK3iXJryoNZXTPQTlBlPA2Q4GbJ/BZUMesj6aHoh1azNv1jeFtWaFqdTxWM9Jln33d3XJb8uMq8xnjkEYpInjJMPysntJd2CspZAzXs7qR3eUBUUP4BqwLpz6EHtp4z6gmKs6qhqyX+phTf+/jgxj72aqPOdj4/Z1+nLU8QGRtgf5n5Q7Bb2bBEYdKdvwhDszPWTdE4OiacmEk3Un0pVSX6UpbDC2bpzgdRA9rOiZOKc7pkR8GYC3xj/GSF4IgpjCqf6zTlC1WK8/KhKtBsn6tFJ1pCJQKRlay6mcBHW3OmPGI3u63reMOEWei4alW6rKLUDw1TJicTDnDYjTBH/dIuE0I1EXx8phG1TwxY5QbAEpypy+YPpuLlvXIp7zGffciofhzX3G2P9z7tcVMebxerEIcc2RejzZd/+G1MyIoOZm2yIPoxZLknxxf5xo+VYdcb+CB6QAA2Hv7Rde1N0H5HSPnoIofsYA3SfvTofU1B2DeIOXf61ynQ2O7Grf8H5AWnRypWUwjKj+pYpU6jcQTAhi5ZYKkuifH69JvZ/sRmF8tPfiFpDxnEM1Le5PkYowADgxn5GzyrgG07VOT/dp10Y4Bu4b8vqmkKXOKtWsBo4LGzUsjhD/j0Cu/JioYxtpTM+4FsY3cRm3yTx1f8LaDVjTQKfxAB6UM5PYIBtrmhWVBExlIQEEI5Z83oFw+2KeNO+IeqEtCqgEqkhOJQYfvDngHZ865jKahZPWNBDxznqpUFnv/P1z1Lk7r43Lh1ucZJTdMcWI3+go8mR3Qd5xCs2c5m/ANZKr2auz05khJRluMdRunXI0fqbJ2p0G4R1Ua07nEMPm8YJ6POU3eu6RrfqILDzvtUDa1eFDf/kVg8k5Usm1X3sw7oV6AV1Bv7SBcgC2ZKENhJ0VhsXtFPlEIxXOaX9iUrch6SWg4LgC+Wyc1ebOUIIJ/CkF+atW80hcgUPaJ0rXiEOHxZkYGjytp7f3Xy3QhrtoYuXt4fmtODru90In6Od7P4kPVrzF6dcm43lQUTyNnl7XbDD", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(36860700004)(82310400017)(1800799015)(376005); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 May 2024 12:44:36.3801 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n f15f7a07-76fc-4103-00b2-08dc6e9373f7", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SN1PEPF00036F42.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DS0PR12MB9039", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In the event of a change in AXGBE mode, the current auto-negotiation\nneeds to be reset and the AN cycle needs to be re-triggered. However,\nthe current code ignores the return value of axgbe_set_mode(), leading to\nfalse information as the link is declared without checking the status\nregister.\n\nFix this by propagating the mode switch status information to\naxgbe_phy_status().\n\nFixes: 102b6ec3d5c3 (\"net/axgbe: support auto-negotiation for 1Gbps\")\nCc: stable@dpdk.org\n\nSigned-off-by: Venkat Kumar Ande <venkatkumar.ande@amd.com>\n---\n drivers/net/axgbe/axgbe_mdio.c | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_mdio.c b/drivers/net/axgbe/axgbe_mdio.c\nindex 9fe30e83bc..130a67479e 100644\n--- a/drivers/net/axgbe/axgbe_mdio.c\n+++ b/drivers/net/axgbe/axgbe_mdio.c\n@@ -1028,7 +1028,7 @@ static enum axgbe_mode axgbe_phy_status_aneg(struct axgbe_port *pdata)\n \treturn pdata->phy_if.phy_impl.an_outcome(pdata);\n }\n \n-static void axgbe_phy_status_result(struct axgbe_port *pdata)\n+static bool axgbe_phy_status_result(struct axgbe_port *pdata)\n {\n \tenum axgbe_mode mode;\n \n@@ -1065,8 +1065,13 @@ static void axgbe_phy_status_result(struct axgbe_port *pdata)\n \n \tpdata->phy.duplex = DUPLEX_FULL;\n \n-\tif (axgbe_set_mode(pdata, mode) && pdata->an_again)\n+\tif (!axgbe_set_mode(pdata, mode))\n+\t\treturn false;\n+\n+\tif (pdata->an_again)\n \t\taxgbe_phy_reconfig_aneg(pdata);\n+\n+\treturn true;\n }\n \n static int autoneg_time_out(unsigned long autoneg_start_time)\n@@ -1133,7 +1138,10 @@ static void axgbe_phy_status(struct axgbe_port *pdata)\n \t\t\t\treturn;\n \t\t\t}\n \t\t}\n-\t\taxgbe_phy_status_result(pdata);\n+\n+\t\tif (axgbe_phy_status_result(pdata))\n+\t\t\treturn;\n+\n \t\tif (rte_bit_relaxed_get32(AXGBE_LINK_INIT, &pdata->dev_state))\n \t\t\trte_bit_relaxed_clear32(AXGBE_LINK_INIT,\n \t\t\t\t\t\t&pdata->dev_state);\n", "prefixes": [ "v2", "23/25" ] }