Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139972/?format=api
{ "id": 139972, "url": "https://patches.dpdk.org/api/patches/139972/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240507124305.2318-9-venkatkumar.ande@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240507124305.2318-9-venkatkumar.ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240507124305.2318-9-venkatkumar.ande@amd.com", "date": "2024-05-07T12:42:49", "name": "[v2,09/25] net/axgbe: fix logic around active and passive cables", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "fa58ba54c6d71de30f23b5ceefc2e09bc21db8a2", "submitter": { "id": 3256, "url": "https://patches.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240507124305.2318-9-venkatkumar.ande@amd.com/mbox/", "series": [ { "id": 31890, "url": "https://patches.dpdk.org/api/series/31890/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31890", "date": "2024-05-07T12:42:41", "name": "[v2,01/25] net/axgbe: fix mdio access for non-zero ports and CL45 PHYs", "version": 2, "mbox": "https://patches.dpdk.org/series/31890/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139972/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139972/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6387343FC9;\n\tTue, 7 May 2024 14:44:46 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E336F433D1;\n\tTue, 7 May 2024 14:44:03 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2087.outbound.protection.outlook.com [40.107.236.87])\n by mails.dpdk.org (Postfix) with ESMTP id 77D50433B8;\n Tue, 7 May 2024 14:43:58 +0200 (CEST)", "from PH7PR17CA0066.namprd17.prod.outlook.com (2603:10b6:510:325::15)\n by DM6PR12MB4283.namprd12.prod.outlook.com (2603:10b6:5:211::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.43; Tue, 7 May\n 2024 12:43:56 +0000", "from SN1PEPF00036F3D.namprd05.prod.outlook.com\n (2603:10b6:510:325:cafe::7f) by PH7PR17CA0066.outlook.office365.com\n (2603:10b6:510:325::15) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.43 via Frontend\n Transport; Tue, 7 May 2024 12:43:55 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n SN1PEPF00036F3D.mail.protection.outlook.com (10.167.248.21) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7544.18 via Frontend Transport; Tue, 7 May 2024 12:43:55 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May\n 2024 07:43:53 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Ngd0vihhvaiSKYuMf9VwJKfcnLoWQWdyaoqOGBAdbu9GSryVJ8uIjBpxABeZ9xPOhMua5qVzxV7lx/dOgHsQPtUx9vqyVEX6YtXYOM17ZHURtR9A65j48z0GlaQOo/L/4XMI79FbVj7Q+/x/Edu4QaJTBtYFVMbzqXWOkyOEGxh2RpDfSw6b02nsXFPSx6uXKaolA3ee5X55ZlcW3eykBmmd+qKl8D7zISs4B6rwNETiLvRkk23kd7O6xa1XgvX7XAJC5b+gdnXPdvoOCA7aAL+tVj1Y+P6BF4X2UItVp4iMraF291OXSrT0jW4NeAItu9CmEYo+qr2wi7r4zoL8yw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=9KcyhoDkRwo6jfboYdJ8C8hazj3+nUQxbbb1yoL521U=;\n b=Wx65IUS1K/3mMD1CnYe/FoH/H915kBFfjlpylkqDxC5LZnosjjrUl+MNpP+PF1QRMhhMX5I6mkaQVBcuSbBdSoX2NpjwUbyqT7VtLYd812s85N/GaNLa7L2t8YrNaAn6Vp2d3P/rI2vm5QG2ARG1H6eS+r4MDBcqleztXIReRSflLP7zv1W9/I9XdTqzBIbeigdNzBsx+oKffH6v1k78AejxHHkrHJEgcN1KZnKe/SiU6qdVqe/k1Kbnzk6V8ypqTVqwdYuxgiaeYcron79FnyoV8nUvhMuOmbEs4qHbwLQUK+LtqjGi5/OcKsDbc/bFJJKfzwftGX4CQOStKh7irw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=9KcyhoDkRwo6jfboYdJ8C8hazj3+nUQxbbb1yoL521U=;\n b=2aqic2r35FjGAxmfT/7RhsB+WvW0JwcDyUjqus3E9VhF0F406SFsbzy7Vrdo5R8SLZXSYlYiuN2anGGSWvobs7gQm4PD8QiXJ1JxnVg2FQyeDZvT4SLAGSkWh+knueu55Lxb2RwaFoTcwYUyxZ4U6CC/p6s7V7qxYaUa9/O7fS8=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <venkatkumar.ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <venkatkumar.ande@amd.com>,\n <stable@dpdk.org>", "Subject": "[PATCH v2 09/25] net/axgbe: fix logic around active and passive\n cables", "Date": "Tue, 7 May 2024 18:12:49 +0530", "Message-ID": "<20240507124305.2318-9-venkatkumar.ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240507124305.2318-1-venkatkumar.ande@amd.com>", "References": "<20240412125013.10498-1-VenkatKumar.Ande@amd.com>\n <20240507124305.2318-1-venkatkumar.ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SN1PEPF00036F3D:EE_|DM6PR12MB4283:EE_", "X-MS-Office365-Filtering-Correlation-Id": "7daf96df-34c1-4369-a71d-08dc6e935bc1", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|376005|1800799015|36860700004|82310400017;", "X-Microsoft-Antispam-Message-Info": "\n eaN/sjo7mmobuFqtZ/h9pPUDvEkRZmsP8QV4bUjrN4iMX/6CCODBYXinZdozuflPDFzjA3ojgLh1IL7WD2gt7/Rvr2MhRuUDKFFR+9xRezJCn4cUPW/qjRDan9wH0A1h0glwDZMaqj6DxHrXEtpGCM1c0f6QDwb25wEHe8ptTaV+OZlpRLNbll3ZySq5taEK0h4WGkpE5M0UiURi5nWD6EMc0KJOQJBSrIASpqzCTNI4QmJgdJnO1793Y16F2UdasvA+JqOezaxdQtiSeGMNx8m3jvC67F/WdxWSaSZTnACTvURar6nb78lCK3dm0GQRC/t6Y/li5YKjVunHp9G8m7hutD6/Dmeb12vMXW4WMZO0SsWobrc7xDxzm3xzVwX6Je15hI/mlEuUlYIVhxdSnW/WQQq1ppRZxcxi/Ma9E3Sol2UYY/YxHHVp5WW8wGTNvvsVXf53yNwALSGYh8/5dCko3t8UmZCIWf/DXskhuyPoxqsK7JQ9iv9MQlpVOcw+w0MNtZ9bFP5rMtTohuPqmb49NdFVOxAAvZDXPfnOGmip1Qmg7Y0fNcHGWCeUasq1fI3Rs5e1Z9ZURRYBk8zQ55fUT4xJsA9Wq8MmICMEPyRdiuOoXkztNlQndax7yP3LhWqACrBnQC090FRhnNln9VDj7GX2muiZmQk2ydErqrKjEcvupNVgshT+6CNZPJVVLK/j7qfTpN5svExgRrwaZJmZe4+VjTX2/aFOGuxdmJXk5T5eoTmYfHKEMKF34ZRn23uWkIr27dVym1tlBuHAIRTiKBjEZqBOWG/ihPjnJLxX4eFUOWTeGAIBoQdcZLTLYWnj5LzLHK0Bqnw5PLbKdUNsPMidbRqCVSbp+tB2q2hJxXd27V/7g5c3HHwNUcOvqZKIggfjR4DCVpDdpbvCD/rfobyG7D59BurK1tAdIEWCOsU15JqNhzjyq0YAIFF/gbJPMSVVdrOt4ZsJ670z732Rn29TDi2lDBLilQdGKoWReh1LMYjwsh4wdP0sKWT8PXb7V9m3J8y7cDw+NocPwDiPXzMyFaaWJ5ewJdkISIQzQkLQ95rDKFaV5zlj96Y95qumTfCcafUQlJU0/CDVroA5qdV73iXwG9DnADvFVQ0lcFsnd7Ux4zNmNAQtEClGBILYvBxkeregZs3dTWc0lEV3gcNnpcII9gxtAQ2178+ZsqsLZzVTkcE+EZOpoya29vytVKpsClzwtKWUA8pB8KyyuktqTJ+J4vPrXuf9eU5XyhRTwse1E6X8hgx29imdf7AMkHL7PFtIZIPfoV3t5xF3pySBGA0wmlUzv6iGnB3x6kq1Wf07PQ3ftO1QHVH67Ndr45UAliDIDKCQZxOntZrUrpe+NFZJuNgnpiLlKBR78+eIKvVdfdhFtNAnMJBM", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(376005)(1800799015)(36860700004)(82310400017); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 May 2024 12:43:55.7808 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7daf96df-34c1-4369-a71d-08dc6e935bc1", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SN1PEPF00036F3D.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB4283", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "SFP+ active and passive cables are copper cables with fixed SFP+ end\nconnectors. Due to a misinterpretation of this, SFP+ active cables could\nend up not being recognized, causing the driver to fail to establish a\nconnection.\n\nIntroduce a new enum in SFP+ cable types, XGBE_SFP_CABLE_FIBER, that is\nthe default cable type, and handle active and passive cables when they are\nspecifically detected.\n\nFixes: a5c7273771e8 (\"net/axgbe: add phy programming APIs\")\nCc: stable@dpdk.org\n\nSigned-off-by: Venkat Kumar Ande <venkatkumar.ande@amd.com>\n---\n drivers/net/axgbe/axgbe_phy_impl.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex d4c4a89517..8b66def631 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -69,6 +69,7 @@ enum axgbe_sfp_cable {\n \tAXGBE_SFP_CABLE_UNKNOWN = 0,\n \tAXGBE_SFP_CABLE_ACTIVE,\n \tAXGBE_SFP_CABLE_PASSIVE,\n+\tAXGBE_SFP_CABLE_FIBER,\n };\n \n enum axgbe_sfp_base {\n@@ -616,16 +617,18 @@ static void axgbe_phy_sfp_parse_eeprom(struct axgbe_port *pdata)\n \n \taxgbe_phy_sfp_parse_quirks(pdata);\n \n-\t/* Assume ACTIVE cable unless told it is PASSIVE */\n+\t/* Assume FIBER cable unless told otherwise */\n \tif (sfp_base[AXGBE_SFP_BASE_CABLE] & AXGBE_SFP_BASE_CABLE_PASSIVE) {\n \t\tphy_data->sfp_cable = AXGBE_SFP_CABLE_PASSIVE;\n \t\tphy_data->sfp_cable_len = sfp_base[AXGBE_SFP_BASE_CU_CABLE_LEN];\n-\t} else {\n+\t} else if (sfp_base[AXGBE_SFP_BASE_CABLE] & AXGBE_SFP_BASE_CABLE_ACTIVE) {\n \t\tphy_data->sfp_cable = AXGBE_SFP_CABLE_ACTIVE;\n+\t} else {\n+\t\tphy_data->sfp_cable = AXGBE_SFP_CABLE_FIBER;\n \t}\n \n \t/* Determine the type of SFP */\n-\tif (phy_data->sfp_cable == AXGBE_SFP_CABLE_PASSIVE &&\n+\tif (phy_data->sfp_cable != AXGBE_SFP_CABLE_FIBER &&\n \t\t axgbe_phy_sfp_bit_rate(sfp_eeprom, AXGBE_SFP_SPEED_10000))\n \t\tphy_data->sfp_base = AXGBE_SFP_BASE_10000_CR;\n \telse if (sfp_base[AXGBE_SFP_BASE_10GBE_CC] & AXGBE_SFP_BASE_10GBE_CC_SR)\n", "prefixes": [ "v2", "09/25" ] }