Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139969/?format=api
{ "id": 139969, "url": "https://patches.dpdk.org/api/patches/139969/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240507124305.2318-6-venkatkumar.ande@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240507124305.2318-6-venkatkumar.ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240507124305.2318-6-venkatkumar.ande@amd.com", "date": "2024-05-07T12:42:46", "name": "[v2,06/25] net/axgbe: yellow carp devices do not need rrc", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "a14fcf7b07f30f4e9bd543d3e1f423f1d788d6ac", "submitter": { "id": 3256, "url": "https://patches.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240507124305.2318-6-venkatkumar.ande@amd.com/mbox/", "series": [ { "id": 31890, "url": "https://patches.dpdk.org/api/series/31890/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31890", "date": "2024-05-07T12:42:41", "name": "[v2,01/25] net/axgbe: fix mdio access for non-zero ports and CL45 PHYs", "version": 2, "mbox": "https://patches.dpdk.org/series/31890/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139969/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139969/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9743243FC9;\n\tTue, 7 May 2024 14:44:22 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 21924433B6;\n\tTue, 7 May 2024 14:43:56 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2079.outbound.protection.outlook.com [40.107.223.79])\n by mails.dpdk.org (Postfix) with ESMTP id 24F85433A5;\n Tue, 7 May 2024 14:43:53 +0200 (CEST)", "from SA1P222CA0010.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:22c::12)\n by IA0PR12MB8351.namprd12.prod.outlook.com (2603:10b6:208:40e::5)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Tue, 7 May\n 2024 12:43:48 +0000", "from SN1PEPF00036F40.namprd05.prod.outlook.com\n (2603:10b6:806:22c:cafe::7d) by SA1P222CA0010.outlook.office365.com\n (2603:10b6:806:22c::12) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend\n Transport; Tue, 7 May 2024 12:43:47 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n SN1PEPF00036F40.mail.protection.outlook.com (10.167.248.24) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7544.18 via Frontend Transport; Tue, 7 May 2024 12:43:47 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May\n 2024 07:43:45 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=gAVOQLwCwoG4OPbRvcE1/fh1XKfK31soFCRj3Q5HObpSS9kkr7PxuEojQBwNZjurxDNYyuhMaS4nHR1z94m5iXBdJahTOckCzfuqDqkwahE/cdSNOjU3QHBH7vegz81MQsaVcL0BZ90rIVvE583Jl2X1VT/F0MD8I7KA7dSoDjogwUCZFbPsaMrEWhCzXvXdY3l/MEbdZ4AAu01/PPv9M+Ci2cduKjd6hZEi3NFR1giKp9pyTuNDqSrz4xubiICCDfIjRxmbgjkz2U14MoqPTidlfRK40HsTZBHRiPOO/KuLpe8/NksYfOpVMwR5Do4JTd1g3UZRnY1bveOrcPoL9g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=g6VQZQqpG5NPBEPGBvEJKe0Q+PPM2+Ca+RmPZdwJABU=;\n b=lTh31rtSkX2ZKEIl426BD8FsNQZPCd2NfDxS/RI3z9nDsM6Zf6S4oMrrdiLdIcq0A6w8kC6l+aIA9l4VkEiPYyzY3/KM5Bq/OsfFZu40oVOqgIG+alrda6qDsZcKoDVYAARCAKObV66H8HjSYOcdc4l+K9rlgLd5myHRLlIeY4lL4+BBPK4x34TFViT5XmKpSTlFHf6dWO2C+0/8Uv/Q2WjB3Nyn7/Absz37j0JX/mKfLg1LPxlMun7+INbn/ehqfxz2YliszZ816zXyaKN9+JkYRo7VvUMEjLOZq1pSZDESIXzo8yJjE7YlTzyL8N/daGWm5c6TPggdE4M9Y75RgQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=g6VQZQqpG5NPBEPGBvEJKe0Q+PPM2+Ca+RmPZdwJABU=;\n b=RN82hsf2wS/k5PKRVDlWfzhekN5JfmULrPoey2/ziUQhpXwepjfN0qHG1qRT5a7IlApbfg78q+QDVHWHIHZ+e59HzpbEa/G3Ks8KLv6f4K9eWjN+lDw1yFYbOvmHF4l9z1RpiXPH7fBAgcgeUxP7cXHq4HUshr07pAgKziHj8Go=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <venkatkumar.ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <venkatkumar.ande@amd.com>,\n <stable@dpdk.org>", "Subject": "[PATCH v2 06/25] net/axgbe: yellow carp devices do not need rrc", "Date": "Tue, 7 May 2024 18:12:46 +0530", "Message-ID": "<20240507124305.2318-6-venkatkumar.ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240507124305.2318-1-venkatkumar.ande@amd.com>", "References": "<20240412125013.10498-1-VenkatKumar.Ande@amd.com>\n <20240507124305.2318-1-venkatkumar.ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SN1PEPF00036F40:EE_|IA0PR12MB8351:EE_", "X-MS-Office365-Filtering-Correlation-Id": "518f642b-b6a1-49f9-4532-08dc6e9356ea", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|376005|36860700004|1800799015|82310400017;", "X-Microsoft-Antispam-Message-Info": "\n OLIQ+qkuoA/z+h933tox80X1HqBiTmNoOzGM2/bKkziAXoXEc92u7hFngtP8+az5rBCTTOw6uQ69HP4xHi0mXdHRbvCkTUSnOJzdrL7+wzzNtObnr0OfPrvY3+l8/sVNyxDeB2QU3mYkMBBFt2sz2Rb5cuUbnRrg8vGXmqXm8L/qbo6wnVyph4bm2bgdI5zLwh4iL52IjttYs+keFhjg86KrqB+Bny7ZF3lABnwYeeCY1uMZ4uakzlgl4E8c3IyRlIku03+UMcwYr6BmDssh8L2Dip2V1fZO8f9otnNp5lhlTWliCpuW4Jepbj5m0rAlpN6C9DcAyMeAQQDgzSAjsHpbDXEagA7fB+KJfTZkPnShCkv1YQmwaGlHzWYgX2evRO3DWlIvai1q0tAGQEI/Uh0PJuDp6i2sBAFUOgqRDeLsVUWYIGuKxKc16tAKmKbQV/QrcQoTGhv4xbs+wbb/oEv4+eHElp5WlhFP17UKQv9oC89tHkYvwRN4FW1o+JIfsIh4nyAJ+JTCwlD/E9pjKeyQgY/TtTIw20ngYGUm8IAbHqwFCk7Nrr34YapB4+7sGRAwRbJ9KTau72nMSb6q06ldX9XFMFCFJLdZiLw73QqFTwJ58xS74FSDDtdRV01CRdnYQJ0hV/yQMrB3ptniFqdGwtkJqdsMsj3ainFq813yJrKzGuHc2UymTcGIEuFV4WxgekY489NeyEp2y0aXTPlb6zT7Kn2r/Mn1tjigrhzCZYC70Gv2lrnwXwuW4tZE9SPF+FUdd6ogx5/Oy2vBM0ZvvAGZBurIrO8w+BELwBolAiiMDgL9lmfAtZObnij45F/uAljuNT+8ujIbOoHl+31rQN6rNmUM9fXuRgbJc1MTkLNJPJ3bW36MlFibmzEc0+TlwWMx4YSLPN+KfmbfQTWUMeyy92KIdj8k7/KcB1B29XIVNyxD9OsIDvqhvpnR+jHrB+c41EIq4zUsBpByA8DxBSwtkK4A7PMubXUU5LbYM9bW7IuEy8Z4wVK9tmBEp7bYJoLgfnaYngyrhjxgSO4Tc5Lo1yxBgs8XqgbLD+rmdBVVsVatSWWJyCr6xe5ArP3v2jCmUNHyi9LyWlLTUzRY0D9TpfL9RMPxAKBTq2ZFkAEFoFzJ2zxzS8VY+sgS73OHBC5LpP9vkxdxlIJ4uJEF0CJK5BDcEZll0cgByp4aj08kreeSY7soC3mKgULzmuC9tvBH0JFELUAkpPNlE82/G3h3P47mxht1IYoGN7apgXErYKae491BmqwLCsvXWsPARsWnnQffjzMKvSUMBuSf4ICx8HGYWlylIisZCIKccy5RNpzFOt9+nVrWIGs5hGMnsuLj2PAl/61dMh3AWUgZJ8U1o8iPnyFNubdNTkMbKPPWF6e2LoLIRyvRnn/Z", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(376005)(36860700004)(1800799015)(82310400017); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 May 2024 12:43:47.6428 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 518f642b-b6a1-49f9-4532-08dc6e9356ea", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SN1PEPF00036F40.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "IA0PR12MB8351", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Link stability issues are noticed on Yellow carp platforms when Receiver\nReset Cycle is issued. Since the CDR workaround is disabled on these\nplatforms, the Receiver Reset Cycle is not needed.\n\nSo, avoid issuing rrc on Yellow carp platforms.\n\nWithout the fix the user will not get the link UP.\n\nFixes: a5c7273771e8 (\"net/axgbe: add phy programming APIs\")\nCc: stable@dpdk.org\n\nSigned-off-by: Venkat Kumar Ande <venkatkumar.ande@amd.com>\n---\n drivers/net/axgbe/axgbe_ethdev.c | 5 +++++\n drivers/net/axgbe/axgbe_ethdev.h | 1 +\n drivers/net/axgbe/axgbe_phy_impl.c | 2 +-\n 3 files changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex e5d8f7db02..86c2ec64e0 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -208,6 +208,7 @@ static struct axgbe_version_data axgbe_v2a = {\n \t.ecc_support\t\t\t= 1,\n \t.i2c_support\t\t\t= 1,\n \t.an_cdr_workaround\t\t= 1,\n+\t.enable_rrc\t\t\t= 1,\n };\n \n static struct axgbe_version_data axgbe_v2b = {\n@@ -220,6 +221,7 @@ static struct axgbe_version_data axgbe_v2b = {\n \t.ecc_support\t\t\t= 1,\n \t.i2c_support\t\t\t= 1,\n \t.an_cdr_workaround\t\t= 1,\n+\t.enable_rrc\t\t\t= 1,\n };\n \n static const struct rte_eth_desc_lim rx_desc_lim = {\n@@ -2269,6 +2271,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)\n \n \t\t\t/* Yellow Carp devices do not need cdr workaround */\n \t\t\tpdata->vdata->an_cdr_workaround = 0;\n+\n+\t\t\t/* Yellow Carp devices do not need rrc */\n+\t\t\tpdata->vdata->enable_rrc = 0;\n \t\t} else {\n \t\t\tunknown_cpu = 1;\n \t\t}\ndiff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h\nindex df5d63c493..f122dfd516 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.h\n+++ b/drivers/net/axgbe/axgbe_ethdev.h\n@@ -463,6 +463,7 @@ struct axgbe_version_data {\n \tunsigned int ecc_support;\n \tunsigned int i2c_support;\n \tunsigned int an_cdr_workaround;\n+\tunsigned int enable_rrc;\n };\n \n struct axgbe_mmc_stats {\ndiff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex ee9dcbe3da..f51830f800 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -1708,7 +1708,7 @@ static int axgbe_phy_link_status(struct axgbe_port *pdata, int *an_restart)\n \t}\n \n \t/* No link, attempt a receiver reset cycle */\n-\tif (phy_data->rrc_count++) {\n+\tif (pdata->vdata->enable_rrc && phy_data->rrc_count++) {\n \t\tphy_data->rrc_count = 0;\n \t\taxgbe_phy_rrc(pdata);\n \t}\n", "prefixes": [ "v2", "06/25" ] }