Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139959/?format=api
{ "id": 139959, "url": "https://patches.dpdk.org/api/patches/139959/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1715019531-22796-20-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1715019531-22796-20-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1715019531-22796-20-git-send-email-roretzla@linux.microsoft.com", "date": "2024-05-06T18:18:51", "name": "[v3,19/19] build: enable vla warnings on Windows built code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d4094c229574966076a3fd883bb8d53ed751ca47", "submitter": { "id": 2077, "url": "https://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1715019531-22796-20-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31887, "url": "https://patches.dpdk.org/api/series/31887/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31887", "date": "2024-05-06T18:18:33", "name": "remove use of VLAs for Windows", "version": 3, "mbox": "https://patches.dpdk.org/series/31887/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139959/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/139959/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B17DF43F5C;\n\tMon, 6 May 2024 20:20:45 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9D2DB427E4;\n\tMon, 6 May 2024 20:19:22 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 8A95D40649\n for <dev@dpdk.org>; Mon, 6 May 2024 20:18:55 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id D6CC520B2C9F; Mon, 6 May 2024 11:18:53 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com D6CC520B2C9F", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1715019533;\n bh=LjoMEn0aPH4lteVUXR+zqADvR7rGOigvBbve9R5R/aA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=oIVadX6mmICkwSK/4fhNOFqfzrPqjAbFDsFbHVMCpW5FFar/wiEpeLLiGjsJIQ7oI\n YOsS1Drub3t84X6PoJUqi81BYfzIo/1LOv+fxNF82kC+4dJKaMNaprbI1TBIEyx6PT\n lPLxfL5gR6grvCrTKK+vabbrrYRP/qsINWzTLoQw=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>, Suanming Mou <suanmingm@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>", "Subject": "[PATCH v3 19/19] build: enable vla warnings on Windows built code", "Date": "Mon, 6 May 2024 11:18:51 -0700", "Message-Id": "<1715019531-22796-20-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1715019531-22796-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>\n <1715019531-22796-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MSVC does not support optional C11 VLAs. When building for Windows\nenable -Wvla so that mingw and clang also fail if a VLA is used.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n config/meson.build | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 8c8b019..9e887f2 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -344,6 +344,10 @@ if cc.get_id() == 'intel'\n warning_flags += '-diag-disable=@0@'.format(i)\n endforeach\n endif\n+# no VLAs in code built on Windows\n+if is_windows\n+ warning_flags += '-Wvla'\n+endif\n foreach arg: warning_flags\n if cc.has_argument(arg)\n add_project_arguments(arg, language: 'c')\n", "prefixes": [ "v3", "19/19" ] }