Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139826/?format=api
{ "id": 139826, "url": "https://patches.dpdk.org/api/patches/139826/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240503042715.344550-1-getelson@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240503042715.344550-1-getelson@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240503042715.344550-1-getelson@nvidia.com", "date": "2024-05-03T04:27:14", "name": "[v3] cmdline: increase input buffer size", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "87bf06d5e70e5593eb80936e862a04c1f5f348d0", "submitter": { "id": 1882, "url": "https://patches.dpdk.org/api/people/1882/?format=api", "name": "Gregory Etelson", "email": "getelson@nvidia.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240503042715.344550-1-getelson@nvidia.com/mbox/", "series": [ { "id": 31872, "url": "https://patches.dpdk.org/api/series/31872/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31872", "date": "2024-05-03T04:27:14", "name": "[v3] cmdline: increase input buffer size", "version": 3, "mbox": "https://patches.dpdk.org/series/31872/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139826/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139826/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 40F2543EC1;\n\tFri, 3 May 2024 06:28:02 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1BF71402D1;\n\tFri, 3 May 2024 06:28:02 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2055.outbound.protection.outlook.com [40.107.236.55])\n by mails.dpdk.org (Postfix) with ESMTP id 2B799402CF\n for <dev@dpdk.org>; Fri, 3 May 2024 06:28:00 +0200 (CEST)", "from MN2PR15CA0060.namprd15.prod.outlook.com (2603:10b6:208:237::29)\n by SN7PR12MB6983.namprd12.prod.outlook.com (2603:10b6:806:261::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Fri, 3 May\n 2024 04:27:56 +0000", "from BN3PEPF0000B370.namprd21.prod.outlook.com\n (2603:10b6:208:237:cafe::99) by MN2PR15CA0060.outlook.office365.com\n (2603:10b6:208:237::29) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.35 via Frontend\n Transport; Fri, 3 May 2024 04:27:56 +0000", "from mail.nvidia.com (216.228.117.160) by\n BN3PEPF0000B370.mail.protection.outlook.com (10.167.243.167) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7519.0 via Frontend Transport; Fri, 3 May 2024 04:27:55 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 2 May 2024\n 21:27:32 -0700", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 2 May 2024\n 21:27:29 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=PzpBOVAh6fh5+pOLch2Z2E3P6SQ0WUY3U9psnSi74OTtLuXZZzPdYFBsxLuIyZwwcxBB6a0VkFEbfpKoqP64vA5ENXTKVmMW9SaXfK0IeOiJPnxhWJxZI9/EgmqHEiZuzushjQMp0l9hH/zKaLYzI4hBWfYdIVhNVMNHl8SwA/9C3c+WlYbqhlYa4oYBy40q51/FArEjyK3Xd4CR4UJG1a3uH1payPyxcjbxDo50h+x2H2p33AnRZhfqRE25vHbO4MG815HLzRtB2KSYcspuRUzBu9/iesxocoFYwBupMfFseILAmJTYprJM1vaFQYO+VK/BwmtdCgj6pLhUxhEPOg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=1hxCpX/D35UU1jp95TXHko1sCs5aIKCrYuqxukTkHHA=;\n b=esmfUOlyozbMm99x4vidE+H0woWjBpNaSz98VcVOELGNyCQQGsirQOnZZCYZQnsGtKdLAk+Slm7zgEDxEXPxSJERk7Fdj/TJ7wE24BsbkvUlJj7p6Lz8xYNMIgw8qBKLtdrKMjA9U5dljCRMg9I7nRbb3qGBurpgDmvdpk94OZVE04uS/9CAV+l37WgJcyWP0THbiBZhQHvsOi6HajV/QIUOB0oqoXDjKnDwTfTAyg4Tx7RsIC394/q9jWpkhEvCSDiT288NypPEOfFNmx4zVwtq65cIsFDLfwoDGsf8ilBDcFxSf78KS4R2PVPCs/m2S/GYdi7rFP9NBZukaXJFuQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=1hxCpX/D35UU1jp95TXHko1sCs5aIKCrYuqxukTkHHA=;\n b=l4HyTqS4YANQmPuzgUyET/8Ig4WKWvkUQ9r3PEpYbmtuGgG2IcU1G3U4Oi2fubb+GFl493QEfGWND4lzcxFtwbGwSRcW0gWVJrRHnWUFtyct4Cg+2JYnfwYUf0gzVvOU+4GWpC4J+NbTAYV+P+swf7wAt15VaoYNeYgRZcKWpjbX/BUaLJ1qVcmE/W0H0wh90D8W7TkzagmPYopBpKNl0gp2FqW2efI1rbkG2I0Rm7qn0ow4mfwFhU23D1etSnSRfJXDlZlfY35Vqrk+z5Ohbhxm0j8GuSFB7oKLQoLROKQVKGJLkd/xkHpmbMWHEO1jG+2+TTr2voO6sgemcTahcw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Gregory Etelson <getelson@nvidia.com>", "To": "<getelson@nvidia.com>", "CC": "<alialnu@nvidia.com>, <dev@dpdk.org>, <mkashani@nvidia.com>,\n <rasland@nvidia.com>, <bruce.richardson@intel.com>,\n <stephen@networkplumber.org>, <mb@smartsharesystems.com>", "Subject": "[PATCH v3] cmdline: increase input buffer size", "Date": "Fri, 3 May 2024 07:27:14 +0300", "Message-ID": "<20240503042715.344550-1-getelson@nvidia.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240501052659.231457-1-getelson@nvidia.com>", "References": "<20240501052659.231457-1-getelson@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN3PEPF0000B370:EE_|SN7PR12MB6983:EE_", "X-MS-Office365-Filtering-Correlation-Id": "98f647f9-0f55-469e-a6ab-08dc6b2967c2", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;ARA:13230031|376005|36860700004|1800799015;", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?bDYUijF69igKSfmaqLF6643G+bAaZoA?=\n\t=?utf-8?q?4K3vpnv11/oFdGYLX24PrOEQjLl5dbcnGpAf2YC2G3FV7ZXIQYt50hd8K2F1GOY7X?=\n\t=?utf-8?q?UIbyjdVKR2oNe/AYZwMeFsNlZx+uK4VwQAathag1CATqIFIPfPs+c0IIk5qcWFico?=\n\t=?utf-8?q?Qy/Loy6d5v2LbE2l9dWSZeTEUPHrQWw0wuLwTRTa084HJDjq4weGNMF7/zCaDxArQ?=\n\t=?utf-8?q?AMof390nGb1KdMgQhSyicnfuwAmi1zGvYlp9uTYJwDnZLsLHr8KiHjEgDl9pOcrB6?=\n\t=?utf-8?q?e6fZ+udJawy9FtWa3wfbuuhItk+xOErWm0ndYZfPyM9Fb1qXczV292CDlVqu7BtEF?=\n\t=?utf-8?q?MZRbYI4iYKx9rPnecZCRUHcS/xz9COoy3QF7xyqgCdVUQY3F4i1fbJ616MZSExLLp?=\n\t=?utf-8?q?nmiQBOwwZgGy/pAIUsXNTLMNA0GAmRjCmEooVA/LixVVPVZsgb5ncYu4fRCVf3rCU?=\n\t=?utf-8?q?RqYd+XY7qGCP5KRlwnDlnwOmiEEo1sC0Yds+BKQe1+uYRi4uc/v47FvoYXqVJzr0H?=\n\t=?utf-8?q?09/KuPXxhOytV6mWkzOhA7D0dBQ/HLQuv4VNJMyUe/JGuReVLgRGebtp8YMFNqaAS?=\n\t=?utf-8?q?2SNNnr+R7Zz3fk5AC7rAJcu/5MkCk/vIMPRJ69h+ptSzyyC0UKo9lNf3yXvvBMvJW?=\n\t=?utf-8?q?+dnHx+tC6a85C/MZ9e+2qbuBXRbxfFm3St7XOxrldI2tB1U0Odm05yJEcpgXrJnnm?=\n\t=?utf-8?q?OITxpKUwphu4EueS6dQYE2CHHh5hZmyU/SmpmDR2pFcC+pn3bsLANAoVc2ry1X6QF?=\n\t=?utf-8?q?NkIV8d19i4aKB8k0RTyNvO0Xw+j+KtfsGFz7dLfVUIHjp9eehTbfVeE53XaMFu8UC?=\n\t=?utf-8?q?HW79gM8qQGgPSa4lL0+Xr10fCaVJhxFtN735OY1103jzta7eTzwCiHr2TkQUpEN1w?=\n\t=?utf-8?q?llqYTTwvTwxKV5MMUbe2xxAE5S2rKeLgQdLHr8J0owUDQdammINp5CwVEVPscnBW3?=\n\t=?utf-8?q?34E2Fb1bk7WXk8pj5nINReee7/4OX9/M2lT193ktGLFFSQLze8/nXRAD04Fh+yryw?=\n\t=?utf-8?q?w+jFRu45nnd/t+FDveZy+s8Ey7wX5O4XxVKpoV4Zx8e6hG7JR38JfIjlC/BP/DFQx?=\n\t=?utf-8?q?gSyIJGOotJv2gQXVjhSKO9STHGR8IZwQJjNy3vJPt63UX0GHjN+PYRK185pyfv2QB?=\n\t=?utf-8?q?qc1HbqZq81ysmSsl/HNBrJF3kPmW1D7aI5cFQ67uL++1MyfW+lsiVC4d5GlmYf4D7?=\n\t=?utf-8?q?xxYskt+jTChMR1kCvdSZSBCXTRUfSowbQeqxuEbQUN2tdP7OQfDtkA+26KZpA0Cfw?=\n\t=?utf-8?q?Soya7FN9ufnSY6EG9AxUa1QxzAog0tNYlqgfHg4sR9W89WdMpeyGF2qtaUJcd+VkO?=\n\t=?utf-8?q?7r4yzSYnutbT?=", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(376005)(36860700004)(1800799015); DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 May 2024 04:27:55.6377 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 98f647f9-0f55-469e-a6ab-08dc6b2967c2", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN3PEPF0000B370.namprd21.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN7PR12MB6983", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "DPDK defines cmdline input buffer size to 512 characters.\nThat buffer size can be too small for long application input.\nFor example, the following flow template API testpmd command is 444\nbytes long:\n```\nflow queue 0 create 0 template_table 1000 \\\n pattern_template 0 actions_template 0 postpone no \\\n pattern eth / ipv4 / udp / end \\\n actions modify_field op set dst_type tag dst_level 0 dst_offset 0 \\\n src_type value src_value 0x31 width 32 / \\\n modify_field op set dst_type ipv4_src src_type value \\\n src_value 10101010 width 32 / modify_field op add dst_type \\\n ipv4_ttl dst_level 0 dst_offset 0 src_type value \\\n src_value ff width 8 / count / jump group 100 / end\n```\n\nThe patch increases cmdline input buffer size to the LINE_MAX value,\nwhich typically is 2048 bytes.\n\nSigned-off-by: Gregory Etelson <getelson@nvidia.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nReviewed-by: Morten Brørup <mb@smartsharesystems.com>\n---\nv2: set RDLINE_BUF_SIZE to LINE_MAX\n change the patch subject.\nv3: fix Windows compilation error.\n---\n lib/cmdline/cmdline_private.h | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/cmdline/cmdline_private.h b/lib/cmdline/cmdline_private.h\nindex b64f363903..f00b025ecb 100644\n--- a/lib/cmdline/cmdline_private.h\n+++ b/lib/cmdline/cmdline_private.h\n@@ -11,13 +11,20 @@\n #include <rte_os_shim.h>\n #ifdef RTE_EXEC_ENV_WINDOWS\n #include <rte_windows.h>\n+#ifndef LINE_MAX\n+/**\n+ * The LINE_MAX value is derived from POSIX.\n+ * Windows environment may not have POSIX definitions.\n+ */\n+#define LINE_MAX 2048\n+#endif\n #else\n #include <termios.h>\n #endif\n \n #include <cmdline.h>\n \n-#define RDLINE_BUF_SIZE 512\n+#define RDLINE_BUF_SIZE LINE_MAX\n #define RDLINE_PROMPT_SIZE 32\n #define RDLINE_VT100_BUF_SIZE 8\n #define RDLINE_HISTORY_BUF_SIZE BUFSIZ\n", "prefixes": [ "v3" ] }