Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139824/?format=api
https://patches.dpdk.org/api/patches/139824/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240502213618.11391-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240502213618.11391-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240502213618.11391-12-stephen@networkplumber.org", "date": "2024-05-02T21:31:47", "name": "[v12,11/12] net/tap: do not mark queue full as error", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "241cb12bc82da46babcf0d246de773729798765c", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240502213618.11391-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 31871, "url": "https://patches.dpdk.org/api/series/31871/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31871", "date": "2024-05-02T21:31:36", "name": "net/tap: RSS and other fixes", "version": 12, "mbox": "https://patches.dpdk.org/series/31871/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139824/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139824/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B7A9443F6C;\n\tThu, 2 May 2024 23:37:55 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D4B5A40C35;\n\tThu, 2 May 2024 23:36:48 +0200 (CEST)", "from mail-pf1-f169.google.com (mail-pf1-f169.google.com\n [209.85.210.169])\n by mails.dpdk.org (Postfix) with ESMTP id 65C1140647\n for <dev@dpdk.org>; Thu, 2 May 2024 23:36:37 +0200 (CEST)", "by mail-pf1-f169.google.com with SMTP id\n d2e1a72fcca58-6ecff9df447so8181926b3a.1\n for <dev@dpdk.org>; Thu, 02 May 2024 14:36:37 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n f14-20020a056a001ace00b006f3eee787d5sm1804829pfv.18.2024.05.02.14.36.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 May 2024 14:36:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714685796;\n x=1715290596; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=RWwBsJ4ML9/rUkp8HbuF8F4AkryvuWaG44tIHvrqUB8=;\n b=elvtuz7bxee43NMkZlIRLpN8yTMWbIzEnOQbzdcw+mGg8dKEJw3/3D55iw5s3Ok1mV\n kHYaHfAPYo6Bs2QYM6lJPoxivMluXSuXSW4/XaTSgGjQPabtpu19QiOXgfw163y1pafP\n /vy05EfveFSJjtTadvx3W0rMsKlZsgDL3bYqWxhTLqU4sFkeVhMQOcuCt7InxJA5oKSU\n BCz8j54pAbY/Edk3q6lAL7ih3EbZklwLOgFwZodjVLmXADMgceOHuTiaOwR4Vw2/FjkJ\n c9fDueRL6PTCBj1KnV8wT8fsEpISjyqN3gG61UdE5VYm1BmJ7rY1NfaTeJrrLrK+H46F\n 6rTQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1714685796; x=1715290596;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=RWwBsJ4ML9/rUkp8HbuF8F4AkryvuWaG44tIHvrqUB8=;\n b=P/eHrrvqlljbqrgSs9nSNiIg9uEqS10roOPSoTFn2iB2BL2Z7pREe9c7ZubUCh7rKy\n XoP4YlgJSkNgHDtJlynTkG8N7xfgG1g3mljCQQhOcH2aaK+BDKADn7FlPdgGnClUTlHT\n 0Aczw6GOXfWYyuVZTNzLHQ8ZIFU/D2xA2ENt2ScreTbe8mfWNSQ05WpmzAx/le3p2/NV\n Qed+7RCYL/J5ksiZ9Ljfx37Hg+ugi2SzKRmmcmSpxlwVQmvbJwcnXWDRNCN1hWsmaCeF\n Z8Ht+2e2GS+SOtFHCSK7nPpgXYiyIflnb2zUzstwh164IoS6RG86Oi5hkYAsaoH42LGR\n Q7/g==", "X-Gm-Message-State": "AOJu0YyeYbNlcdLKgv7T0XsgidJ0oIj+Ygvqyikqf/zRYobLHVlmTlH8\n IW2CLS6NhK4prOvDntxIbLawbFGn6nrZlfmzqemV7p0kRNpqupzPuQvtxzZJh2gPBjvHsc8n9Hr\n Eh984yg==", "X-Google-Smtp-Source": "\n AGHT+IGlz1FW2+OyBN1QCRw5PGLmnCB3uy1Qcjsh5/Ykjtku0Pii+JCwaY1YGr/h7z3mvfASCpRqiQ==", "X-Received": "by 2002:a05:6a00:2290:b0:6f0:b53c:dfb4 with SMTP id\n f16-20020a056a00229000b006f0b53cdfb4mr952375pfe.22.1714685796642;\n Thu, 02 May 2024 14:36:36 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v12 11/12] net/tap: do not mark queue full as error", "Date": "Thu, 2 May 2024 14:31:47 -0700", "Message-ID": "<20240502213618.11391-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240502213618.11391-1-stephen@networkplumber.org>", "References": "<20240130034925.44869-1-stephen@networkplumber.org>\n <20240502213618.11391-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If tap device in kernel returns EAGAIN that means it is full.\nThat is not an error.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/rte_eth_tap.c | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 2484a82ccb..485bd35912 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -542,7 +542,6 @@ tap_write_mbufs(struct tx_queue *txq, uint16_t num_mbufs,\n \t\tstruct rte_mbuf *seg = mbuf;\n \t\tuint64_t l4_ol_flags;\n \t\tint proto;\n-\t\tint n;\n \t\tint j;\n \t\tint k; /* current index in iovecs for copying segments */\n \n@@ -647,14 +646,18 @@ tap_write_mbufs(struct tx_queue *txq, uint16_t num_mbufs,\n \t\t}\n \n \t\t/* copy the tx frame data */\n-\t\tn = writev(process_private->fds[txq->queue_id], iovecs, k);\n-\t\tif (n <= 0)\n-\t\t\treturn -1;\n+\t\tif (unlikely(writev(process_private->fds[txq->queue_id], iovecs, k) < 0)) {\n+\t\t\tTAP_LOG(DEBUG, \"writev (qid=%u fd=%d) %s\",\n+\t\t\t\ttxq->queue_id, process_private->fds[txq->queue_id],\n+\t\t\t\tstrerror(errno));\n+\t\t\treturn (errno == EAGAIN) ? 0 : -1;\n+\t\t}\n \n \t\t(*num_packets)++;\n \t\t(*num_tx_bytes) += rte_pktmbuf_pkt_len(mbuf);\n \t}\n-\treturn 0;\n+\n+\treturn 1;\n }\n \n /* Callback to handle sending packets from the tap interface\n", "prefixes": [ "v12", "11/12" ] }{ "id": 139824, "url": "