Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 139805,
    "url": "https://patches.dpdk.org/api/patches/139805/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240502152816.65562-2-konstantin.v.ananyev@yandex.ru/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240502152816.65562-2-konstantin.v.ananyev@yandex.ru>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240502152816.65562-2-konstantin.v.ananyev@yandex.ru",
    "date": "2024-05-02T15:28:15",
    "name": "[1/2] examples/l3fwd: fix crash in ACL mode for mixed traffic",
    "commit_ref": null,
    "pull_url": null,
    "state": "new",
    "archived": false,
    "hash": "7c5de81fa19e54ac49877a850686092588694466",
    "submitter": {
        "id": 2660,
        "url": "https://patches.dpdk.org/api/people/2660/?format=api",
        "name": "Konstantin Ananyev",
        "email": "konstantin.v.ananyev@yandex.ru"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240502152816.65562-2-konstantin.v.ananyev@yandex.ru/mbox/",
    "series": [
        {
            "id": 31868,
            "url": "https://patches.dpdk.org/api/series/31868/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31868",
            "date": "2024-05-02T15:28:14",
            "name": "examples/l3fwd: ACL mode fixups and improvements",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/31868/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/139805/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/139805/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B030F43F69;\n\tThu,  2 May 2024 17:28:59 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3F4B9402E1;\n\tThu,  2 May 2024 17:28:59 +0200 (CEST)",
            "from forward502b.mail.yandex.net (forward502b.mail.yandex.net\n [178.154.239.146])\n by mails.dpdk.org (Postfix) with ESMTP id BA191402DD;\n Thu,  2 May 2024 17:28:57 +0200 (CEST)",
            "from mail-nwsmtp-smtp-production-main-37.myt.yp-c.yandex.net\n (mail-nwsmtp-smtp-production-main-37.myt.yp-c.yandex.net\n [IPv6:2a02:6b8:c12:1a4:0:640:b6:0])\n by forward502b.mail.yandex.net (Yandex) with ESMTPS id EBFFE5EEDF;\n Thu,  2 May 2024 18:28:56 +0300 (MSK)",
            "by mail-nwsmtp-smtp-production-main-37.myt.yp-c.yandex.net\n (smtp/Yandex) with ESMTPSA id bSVvo2YOeuQ0-KlCXZ9c9;\n Thu, 02 May 2024 18:28:56 +0300"
        ],
        "X-Yandex-Fwd": "1",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;\n t=1714663736; bh=4i4TFmEE0RKhzFuZUxzT6Bu8+5f6ZVg/Ej+wBuA6C1U=;\n h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=hlPj4YJBfBefldGdO0ewtyXs8y4F24aIVeVMsJu1R1GOldGSIw7f+hTpxdhJf5/Y9\n /RV3f+hHWQMHrz61joYaEd8Mg1/SdUJGOwoMtvMP9FzrrJimFOz9B7rwtpCUU/dTuO\n pCCHWFdOUOvAtSZxBEds5L60XfHKmNVZ/xOQDkFw=",
        "Authentication-Results": "\n mail-nwsmtp-smtp-production-main-37.myt.yp-c.yandex.net;\n dkim=pass header.i=@yandex.ru",
        "From": "Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>",
        "To": "dev@dpdk.org",
        "Cc": "Konstantin Ananyev <konstantin.ananyev@huawei.com>,\n\tstable@dpdk.org",
        "Subject": "[PATCH 1/2] examples/l3fwd: fix crash in ACL mode for mixed traffic",
        "Date": "Thu,  2 May 2024 16:28:15 +0100",
        "Message-Id": "<20240502152816.65562-2-konstantin.v.ananyev@yandex.ru>",
        "X-Mailer": "git-send-email 2.34.1",
        "In-Reply-To": "<20240502152816.65562-1-konstantin.v.ananyev@yandex.ru>",
        "References": "<20240502152816.65562-1-konstantin.v.ananyev@yandex.ru>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n\nWhen running l3fwd in ACL mode, if we'll have mix of IPv4/IPv6 packets in\nthe same burst, it will most likely cause a crash.\nThe reason for that is that we split our burst of packets into 2 arrays -\none for ipv4, another for ipv6 for classify().\nBut then we try to send all packets as one burst again, not taking into account\nthat acl_search.res_ipv4[] will be set only for ipv4 packets.\nSame story for ipv6.\nThe fix is straightforward: use two already split arrays for TX.\n\nBugzilla ID: 1434\nFixes: 6de0ea50e9b9 (\"examples/l3fwd: merge l3fwd-acl example\")\nCc: stable@dpdk.org\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n---\n examples/l3fwd/l3fwd_acl.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/examples/l3fwd/l3fwd_acl.c b/examples/l3fwd/l3fwd_acl.c\nindex 401692bcec..d9e4ae543f 100644\n--- a/examples/l3fwd/l3fwd_acl.c\n+++ b/examples/l3fwd/l3fwd_acl.c\n@@ -1073,9 +1073,9 @@ acl_main_loop(__rte_unused void *dummy)\n \n \t\t\t\t\tl3fwd_acl_send_packets(\n \t\t\t\t\t\tqconf,\n-\t\t\t\t\t\tpkts_burst,\n+\t\t\t\t\t\tacl_search.m_ipv4,\n \t\t\t\t\t\tacl_search.res_ipv4,\n-\t\t\t\t\t\tnb_rx);\n+\t\t\t\t\t\tacl_search.num_ipv4);\n \t\t\t\t}\n \n \t\t\t\tif (acl_search.num_ipv6) {\n@@ -1088,9 +1088,9 @@ acl_main_loop(__rte_unused void *dummy)\n \n \t\t\t\t\tl3fwd_acl_send_packets(\n \t\t\t\t\t\tqconf,\n-\t\t\t\t\t\tpkts_burst,\n+\t\t\t\t\t\tacl_search.m_ipv6,\n \t\t\t\t\t\tacl_search.res_ipv6,\n-\t\t\t\t\t\tnb_rx);\n+\t\t\t\t\t\tacl_search.num_ipv6);\n \t\t\t\t}\n \t\t\t}\n \t\t}\n",
    "prefixes": [
        "1/2"
    ]
}