Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139719/?format=api
https://patches.dpdk.org/api/patches/139719/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240429095138.106849-3-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240429095138.106849-3-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240429095138.106849-3-mattias.ronnblom@ericsson.com", "date": "2024-04-29T09:51:34", "name": "[RFC,v3,2/6] eal: add unit tests for bit operations", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7633aceed04cf17da768ee6e05d0aa082df59f24", "submitter": { "id": 1077, "url": "https://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240429095138.106849-3-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 31838, "url": "https://patches.dpdk.org/api/series/31838/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31838", "date": "2024-04-29T09:51:32", "name": "Improve EAL bit operations API", "version": 3, "mbox": "https://patches.dpdk.org/series/31838/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139719/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/139719/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 524A643F49;\n\tMon, 29 Apr 2024 12:02:17 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 110B9402C7;\n\tMon, 29 Apr 2024 12:02:10 +0200 (CEST)", "from EUR01-DB5-obe.outbound.protection.outlook.com\n (mail-db5eur01on2071.outbound.protection.outlook.com [40.107.15.71])\n by mails.dpdk.org (Postfix) with ESMTP id D76EC402C9\n for <dev@dpdk.org>; Mon, 29 Apr 2024 12:02:07 +0200 (CEST)", "from AM6P194CA0057.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::34)\n by PAXPR07MB8890.eurprd07.prod.outlook.com (2603:10a6:102:249::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Mon, 29 Apr\n 2024 10:02:06 +0000", "from AMS0EPF00000198.eurprd05.prod.outlook.com\n (2603:10a6:209:84:cafe::f8) by AM6P194CA0057.outlook.office365.com\n (2603:10a6:209:84::34) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34 via Frontend\n Transport; Mon, 29 Apr 2024 10:02:06 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n AMS0EPF00000198.mail.protection.outlook.com (10.167.16.244) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7544.18 via Frontend Transport; Mon, 29 Apr 2024 10:02:06 +0000", "from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.63) with Microsoft SMTP Server\n id 15.2.1544.9; Mon, 29 Apr 2024 12:02:05 +0200", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id\n 8A3081C006A; Mon, 29 Apr 2024 12:02:05 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=lzFLinzKzKGaI38egi4VplPfEsVQpqQn7F2v6uDkH/uhRwKfrRmhMEFkM/zNCQ261yfbi9yK5bw5ZYwsvnwIFCbbhxpaQ760ZejY450VpjS8UQhZa7P9XGpz0IJVYJa5si9ZAqSuxkkifJgvfocv6UlEpVV7btkPvTR6yjGgoGVkrDzFBJ4mm9sE0pw411zhlK49fa4SDpJypegTc7f5h+xW0tQaHLcxT42b6W918LldrZKQfBYB5XnyC2Cak3jL2uUUrfBOr8PbigmYCXWyOkpO2BmIqssYOU5kQtcUbE4RVoaDGKwGc12YSVNyDpVFOGy/wcXuAlBCtyZgbRCToQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=UAXttjTnMNYVno4iLY1+608dHrWTK4YyrJUpoliiT/k=;\n b=Fxrd5z3fLO1KvtcWjh6DD02vXc8MqhHthlhBeALQ+g1D85FsFDLa3Xx2RvQoubmyCym9OAKaq9tieSUXy3Ma3smEGFgmeCX69kbhiikKs2dtVmMaBwg4umyv0jX8lASI2HAn6baUdfUHh6Ub8CZn2J/J/XL4tV4/XDb88FTtlbqDMvSevZIeXKvzO4V4RvVkHPk6uIdDurmQspZrxk8ztZnMKUMX/XXGiPkCfZq0yAGBtRIZaCQNG9qMHZsqcpvgfu1+uaz3plNYGInE+G31TsugP4LiwB4Dcvcbzmtn7gF0y8sitmT+S1gFam6oygsymWyeqwDAbzUUSM1RRx7OdQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=UAXttjTnMNYVno4iLY1+608dHrWTK4YyrJUpoliiT/k=;\n b=Kc15a8DwnxeGk17KHZ8kiNt5MrzVmTYOkq/y22WpUnMoH33lSmKdlFrWlSQK+BrtDfUwte8/i+7Vrq383Ge4L9V0SVapaISQrUFKVAtQIPeiMOnqBUXfOqYUhJp0s5MdyH20Cte/TGjkFl7oxI3KfjKy+36VLX6kn5cCfrJTHr3OsUGyU/YJm5ILqlhN4O4uP2CtqTGmt8TG0jScPaiohEIJhrY5nD7JiPNv4GEWHZk1LGPKiHr+jmbajsiTpl7qBLwSDefnrWkUURMpK2dmfDYKydgzRiYWUSj+XqZ0MqQgfhKl7I3FULF6L5wUdxfxeuDf0ARAsVTvPpd7B6mKgg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>, Heng Wang <heng.wang@ericsson.com>,\n \"Stephen Hemminger\" <stephen@networkplumber.org>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>, =?utf-8?q?Mattia?=\n\t=?utf-8?q?s_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "Subject": "[RFC v3 2/6] eal: add unit tests for bit operations", "Date": "Mon, 29 Apr 2024 11:51:34 +0200", "Message-ID": "<20240429095138.106849-3-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240429095138.106849-1-mattias.ronnblom@ericsson.com>", "References": "<20240425085853.97888-2-mattias.ronnblom@ericsson.com>\n <20240429095138.106849-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AMS0EPF00000198:EE_|PAXPR07MB8890:EE_", "X-MS-Office365-Filtering-Correlation-Id": "342fc930-fffe-4b2d-70db-08dc68336cfc", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|376005|36860700004|82310400014|1800799015;", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?vmUivJl4WxgJbRbzSmSLF1CgfbVK++E?=\n\t=?utf-8?q?OjSPLHILn+dk+tHY2BcTmes3KHAx6ittbny8QQ403mAMu0MzADgqtytdKnGrgRzdA?=\n\t=?utf-8?q?YG0y+8qqA3dkPxnJ3Xklos3C9cQuwk7oYHeoTKYsUzfTWOBGa2B1FGYdHI0CAXTZF?=\n\t=?utf-8?q?MkptkOq+GgcsDnApuDtJSYJnBNPrCSW+iGxA/rvT0aaoy4xJ4fjwDpTnYD4olDrKV?=\n\t=?utf-8?q?VU9qN6bW/ztg9JAXMx7nYEzUvr8TgOnNtyyp1HaFLUXBQPixDPThfzk/RUDvUaIvd?=\n\t=?utf-8?q?5e/ZrKd+HvelPqhC50VjMXFX+/HAH0JlYFcKR4ZFsi2712SieYXonGJXbjCSDZR2S?=\n\t=?utf-8?q?4F+jeJ5+OgaGVOzeYV24iM1HA5X31cL92RQ67xc9KsZH5VsAvLiXpKIGgHy5h+mnU?=\n\t=?utf-8?q?mgQyjw55OEc6bilZBzTe27idFyrGcRLvHVcxfuOTdK9ftyDajF8zxZXP8fPsuqCXB?=\n\t=?utf-8?q?FS2Xw6A8CI+oB1BaM8X3wRLDuhrFz7Sqy/v/6Q0jbJwo/LbpNZC52pDnqxZ4NpxhM?=\n\t=?utf-8?q?JDQ5Om2gXCxoOHsk1PJpmNyW21vS+5PSyMrKZroBcPSOJgWlTXLI/picHXawwQQIb?=\n\t=?utf-8?q?JclKwu+Gveuc20S2ig6v0wQO15/Wad76qDjX6D1n7e5MgFF6AoBMxEPBwE2VZJTwx?=\n\t=?utf-8?q?BeCw3FBkiI+gis7u3rXVDjt08ctQ5yGiJDMJrPiU561Gb3nmq/7MRY3TnpCnkkpyD?=\n\t=?utf-8?q?+HpJfl2DaLxI2cgiP8qF7mJEunZoFAT0nL4ndJkpGtptBlzmakFQPZ9CCPim0/FWl?=\n\t=?utf-8?q?N72mL1AfIuncG2EStds0KIjlXE+KMOsq6k3AeJV3YbFUntII93ex0mArVwxtjggFB?=\n\t=?utf-8?q?xYHD1mU33ka1I1yHjP0n9f958TlJB/8UJl8GFFthylVZJFH4viH0ho29PxsBqHZ4S?=\n\t=?utf-8?q?X/rni4p+EKHD8lOca+b0b7cDOv8wy4srUfEp5S0dhOgLWWg9Ql7PYc+ho9K2Ojv47?=\n\t=?utf-8?q?lpkmx+/lcUUQz7sh84PXqVaKAjT+zH1WDV5G5vpJaA4h15JgDdi1EaEHif0qHhgFq?=\n\t=?utf-8?q?KAd0gd4vIlZAoIAoxxRIvxRpJn5p/yqcEiW1tXx+YAOZA/P8ROsW9eJcqZN7RFlH4?=\n\t=?utf-8?q?4mHNJeaqPpjReNvbA33vdyqMhNBV9e5wWv1mTpvmj2Fdp7pm5lZskFVvD3c6kVEOj?=\n\t=?utf-8?q?j3DZLahfm8SQEPhzpblzqnz6JUHwemHFvT6x4fd/KFIBW6XRYnK/+fO6mW8AiY2IU?=\n\t=?utf-8?q?pFA+mpi2hINh3StrPvs+kFh9HGnjAW7GzGBRZKGeHJQfbqdTLwISfGmdvbg//LD9v?=\n\t=?utf-8?q?fhPm5zFQl5kvWdVW0zro26h0x6gXFgQODpvcUkgtBC1/DQzhXHONuow53wZr7tQxQ?=\n\t=?utf-8?q?mbFsW7fvzKDr?=", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE; SFS:(13230031)(376005)(36860700004)(82310400014)(1800799015);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "29 Apr 2024 10:02:06.0246 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 342fc930-fffe-4b2d-70db-08dc68336cfc", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n AMS0EPF00000198.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PAXPR07MB8890", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Extend bitops tests to cover the rte_bit_[set|clear|assign|test]()\nfamily of functions.\n\nThe tests are converted to use the test suite runner framework.\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n app/test/test_bitops.c | 76 +++++++++++++++++++++++++++++++++---------\n 1 file changed, 61 insertions(+), 15 deletions(-)", "diff": "diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c\nindex 0d4ccfb468..f788b561a0 100644\n--- a/app/test/test_bitops.c\n+++ b/app/test/test_bitops.c\n@@ -1,13 +1,59 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n * Copyright(c) 2019 Arm Limited\n+ * Copyright(c) 2024 Ericsson AB\n */\n \n+#include <stdbool.h>\n+\n #include <rte_launch.h>\n #include <rte_bitops.h>\n+#include <rte_random.h>\n #include \"test.h\"\n \n-uint32_t val32;\n-uint64_t val64;\n+#define GEN_TEST_BIT_ACCESS(test_name, set_fun, clear_fun, assign_fun,\t\\\n+\t\t\t test_fun, size)\t\t\t\t\\\n+\tstatic int\t\t\t\t\t\t\t\\\n+\ttest_name(void)\t\t\t\t\t\t\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tuint ## size ## _t reference = (uint ## size ## _t)rte_rand(); \\\n+\t\tunsigned int bit_nr;\t\t\t\t\t\\\n+\t\tuint ## size ## _t word = (uint ## size ## _t)rte_rand(); \\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tfor (bit_nr = 0; bit_nr < size; bit_nr++) {\t\t\\\n+\t\t\tbool reference_bit = (reference >> bit_nr) & 1;\t\\\n+\t\t\tbool assign = rte_rand() & 1;\t\t\t\\\n+\t\t\tif (assign)\t\t\t\t\t\\\n+\t\t\t\tassign_fun(&word, bit_nr, reference_bit); \\\n+\t\t\telse {\t\t\t\t\t\t\\\n+\t\t\t\tif (reference_bit)\t\t\t\\\n+\t\t\t\t\tset_fun(&word, bit_nr);\t\t\\\n+\t\t\t\telse\t\t\t\t\t\\\n+\t\t\t\t\tclear_fun(&word, bit_nr);\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\t\t}\t\t\t\t\t\t\\\n+\t\t\tTEST_ASSERT(test_fun(&word, bit_nr) == reference_bit, \\\n+\t\t\t\t \"Bit %d had unexpected value\", bit_nr); \\\n+\t\t}\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tfor (bit_nr = 0; bit_nr < size; bit_nr++) {\t\t\\\n+\t\t\tbool reference_bit = (reference >> bit_nr) & 1;\t\\\n+\t\t\tTEST_ASSERT(test_fun(&word, bit_nr) == reference_bit, \\\n+\t\t\t\t \"Bit %d had unexpected value\", bit_nr); \\\n+\t\t}\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tTEST_ASSERT(reference == word, \"Word had unexpected value\"); \\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\treturn TEST_SUCCESS;\t\t\t\t\t\\\n+\t}\n+\n+GEN_TEST_BIT_ACCESS(test_bit_access_32, rte_bit_set, rte_bit_clear, \\\n+\t\t rte_bit_assign, rte_bit_test, 32)\n+\n+GEN_TEST_BIT_ACCESS(test_bit_access_64, rte_bit_set, rte_bit_clear, \\\n+\t\t rte_bit_assign, rte_bit_test, 64)\n+\n+static uint32_t val32;\n+static uint64_t val64;\n \n #define MAX_BITS_32 32\n #define MAX_BITS_64 64\n@@ -117,22 +163,22 @@ test_bit_relaxed_test_set_clear(void)\n \treturn TEST_SUCCESS;\n }\n \n+static struct unit_test_suite test_suite = {\n+\t.suite_name = \"Bitops test suite\",\n+\t.unit_test_cases = {\n+\t\tTEST_CASE(test_bit_access_32),\n+\t\tTEST_CASE(test_bit_access_64),\n+\t\tTEST_CASE(test_bit_relaxed_set),\n+\t\tTEST_CASE(test_bit_relaxed_clear),\n+\t\tTEST_CASE(test_bit_relaxed_test_set_clear),\n+\t\tTEST_CASES_END()\n+\t}\n+};\n+\n static int\n test_bitops(void)\n {\n-\tval32 = 0;\n-\tval64 = 0;\n-\n-\tif (test_bit_relaxed_set() < 0)\n-\t\treturn TEST_FAILED;\n-\n-\tif (test_bit_relaxed_clear() < 0)\n-\t\treturn TEST_FAILED;\n-\n-\tif (test_bit_relaxed_test_set_clear() < 0)\n-\t\treturn TEST_FAILED;\n-\n-\treturn TEST_SUCCESS;\n+\treturn unit_test_suite_runner(&test_suite);\n }\n \n REGISTER_FAST_TEST(bitops_autotest, true, true, test_bitops);\n", "prefixes": [ "RFC", "v3", "2/6" ] }{ "id": 139719, "url": "